senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Fix minor bugs #9

Merged
bilal.catic merged 4 commits from fix-minor-bugs into master 2019-05-24 15:54:41 +02:00
Conversation 9 Commits 4 Files Changed 14 +121 -90
bilal.catic commented 2019-05-22 16:22:12 +02:00 (Migrated from gitlab.com)
Copy Link

Note : Merge !8 before merging this PR - that is reason for WIP status.

¯\＿(ツ)＿/¯

New :

  • Skip garden size step if real estate type doesn't require garden size
  • Remove garden size data from request if real estate type is changed, and new type doesn't require garden size
  • Do not save garden size data to request if user came to garden size step manually entering URL, and real estate type doesn't require garden size
  • Simple email validation. On frontend, HTML5 form validation is used, and on backend, simple regex validation

Fixes :

  • Send icon on step items now works as intended
  • Clicking around item - on white space - now saves data correctly

SMOKE TESTS :

A

  1. Select type of real estate that doesn't require garden size (stan)
  2. Continue through steps, verify that garden size step is skipped
  3. Create new request
  4. Select type of real estate that REQUIRES garden size (kuca, vikendica)
  5. Continue through steps, verify that garden size step is shown
  6. Verify that garden size data is shown on query review step
  7. Edit Real estate type from review page, change to : stan
  8. Verify that garden size on query review page is showing '-' instead of previous data

B

  1. Create new request and proceed through steps while clicking only on send icon
  2. Verify that all data is saved correctly in database
  3. Create new request and proceed through steps while clicking around text of items
  4. Verify that all data is saved correctly in database

C

  1. Create new request
  2. Try to enter invalid string for email (blabla for example)
  3. Validate that form is not even POST-ed
  4. Try to enter invalid string like (blabla@email)
  5. Verify that form is POST-ed, but error is shown under input and email is not saved to the database
Note : Merge !8 before merging this PR - that is reason for WIP status. ¯\\＿(ツ)＿/¯ New : - Skip garden size step if real estate type doesn't require garden size - Remove garden size data from request if real estate type is changed, and new type doesn't require garden size - Do not save garden size data to request if user came to garden size step manually entering URL, and real estate type doesn't require garden size - Simple email validation. On frontend, HTML5 form validation is used, and on backend, simple regex validation Fixes : - Send icon on step items now works as intended - Clicking around item - on white space - now saves data correctly SMOKE TESTS : A 1. Select type of real estate that doesn't require garden size (stan) 2. Continue through steps, verify that garden size step is skipped 3. Create new request 4. Select type of real estate that REQUIRES garden size (kuca, vikendica) 5. Continue through steps, verify that garden size step is shown 6. Verify that garden size data is shown on query review step 7. Edit Real estate type from review page, change to : stan 8. Verify that garden size on query review page is showing '-' instead of previous data B 1. Create new request and proceed through steps while clicking only on send icon 2. Verify that all data is saved correctly in database 3. Create new request and proceed through steps while clicking around text of items 4. Verify that all data is saved correctly in database C 1. Create new request 2. Try to enter invalid string for email (blabla for example) 3. Validate that form is not even POST-ed 4. Try to enter invalid string like (blabla@email) 5. Verify that form is POST-ed, but error is shown under input and email is not saved to the database
bilal.catic commented 2019-05-22 16:22:22 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-05-22 16:22:34 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-05-22 16:57:33 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>dd38602c - add simple email validation</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/9/diffs?diff_id=42866312&start_sha=a3f76d20fe2689be52c59e29045bfd6b8e7f07e7)
bilal.catic commented 2019-05-22 17:05:27 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-05-22 17:05:27 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @nedimu

assigned to @nedimu
bilal.catic commented 2019-05-22 17:05:44 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2019-05-24 15:54:32 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nedimu commented 2019-05-24 15:54:41 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
nedimu commented 2019-05-24 15:54:41 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit a3d9a82fee

mentioned in commit a3d9a82feea93c80e195770d999f46c3e9760f08
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#9
Delete Branch "fix-minor-bugs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?