senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Enable return to query review directly #8

Merged
bilal.catic merged 1 commits from enable-return-to-query-review-directly into master 2019-05-24 15:53:29 +02:00
Conversation 5 Commits 1 Files Changed 7 +74 -57
bilal.catic commented 2019-05-21 15:41:16 +02:00 (Migrated from gitlab.com)
Copy Link

Note : Merge !7 before merging this PR - that is reason for WIP status.

¯\＿(ツ)＿/¯

This PR introduces option to skip rest of the steps if user came to current step from query review page
There is only one exception, when user selects region / city, next step is municipality selection, and then other steps are skipped.

SMOKE TEST :

  1. Complete steps until review step
  2. Click on edit icon for real estate type
  3. App should show real estate type page. Edit type and verify that next screen is review again
  4. Repeat process for other steps (region, municipality, size, garden size, price)
  5. Verify that next screen is always review page, except in case when region is selected for edit, when next page is municipality and then review page.
  6. Verify that data in database is changed accordingly
Note : Merge !7 before merging this PR - that is reason for WIP status. ¯\＿(ツ)＿/¯ This PR introduces option to skip rest of the steps if user came to current step from query review page There is only one exception, when user selects region / city, next step is municipality selection, and then other steps are skipped. SMOKE TEST : 1. Complete steps until review step 2. Click on edit icon for real estate type 3. App should show real estate type page. Edit type and verify that next screen is review again 4. Repeat process for other steps (region, municipality, size, garden size, price) 5. Verify that next screen is always review page, except in case when region is selected for edit, when next page is municipality and then review page. 6. Verify that data in database is changed accordingly
bilal.catic commented 2019-05-22 16:22:13 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !9

mentioned in merge request !9
nedimu commented 2019-05-24 15:53:08 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nedimu commented 2019-05-24 15:53:08 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2019-05-24 15:53:29 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
nedimu commented 2019-05-24 15:53:29 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 6772f8a953

mentioned in commit 6772f8a953c886d06aef5222f98f263f902255c7
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#8
Delete Branch "enable-return-to-query-review-directly"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?