fix practice summary report

This commit is contained in:
Bilal Catic
2019-10-07 09:55:00 +02:00
parent aa8931f91a
commit 639ba6b8cb

View File

@@ -503,15 +503,29 @@ const getMemberPracticeSummaryReport = (year) => {
const inactiveMemberIdsList = [];
memberIdsListFromReportMap.forEach((memberId) => {
if (membersMap[memberId].active){
activeMemberIdsList.push(memberId);
if (memberId){
if (membersMap[memberId] && membersMap[memberId].active){
activeMemberIdsList.push(memberId);
}else{
console.log('[Get Member Practice Summary Report] Unknown member ');
console.log('\tmemberId : ', memberId);
console.log('\tmembersMap[memberId] : ', membersMap[memberId]);
inactiveMemberIdsList.push(memberId);
}
}else{
inactiveMemberIdsList.push(memberId);
console.log('[Get Member Practice Summary Report] memberId is wrong : ', memberId);
}
});
const sortMemberIdsListByName = (memberId1, memberId2) => {
if (membersMap[memberId1].name > membersMap[memberId2].name){
const name1 = membersMap[memberId1] ? membersMap[memberId1].name || 'Unknown member' : null;
const name2 = membersMap[memberId2] ? membersMap[memberId2].name || 'Unknown member' : null;
if (!name1 || !name2){
return 0;
}
if (name1 > name2){
return 1;
}else{
return -1;