From 639ba6b8cbb1bb139aa7406afb63672c8ccd85fe Mon Sep 17 00:00:00 2001
From: Bilal Catic <bilal.catic@hotmail.com>
Date: Mon, 7 Oct 2019 09:55:00 +0200
Subject: [PATCH] fix practice summary report

---
 services/integration/reports.js | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/services/integration/reports.js b/services/integration/reports.js
index e5e0154..4d054e3 100644
--- a/services/integration/reports.js
+++ b/services/integration/reports.js
@@ -503,15 +503,29 @@ const getMemberPracticeSummaryReport = (year) => {
                         const inactiveMemberIdsList = [];
 
                         memberIdsListFromReportMap.forEach((memberId) => {
-                            if (membersMap[memberId].active){
-                                activeMemberIdsList.push(memberId);
+                            if (memberId){
+                                if (membersMap[memberId] && membersMap[memberId].active){
+                                    activeMemberIdsList.push(memberId);
+                                }else{
+                                    console.log('[Get Member Practice Summary Report] Unknown member ');
+                                    console.log('\tmemberId : ', memberId);
+                                    console.log('\tmembersMap[memberId] : ', membersMap[memberId]);
+                                    inactiveMemberIdsList.push(memberId);
+                                }
                             }else{
-                                inactiveMemberIdsList.push(memberId);
+                                console.log('[Get Member Practice Summary Report] memberId is wrong : ', memberId);
                             }
                         });
 
                         const sortMemberIdsListByName = (memberId1, memberId2) => {
-                            if (membersMap[memberId1].name > membersMap[memberId2].name){
+                            const name1 = membersMap[memberId1] ? membersMap[memberId1].name || 'Unknown member' : null;
+                            const name2 = membersMap[memberId2] ? membersMap[memberId2].name || 'Unknown member' : null;
+
+                            if (!name1 || !name2){
+                                return 0;
+                            }
+
+                            if (name1 > name2){
                                 return 1;
                             }else{
                                 return -1;