senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Changed checkup email logic. #97

Merged
RabbIT09-n merged 4 commits from checkup-email-bug-fix into master 2020-02-25 16:13:21 +01:00
Conversation 10 Commits 4 Files Changed 5 +52 -45
RabbIT09-n commented 2020-02-15 02:31:34 +01:00 (Migrated from gitlab.com)
Copy Link

Changed functions and logic for checkup email because of the bug. Migration needed.

Changed functions and logic for checkup email because of the bug. Migration needed.
RabbIT09-n commented 2020-02-15 02:39:54 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>22bffc12 - For staging - checkup fix.</li></ul> [Compare with previous version](/saburly/marketalarm/web/-/merge_requests/97/diffs?diff_id=75639844&start_sha=06f80296f371729265a3e9981d797e47e1a8c0d8)
edazdarevic commented 2020-02-17 11:37:28 +01:00 (Migrated from gitlab.com)
Copy Link

Mozes li malo objasniti koja je ideja ovdje? getDate vraca dan u mjesecu (vise ovdje), sta se desava ako je dan u mjesecu 1. a CHECK_UP_DAYS=5, kako to radi sa ovim setDays jer bi date bio negativan.

Mozes li malo objasniti koja je ideja ovdje? `getDate` vraca dan u mjesecu (vise [ovdje](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getDate)), sta se desava ako je dan u mjesecu 1. a CHECK_UP_DAYS=5, kako to radi sa ovim `setDays` jer bi date bio negativan.
RabbIT09-n commented 2020-02-17 16:11:29 +01:00 (Migrated from gitlab.com)
Copy Link

Ja sam iz nekog razloga mislila da getDate vraca cijeli trenutni datum ne samo dane. Ispravim pa napravim commit

Ja sam iz nekog razloga mislila da getDate vraca cijeli trenutni datum ne samo dane. Ispravim pa napravim commit
RabbIT09-n commented 2020-02-17 21:23:07 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/saburly/marketalarm/web/-/merge_requests/97/diffs?diff_id=75913922&start_sha=22bffc126d29782451309854dde1e0353a405a63#4008a7e5db195b21917a73b7f4e00687d40aa881_23_21)
RabbIT09-n commented 2020-02-17 21:23:07 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • bc7ce9d7 - Changed checkup query to miliseconds.

Compare with previous version

added 1 commit <ul><li>bc7ce9d7 - Changed checkup query to miliseconds.</li></ul> [Compare with previous version](/saburly/marketalarm/web/-/merge_requests/97/diffs?diff_id=75913922&start_sha=22bffc126d29782451309854dde1e0353a405a63)
RabbIT09-n commented 2020-02-17 21:27:43 +01:00 (Migrated from gitlab.com)
Copy Link

Ova metoda setDate prima i negativne vrijednosti, zato je radilo na nekim mojim primjerima ali moze i grijesiti, tako da sam prebacila logiku u milisekunde mislim da bi to trebalo biti ok.

Ova metoda setDate prima i negativne vrijednosti, zato je radilo na nekim mojim primjerima ali moze i grijesiti, tako da sam prebacila logiku u milisekunde mislim da bi to trebalo biti ok.
edazdarevic commented 2020-02-25 13:57:18 +01:00 (Migrated from gitlab.com)
Copy Link

🚢 🇮🇹

:ship: :it:
RabbIT09-n commented 2020-02-25 16:12:53 +01:00 (Migrated from gitlab.com)
Copy Link

added 14 commits

  • bc7ce9d7...08ad9edf - 13 commits from branch master
  • a508f72d - Merge branch 'master' into 'checkup-email-bug-fix'

Compare with previous version

added 14 commits <ul><li>bc7ce9d7...08ad9edf - 13 commits from branch <code>master</code></li><li>a508f72d - Merge branch &#39;master&#39; into &#39;checkup-email-bug-fix&#39;</li></ul> [Compare with previous version](/saburly/marketalarm/web/-/merge_requests/97/diffs?diff_id=77106579&start_sha=bc7ce9d7085a13a2a71816daec213aeac61b53b5)
RabbIT09-n commented 2020-02-25 16:13:21 +01:00 (Migrated from gitlab.com)
Copy Link

merged

merged
RabbIT09-n commented 2020-02-25 16:13:22 +01:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit b913daa1f7

mentioned in commit b913daa1f7c851066654d74d4cf4a02cc5c8a4cb
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#97
Delete Branch "checkup-email-bug-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?