senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Tag staging email #85

Merged
RabbIT09-n merged 3 commits from tag-staging-email into master 2020-02-04 14:07:54 +01:00
Conversation 7 Commits 3 Files Changed 4 +28 -9
RabbIT09-n commented 2020-01-14 22:24:06 +01:00 (Migrated from gitlab.com)
Copy Link

Added tag [STAGING] to email subject and body (in front of "Zdravo") to denote staging from production.

Added tag [STAGING] to email subject and body (in front of "Zdravo") to denote staging from production.
senaduka commented 2020-01-31 06:09:06 +01:00 (Migrated from gitlab.com)
Copy Link

Ovo nije tacno :D Staging ENV se odnosi na heroku server na kojem je deployano.
Jesi li sigurna da je na produkciji NODE_ENV production, a na stagingu da nije ?

Ovo nije tacno :D Staging ENV se odnosi na heroku server na kojem je deployano. Jesi li sigurna da je na produkciji NODE_ENV production, a na stagingu da nije ?
RabbIT09-n commented 2020-01-31 22:48:13 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/saburly/marketalarm/web/-/merge_requests/85/diffs?diff_id=73569734&start_sha=b9122f8f00be3757f5888d1e2b5e0e3907d84f86#c72f9a98e9ca3b5472a2a7eaf30c6155d3600e77_12_12)
RabbIT09-n commented 2020-01-31 22:48:14 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 712cde16 - Changed not to use NODE_ENV variable.

Compare with previous version

added 1 commit <ul><li>712cde16 - Changed not to use NODE_ENV variable.</li></ul> [Compare with previous version](/saburly/marketalarm/web/-/merge_requests/85/diffs?diff_id=73569734&start_sha=b9122f8f00be3757f5888d1e2b5e0e3907d84f86)
RabbIT09-n commented 2020-01-31 22:49:42 +01:00 (Migrated from gitlab.com)
Copy Link

Procitala clanak: https://glebbahmutov.com/blog/do-not-use-node-env-for-staging/
Zamijenila da postoji dodatna env varijabla za production, development, staging. Javi ako tako moze :)

Procitala clanak: https://glebbahmutov.com/blog/do-not-use-node-env-for-staging/ Zamijenila da postoji dodatna env varijabla za production, development, staging. Javi ako tako moze :)
RabbIT09-n commented 2020-02-04 14:07:46 +01:00 (Migrated from gitlab.com)
Copy Link

added 27 commits

  • 712cde16...824db4fb - 26 commits from branch master
  • b933fa96 - Merge branch 'master' into 'tag-staging-email'

Compare with previous version

added 27 commits <ul><li>712cde16...824db4fb - 26 commits from branch <code>master</code></li><li>b933fa96 - Merge branch &#39;master&#39; into &#39;tag-staging-email&#39;</li></ul> [Compare with previous version](/saburly/marketalarm/web/-/merge_requests/85/diffs?diff_id=73913106&start_sha=712cde16322f472578db455d91316dfbc0944881)
RabbIT09-n commented 2020-02-04 14:07:54 +01:00 (Migrated from gitlab.com)
Copy Link

merged

merged
RabbIT09-n commented 2020-02-04 14:07:54 +01:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 41b59e8c7c

mentioned in commit 41b59e8c7c076a4a42a27c8ecb5a102dbd60134c
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#85
Delete Branch "tag-staging-email"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?