senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Refactor #5

Merged
bilal.catic merged 13 commits from refactor into master 2019-05-17 09:46:45 +02:00
Conversation 14 Commits 13 Files Changed 22 +2787 -485
bilal.catic commented 2019-05-16 23:46:44 +02:00 (Migrated from gitlab.com)
Copy Link

Changes :

  • readme update
  • changed file names from snake_case to camelCase
  • changed column name city to region, and code occurrences of city accordingly
  • changed column name place to municipality
  • changed neighborhood to municipality
  • changed function name for fetching municipalities to better reflect function purpose
  • changed region and municipality object property names to english
  • added nodemon as dev dependecy and script for running app under nodemon [npm run start-mon]
  • added npm script for migration [npm run migrate]
  • added npm script for initial setup (create and run docker image, execute migrations) [npm run setup]
  • added npm script for docker manipulation (start, stop) [npm run docker-start and npm run docker-stop]

Fixes :

  • Choosing municipality is now saved to database (there was discrepancy in place/neighborhood naming - database vs. code)

NOTE : don't forget to execute migrations
NOTE 2 : run npm install

For testing, stop and delete docker container and follow readme for setup using npm commands

Changes : - readme update - changed file names from snake_case to camelCase - changed column name `city` to `region`, and code occurrences of `city` accordingly - changed column name `place` to `municipality` - changed `neighborhood` to `municipality` - changed function name for fetching municipalities to better reflect function purpose - changed region and municipality object property names to english - added nodemon as dev dependecy and script for running app under nodemon [`npm run start-mon`] - added npm script for migration [`npm run migrate`] - added npm script for initial setup (create and run docker image, execute migrations) [`npm run setup`] - added npm script for docker manipulation (start, stop) [`npm run docker-start` and `npm run docker-stop`] Fixes : - Choosing municipality is now saved to database (there was discrepancy in place/neighborhood naming - database vs. code) NOTE : don't forget to execute migrations NOTE 2 : run `npm install` For testing, stop and delete docker container and follow readme for setup using npm commands
bilal.catic commented 2019-05-16 23:53:04 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
bilal.catic commented 2019-05-16 23:53:04 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-05-17 00:01:05 +02:00 (Migrated from gitlab.com)
Copy Link

marked as a Work In Progress

marked as a **Work In Progress**
bilal.catic commented 2019-05-17 00:35:25 +02:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

Compare with previous version

added 2 commits <ul><li>4309bc70 - change column name from &#39;city&#39; to &#39;region&#39;</li><li>dbf40b19 - Merge branch &#39;refactor&#39; of https://gitlab.com/saburly/marketalarm/web into refactor</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/5/diffs?diff_id=42326055&start_sha=4323017d02f8960977f498fcfcbec5e1cb51be70)
bilal.catic commented 2019-05-17 00:38:09 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-05-17 00:50:50 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 42ae5da5 - change region and municipality properties to english

Compare with previous version

added 1 commit <ul><li>42ae5da5 - change region and municipality properties to english</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/5/diffs?diff_id=42326594&start_sha=dbf40b199e8aa7cac37e4b4542641d8d680a22d8)
bilal.catic commented 2019-05-17 00:51:56 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-05-17 00:53:28 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 68172951 - change region and municipality property names to english

Compare with previous version

added 1 commit <ul><li>68172951 - change region and municipality property names to english</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/5/diffs?diff_id=42326688&start_sha=42ae5da54c71dd8e11150a2f3f7511080aa694d0)
bilal.catic commented 2019-05-17 00:55:16 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
bilal.catic commented 2019-05-17 03:46:21 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-05-17 09:15:11 +02:00 (Migrated from gitlab.com)
Copy Link

added 4 commits

Compare with previous version

added 4 commits <ul><li>76f9457d - add nodemon and migrate scripts</li><li>7192c28c - update readme</li><li>93f5d807 - add npm commands for docker and setup</li><li>93faa7c9 - update readme</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/5/diffs?diff_id=42347142&start_sha=68172951ed85d56c63566bfcebf75f238a8557cd)
bilal.catic commented 2019-05-17 09:17:55 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2019-05-17 09:46:45 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
nedimu commented 2019-05-17 09:46:45 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 393f6731e6

mentioned in commit 393f6731e613cd378bbb98dca3477b2ac232157f
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#5
Delete Branch "refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?