senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Refactoring #4

Merged
nedimu merged 1 commits from rename into master 2019-05-16 14:49:53 +02:00
Conversation 17 Commits 1 Files Changed 16 +153 -131
nedimu commented 2019-05-16 12:58:53 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

Just retest the application

Smoke test Just retest the application
nedimu commented 2019-05-16 13:00:21 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>27fa7216 - Renaming to english</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/4/diffs?diff_id=42251675&start_sha=c0c27dcf524c3db0d3614bd2b1f1b62be812401c)
bilal.catic commented 2019-05-16 13:12:36 +02:00 (Migrated from gitlab.com)
Copy Link

npm install command should be executed before migration command

`npm install` command should be executed before migration command
bilal.catic commented 2019-05-16 13:14:31 +02:00 (Migrated from gitlab.com)
Copy Link

maybe we can change pg_test to something like pg_marketalerts or something else instead of test

maybe we can change `pg_test` to something like `pg_marketalerts` or something else instead of test
bilal.catic commented 2019-05-16 13:23:22 +02:00 (Migrated from gitlab.com)
Copy Link

can we change this to camelCase, and rename template file

can we change this to camelCase, and rename template file
bilal.catic commented 2019-05-16 13:24:06 +02:00 (Migrated from gitlab.com)
Copy Link

is it ok to change this file name to use camelCase ?

is it ok to change this file name to use camelCase ?
bilal.catic commented 2019-05-16 13:36:26 +02:00 (Migrated from gitlab.com)
Copy Link

Maybe this file should be renamed to cities

Maybe this file should be renamed to `cities`
bilal.catic commented 2019-05-16 13:41:02 +02:00 (Migrated from gitlab.com)
Copy Link

Can we rename this file to use camelCase

Can we rename this file to use camelCase
bilal.catic commented 2019-05-16 13:46:23 +02:00 (Migrated from gitlab.com)
Copy Link

Will be resolved in following PR

Will be resolved in following PR
bilal.catic commented 2019-05-16 13:46:38 +02:00 (Migrated from gitlab.com)
Copy Link

Will be resolved in following PR

Will be resolved in following PR
bilal.catic commented 2019-05-16 13:46:46 +02:00 (Migrated from gitlab.com)
Copy Link

Will be resolved in following PR

Will be resolved in following PR
bilal.catic commented 2019-05-16 13:46:53 +02:00 (Migrated from gitlab.com)
Copy Link

Will be resolved in following PR

Will be resolved in following PR
bilal.catic commented 2019-05-16 13:47:00 +02:00 (Migrated from gitlab.com)
Copy Link

Will be resolved in following PR

Will be resolved in following PR
bilal.catic commented 2019-05-16 13:47:08 +02:00 (Migrated from gitlab.com)
Copy Link

Will be resolved in following PR

Will be resolved in following PR
bilal.catic commented 2019-05-16 13:47:09 +02:00 (Migrated from gitlab.com)
Copy Link

resolved all discussions

resolved all discussions
bilal.catic commented 2019-05-16 13:47:37 +02:00 (Migrated from gitlab.com)
Copy Link

All comments will be resolved in following PR

All comments will be resolved in following PR
bilal.catic commented 2019-05-16 14:49:53 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
bilal.catic commented 2019-05-16 14:49:54 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit e5eb6b99a2

mentioned in commit e5eb6b99a2f24c745ceefcc706b3c9ba827ed141
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#4
Delete Branch "rename"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?