senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Project fixes #26

Merged
bilal.catic merged 7 commits from project-fixes into master 2019-09-09 12:49:57 +02:00
Conversation 9 Commits 7 Files Changed 50 +2552 -2408
bilal.catic commented 2019-09-05 14:35:09 +02:00 (Migrated from gitlab.com)
Copy Link

Rev.1

  • Applied prettier on all files (with default config)
  • Added ENV variables for DB credentials, so that default sequelize config can be overridden by the local env file
  • Port and base url are now separated
  • APP_URL is now constant created by merging BASE_URL and PORT
  • Introduced env variable to control sequelize logging
  • Changed email template to use new APP_URL constant

Rev.2

  • Removed all logging noise
  • Fixed scheduler execution rule

Rev.3

  • Fixed OLX municipalities and cities IDs -> crawler is working now

Smoke test :

Go through the process and verify that email is sent for registration and notification email when real estate(s) are found

Rev.1 * Applied prettier on all files (with default config) * Added ENV variables for DB credentials, so that default sequelize config can be overridden by the local env file * Port and base url are now separated * APP_URL is now constant created by merging BASE_URL and PORT * Introduced env variable to control sequelize logging * Changed email template to use new APP_URL constant Rev.2 * Removed all logging noise * Fixed scheduler execution rule Rev.3 * Fixed OLX municipalities and cities IDs -> crawler is working now Smoke test : Go through the process and verify that email is sent for registration and notification email when real estate(s) are found
bilal.catic commented 2019-09-06 12:43:58 +02:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

Compare with previous version

added 2 commits <ul><li>b0f9c2c4 - remove all logging noise</li><li>68c69144 - fix scheduler execution rule</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/26/diffs?diff_id=54062111&start_sha=1d29f6c8ac01a4121544567edca339ca8001368b)
bilal.catic commented 2019-09-06 12:48:59 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-09-06 12:50:05 +02:00 (Migrated from gitlab.com)
Copy Link

marked as a Work In Progress

marked as a **Work In Progress**
bilal.catic commented 2019-09-06 12:50:05 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-09-09 12:41:34 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 87b79f39 - fix region and municipality OLX ids

Compare with previous version

added 1 commit <ul><li>87b79f39 - fix region and municipality OLX ids</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/26/diffs?diff_id=54242114&start_sha=68c69144a2a39a98d88a413951b550efd71b6915)
bilal.catic commented 2019-09-09 12:42:04 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
bilal.catic commented 2019-09-09 12:43:26 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-09-09 12:49:58 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
bilal.catic commented 2019-09-09 12:49:58 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit f84fed0a01

mentioned in commit f84fed0a018e803d8e5b1f8b1a7f240d0b97ad12
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#26
Delete Branch "project-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?