senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Real Estate Page #24

Merged
nedimu merged 4 commits from marketalerts-page into master 2019-07-15 11:48:09 +02:00
Conversation 13 Commits 4 Files Changed 7 +159 -82
nedimu commented 2019-07-12 16:17:02 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

  1. Check out notification email

  2. Email at the end must contain link to all of the real estate request results

Smoke test 1) Check out notification email 2) Email at the end must contain link to all of the real estate request results
nedimu commented 2019-07-12 18:00:23 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 81c30c36 - Added realestate link to bulk email

Compare with previous version

added 1 commit <ul><li>81c30c36 - Added realestate link to bulk email</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/24/diffs?diff_id=48058783&start_sha=753a09aa36b67d894124a46498a7f2fef75d4705)
nedimu commented 2019-07-12 18:03:23 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nedimu commented 2019-07-12 18:03:23 +02:00 (Migrated from gitlab.com)
Copy Link

changed title from {-[WIP]Fixed crawler not reading and comparing all RERequest results-} to {+Real Estate Page+}

changed title from **{-[WIP]Fixed crawler not reading and comparing all RERequest results-}** to **{+Real Estate Page+}**
nedimu commented 2019-07-12 18:03:23 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2019-07-12 18:03:23 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @bilal.catic

assigned to @bilal.catic
bilal.catic commented 2019-07-15 09:04:33 +02:00 (Migrated from gitlab.com)
Copy Link

"Kompletan spisan" <- typo ... mozete <- možete

"Kompletan spisan" <- typo ... mozete <- možete
bilal.catic commented 2019-07-15 09:21:55 +02:00 (Migrated from gitlab.com)
Copy Link

While creating request, whole item field is clickable (user can click on the text, not only the button), so maybe it would be nice to make it same here

While creating request, whole item field is clickable (user can click on the text, not only the button), so maybe it would be nice to make it same here
bilal.catic commented 2019-07-15 09:33:06 +02:00 (Migrated from gitlab.com)
Copy Link

Maybe it would be nice to have number of all real estates in total

Maybe it would be nice to have number of all real estates in total
bilal.catic commented 2019-07-15 09:37:25 +02:00 (Migrated from gitlab.com)
Copy Link

There is problem with results : when I have two requests with similar parameters, but two different locations (say Alipašino and Dobrinja), I receive email with real estates from both requests. This should not be the case

There is problem with results : when I have two requests with similar parameters, but two different locations (say Alipašino and Dobrinja), I receive email with real estates from both requests. This should not be the case
nedimu commented 2019-07-15 11:40:34 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 778b5ff4 - Fixed bug, for duplicate results for 2 similar re reqests of one user

Compare with previous version

added 1 commit <ul><li>778b5ff4 - Fixed bug, for duplicate results for 2 similar re reqests of one user</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/24/diffs?diff_id=48171375&start_sha=81c30c36ec5f648ef5c8eb28a05f3e9d375b8944)
nedimu commented 2019-07-15 11:47:49 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1999d45c - Changed template name</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/24/diffs?diff_id=48172951&start_sha=778b5ff411db1a55fa343c3765a2a8a05c2df428)
nedimu commented 2019-07-15 11:48:09 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
nedimu commented 2019-07-15 11:48:09 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 09792db21c

mentioned in commit 09792db21c8cdf49628fdf143af32f49c4f9238f
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#24
Delete Branch "marketalerts-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?