senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Handle nav-bar #23

Merged
nedimu merged 3 commits from nav-bar into master 2019-07-12 15:22:17 +02:00
Conversation 9 Commits 3 Files Changed 28 +107 -90
nedimu commented 2019-07-11 14:26:33 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

  1. Checkout the nav bar in all of the pages (except welcome page)

  2. Font is change to ROVBOTO in entire app

Smoke test 1) Checkout the nav bar in all of the pages (except welcome page) 2) Font is change to ROVBOTO in entire app
nedimu commented 2019-07-11 14:34:08 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>afeffe8c - Added roboto font</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/23/diffs?diff_id=47908127&start_sha=a6bd63b7b849b08595dfacd2a1eeaabb362221ff)
nedimu commented 2019-07-11 16:04:31 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nedimu commented 2019-07-11 16:04:31 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2019-07-11 16:04:31 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @bilal.catic

assigned to @bilal.catic
bilal.catic commented 2019-07-11 18:47:43 +02:00 (Migrated from gitlab.com)
Copy Link

you probably forgot to remove comments for crawlAll and processNotification lines in scheduler rule

you probably forgot to remove comments for crawlAll and processNotification lines in scheduler rule
nedimu commented 2019-07-12 10:53:30 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f9abf48f - Removed unecessary comments</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/23/diffs?diff_id=48001291&start_sha=afeffe8c7193f2242f74c9d4e90c73697cf3571e)
bilal.catic commented 2019-07-12 12:17:01 +02:00 (Migrated from gitlab.com)
Copy Link

resolved all threads

resolved all threads
bilal.catic commented 2019-07-12 15:22:17 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
bilal.catic commented 2019-07-12 15:22:19 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 4517624fa8

mentioned in commit 4517624fa85022075c8bcea92af424ff6312aad2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#23
Delete Branch "nav-bar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?