senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Send notification #18

Merged
nedimu merged 5 commits from send-notification into master 2019-07-02 12:32:12 +02:00
Conversation 6 Commits 5 Files Changed 10 +269 -48
nedimu commented 2019-06-28 18:09:28 +02:00 (Migrated from gitlab.com)
Copy Link

run migrations

crawler service npm command is now called "crawler",
run notificationService with command "notification"

Smoke test

  1. Run crawler and get some search results note: (EMAIL MUST be saburly verified email)

  2. Run notification service

  3. Verify that you have received all the results

  4. Run notification service again, an verify that you where did not received the email with same notifications

run migrations crawler service npm command is now called "crawler", run notificationService with command "notification" Smoke test 1) Run crawler and get some search results note: (EMAIL MUST be saburly verified email) 2) Run notification service 3) Verify that you have received all the results 4) Run notification service again, an verify that you where did not received the email with same notifications
bilal.catic commented 2019-07-01 13:28:36 +02:00 (Migrated from gitlab.com)
Copy Link

Check response, maybe there is info whether there is error or warning or something

Check response, maybe there is info whether there is error or warning or something
nedimu commented 2019-07-02 11:54:47 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/saburly/marketalarm/web/merge_requests/18/diffs?diff_id=46982476&start_sha=96e9da1fb1c811bf884cb669ee1662c804784f78#4e143c5aac1af59d49cd9e4cd6637a7edf175f3b_141_142)
nedimu commented 2019-07-02 11:54:48 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 93c147e7 - Looged amazon send bulk email response, fixed some emails not sent bug

Compare with previous version

added 1 commit <ul><li>93c147e7 - Looged amazon send bulk email response, fixed some emails not sent bug</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/18/diffs?diff_id=46982476&start_sha=96e9da1fb1c811bf884cb669ee1662c804784f78)
nedimu commented 2019-07-02 12:25:27 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8b20f0e1 - Formated title</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/18/diffs?diff_id=46986352&start_sha=93c147e73b5faafe15c64f9030d6d5d3c2f640cd)
bilal.catic commented 2019-07-02 12:32:12 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
bilal.catic commented 2019-07-02 12:32:12 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 7f0b2d299e

mentioned in commit 7f0b2d299e259d25bb9ff2d8c5992e491199eca3
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#18
Delete Branch "send-notification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?