senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Geocoding restricttions, added values for range finders, added confirmation email, and .env file #14

Merged
nedimu merged 3 commits from confirmation-email into master 2019-06-11 10:42:07 +02:00
Conversation 21 Commits 3 Files Changed 15 +328 -125
nedimu commented 2019-06-10 17:35:33 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

Run migrations

  1. Try out values display for sliders on relestate size, and price sliders
  2. Checkout neigborhood map geocoding restirctions, you should not be allowed to go out of the bounds of negborhood
  3. Send a confirmation email, check if all of the values in email is sent (the email address must be verified @sabury.com email address)
Smoke test Run migrations 1) Try out values display for sliders on relestate size, and price sliders 2) Checkout neigborhood map geocoding restirctions, you should not be allowed to go out of the bounds of negborhood 3) Send a confirmation email, check if all of the values in email is sent (the email address must be verified @sabury.com email address)
nedimu commented 2019-06-10 17:36:40 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-06-10 22:39:56 +02:00 (Migrated from gitlab.com)
Copy Link

** This file should not be committed to the source control. You can have another file, like template environment file, containing all variables but with dummy / example values. Instruct user to copy that template file to .env file and change dummy / example values with real values when setting up project.

** This file should not be committed to the source control. You can have another file, like template environment file, containing all variables but with dummy / example values. Instruct user to copy that template file to .env file and change dummy / example values with real values when setting up project.
bilal.catic commented 2019-06-10 23:55:26 +02:00 (Migrated from gitlab.com)
Copy Link

you can move these two lines to the index file in project root directory

you can move these two lines to the index file in project root directory
bilal.catic commented 2019-06-11 00:04:38 +02:00 (Migrated from gitlab.com)
Copy Link

** source email and reply to email addresses should be loaded from ENV variables

** source email and reply to email addresses should be loaded from ENV variables
bilal.catic commented 2019-06-11 00:08:14 +02:00 (Migrated from gitlab.com)
Copy Link

I didn't see before that bounding_box is snake case. We should stick to the camelCase

I didn't see before that `bounding_box` is snake case. We should stick to the camelCase
bilal.catic commented 2019-06-11 00:32:37 +02:00 (Migrated from gitlab.com)
Copy Link

** real estate type value should be fetched from enum

** real estate type value should be fetched from enum
bilal.catic commented 2019-06-11 00:33:44 +02:00 (Migrated from gitlab.com)
Copy Link

** Garden size should be shown only if needed. This information is stored in real estate type enum

** Garden size should be shown only if needed. This information is stored in real estate type enum
bilal.catic commented 2019-06-11 00:34:11 +02:00 (Migrated from gitlab.com)
Copy Link

** Look previous two comments, same should be applied in text version of email

** Look previous two comments, same should be applied in text version of email
nedimu commented 2019-06-11 10:24:32 +02:00 (Migrated from gitlab.com)
Copy Link

fixed

fixed
nedimu commented 2019-06-11 10:24:41 +02:00 (Migrated from gitlab.com)
Copy Link

fixed

fixed
nedimu commented 2019-06-11 10:24:51 +02:00 (Migrated from gitlab.com)
Copy Link

fixed

fixed
nedimu commented 2019-06-11 10:24:58 +02:00 (Migrated from gitlab.com)
Copy Link

fixed

fixed
nedimu commented 2019-06-11 10:25:07 +02:00 (Migrated from gitlab.com)
Copy Link

fixed

fixed
nedimu commented 2019-06-11 10:26:55 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/saburly/marketalarm/web/merge_requests/14/diffs?diff_id=44846092&start_sha=8f9e3ae46a0f0dbaa2c9e8db2d24962220f4051f#4e143c5aac1af59d49cd9e4cd6637a7edf175f3b_41_42)
nedimu commented 2019-06-11 10:26:55 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/saburly/marketalarm/web/merge_requests/14/diffs?diff_id=44846092&start_sha=8f9e3ae46a0f0dbaa2c9e8db2d24962220f4051f#4e143c5aac1af59d49cd9e4cd6637a7edf175f3b_57_60)
nedimu commented 2019-06-11 10:26:55 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/saburly/marketalarm/web/merge_requests/14/diffs?diff_id=44846092&start_sha=8f9e3ae46a0f0dbaa2c9e8db2d24962220f4051f#4e143c5aac1af59d49cd9e4cd6637a7edf175f3b_61_60)
nedimu commented 2019-06-11 10:26:56 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 506ac679 - Fixed garden size email issues

Compare with previous version

added 1 commit <ul><li>506ac679 - Fixed garden size email issues</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/14/diffs?diff_id=44846092&start_sha=8f9e3ae46a0f0dbaa2c9e8db2d24962220f4051f)
nedimu commented 2019-06-11 10:34:53 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/saburly/marketalarm/web/merge_requests/14/diffs?diff_id=44847005&start_sha=506ac67956cf8c7d2e19d7587608984bf1f78507#3c84dcdc6bbe3d7817c49dcdc327b926fea1808a_6_0)
nedimu commented 2019-06-11 10:34:54 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>caa18719 - deleted env file</li></ul> [Compare with previous version](/saburly/marketalarm/web/merge_requests/14/diffs?diff_id=44847005&start_sha=506ac67956cf8c7d2e19d7587608984bf1f78507)
bilal.catic commented 2019-06-11 10:42:07 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
bilal.catic commented 2019-06-11 10:42:07 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 62bf3380cd

mentioned in commit 62bf3380cdb491858182159f0c37d0a63badaabd
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#14
Delete Branch "confirmation-email"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?