senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Double email #13

Merged
nedimu merged 3 commits from double-email into master 2019-05-30 14:08:26 +02:00
Conversation 8 Commits 3 Files Changed 9 +159 -55
nedimu commented 2019-05-29 17:07:48 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

  1. Run migrations and verify that range fields (price, size gardenSize) are integer now, check is everything working

  2. Go to querySubmit page, and test email validation.. There is a server side and client side validation.. both check email validation for both fields, and the server side checks are both emails equal

Smoke test 1) Run migrations and verify that range fields (price, size gardenSize) are integer now, check is everything working 2) Go to querySubmit page, and test email validation.. There is a server side and client side validation.. both check email validation for both fields, and the server side checks are both emails equal
nedimu commented 2019-05-29 17:11:15 +02:00 (Migrated from gitlab.com)
Copy Link

added 3 commits

  • 56865b46 - 1 commit from branch master
  • 7db74aca - Set range fileds to be integer instead of strings
  • a0f2b044 - Added validation to email confirmation

Compare with previous version

added 3 commits <ul><li>56865b46 - 1 commit from branch <code>master</code></li><li>7db74aca - Set range fileds to be integer instead of strings</li><li>a0f2b044 - Added validation to email confirmation</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/13/diffs?diff_id=43529771&start_sha=70ce21b6ff90925777a5869ae19659e2dc9533ff)
bilal.catic commented 2019-05-30 00:04:10 +02:00 (Migrated from gitlab.com)
Copy Link

No need to validate email and confirm email (two times email input is probably typo)

No need to validate email and confirm email (two times email input is probably typo)
bilal.catic commented 2019-05-30 00:09:05 +02:00 (Migrated from gitlab.com)
Copy Link

If you are already removing old columns and replacing them, it would be nice to have two things :

  • change column names to something more meaningful (eg. size -> sizeFrom ; sizeRange -> sizeTo, or sizeMin and sizeMax or similar)
  • group related columns together (eg. sizeMin, sizeMax, priceMin, priceMax, gardenSizeMin, gardenSizeMax)
If you are already removing old columns and replacing them, it would be nice to have two things : - change column names to something more meaningful (eg. size -> sizeFrom ; sizeRange -> sizeTo, or sizeMin and sizeMax or similar) - group related columns together (eg. sizeMin, sizeMax, priceMin, priceMax, gardenSizeMin, gardenSizeMax)
nedimu commented 2019-05-30 10:43:56 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/marketalarm/web/merge_requests/13/diffs?diff_id=43609402&start_sha=a0f2b044b22635a29ca333826e6db182a3ef68a7#567522462fa4e4897fc5e12d296230a427b6c641_22_22)
nedimu commented 2019-05-30 10:43:57 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/marketalarm/web/merge_requests/13/diffs?diff_id=43609402&start_sha=a0f2b044b22635a29ca333826e6db182a3ef68a7#1b5bab2e7dc7bc3c122e800062e75299e4d83b4e_11_0)
nedimu commented 2019-05-30 10:43:57 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 08a94ca4 - Fixed google maps bug, changed size, gardenSize, and price colum names, fixed...

Compare with previous version

added 1 commit <ul><li>08a94ca4 - Fixed google maps bug, changed size, gardenSize, and price colum names, fixed...</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/13/diffs?diff_id=43609402&start_sha=a0f2b044b22635a29ca333826e6db182a3ef68a7)
bilal.catic commented 2019-05-30 14:08:26 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit d6e999fcf1

mentioned in commit d6e999fcf19fab395f46fd4c71904d2a1644e4dd
bilal.catic commented 2019-05-30 14:08:26 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#13
Delete Branch "double-email"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?