senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Real Estate Slider #12

Merged
nedimu merged 2 commits from realestate-size-slider into master 2019-05-29 12:18:18 +02:00
Conversation 6 Commits 2 Files Changed 10 +155 -86
nedimu commented 2019-05-28 16:49:52 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

  1. Run migrations

  2. Go to real estate size, garden size, and price pages and checkout the sliders

  3. Check that values from all sliders are saved

  4. Check query review page and check is everything is displayed properly

Smoke test 1) Run migrations 1) Go to real estate size, garden size, and price pages and checkout the sliders 2) Check that values from all sliders are saved 3) Check query review page and check is everything is displayed properly
bilal.catic commented 2019-05-28 17:23:21 +02:00 (Migrated from gitlab.com)
Copy Link

I think it would be better to separate column "size" into two columns "sizeFrom" and "sizeTo", with numerical type and save separately those two values ?

I think it would be better to separate column "size" into two columns "sizeFrom" and "sizeTo", with numerical type and save separately those two values ?
nedimu commented 2019-05-29 11:03:11 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/marketalarm/web/merge_requests/12/diffs?diff_id=43477652&start_sha=de3c76315e249815813cfbbf19129706f8c0a7c4#f19bbd7603c1b6796042f8a145adb8c9d67b3942_16_30)
nedimu commented 2019-05-29 11:03:12 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 1a8ac3fb - Added range slider to gardensize and price

Compare with previous version

added 1 commit <ul><li>1a8ac3fb - Added range slider to gardensize and price</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/12/diffs?diff_id=43477652&start_sha=de3c76315e249815813cfbbf19129706f8c0a7c4)
nedimu commented 2019-05-29 11:06:23 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2019-05-29 12:18:18 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
bilal.catic commented 2019-05-29 12:18:18 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 56865b4670

mentioned in commit 56865b467070192b85b677942b00bc39954330c9
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#12
Delete Branch "realestate-size-slider"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?