senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Renamed variables to describe purpose. #101

Open
RabbIT09-n wants to merge 1 commits from rename-variables into master
pull from: rename-variables
merge into: senaduka:master
Conversation 4 Commits 1 Files Changed 7 +24 -24
RabbIT09-n commented 2020-02-23 18:50:06 +01:00 (Migrated from gitlab.com)
Copy Link

Renamed ENVIRONMENT variable to KIVI_ENVIRONMENT as on trello card. Also renamed some of the other variables to describe purpose effectively. Ex. STAGING > USE_KIVI_ENVIRONMENT_TAG ...

Renamed ENVIRONMENT variable to KIVI_ENVIRONMENT as on trello card. Also renamed some of the other variables to describe purpose effectively. Ex. STAGING > USE_KIVI_ENVIRONMENT_TAG ...
edazdarevic commented 2020-02-25 13:51:25 +01:00 (Migrated from gitlab.com)
Copy Link

Zasto smo dodali ovo NO na pocetku? Je li to znaci kao number ili?

Zasto smo dodali ovo `NO` na pocetku? Je li to znaci kao `number` ili?
edazdarevic commented 2020-02-25 13:52:07 +01:00 (Migrated from gitlab.com)
Copy Link

Da li treba da ime oznaci da li koristimo non-production environment?

Da li treba da ime oznaci da li koristimo non-production environment?
RabbIT09-n commented 2020-02-25 16:08:29 +01:00 (Migrated from gitlab.com)
Copy Link

Pa da NO je number, mislis da je bolje NUM_CHECKUP_DAYS ili NUMBER_OF_CHECKUP_DAYS ili kako je i bilo?

Pa da NO je number, mislis da je bolje NUM_CHECKUP_DAYS ili NUMBER_OF_CHECKUP_DAYS ili kako je i bilo?
RabbIT09-n commented 2020-02-25 16:09:36 +01:00 (Migrated from gitlab.com)
Copy Link

Ok slazem se, bolje ima je USE_NON_PRODUCTION_ENV_TAG ?

Ok slazem se, bolje ima je USE_NON_PRODUCTION_ENV_TAG ?
This pull request has changes conflicting with the target branch.
  • app/helpers/db/searchRequestMatch.js
  • app/helpers/emailContentGenerator.js
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin rename-variables:rename-variables
git checkout rename-variables
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#101
Delete Branch "rename-variables"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?