senaduka/old-web
1
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Added google maps step #10

Merged
nedimu merged 2 commits from google-maps into master 2019-05-27 10:35:05 +02:00
Conversation 18 Commits 2 Files Changed 13 +327 -178
nedimu commented 2019-05-24 16:25:35 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

  1. Stop and delete previous docker container and run npm run setup script

  2. After migrations are run , the postgis extension should be active

  3. Run the app and after mjesto step you should be redirected to naselje step, and the google map shown ,and zoomed to the chosen municiplaity.

  4. You should not be allowed to zoom out the map out of Bosnia And Herzegovina

  5. After clicking next button, the coordinates of the bounding box should be saved in new bounding_box column, they are saved it seems as a binary. But you can check cooridnates with query select st_astext(bounding_box) from "RealEstateRequests"

Smoke test 1) Stop and delete previous docker container and run npm run setup script 2) After migrations are run , the postgis extension should be active 3) Run the app and after `mjesto` step you should be redirected to `naselje` step, and the google map shown ,and zoomed to the chosen municiplaity. 4) You should not be allowed to zoom out the map out of Bosnia And Herzegovina 5) After clicking next button, the coordinates of the bounding box should be saved in new bounding_box column, they are saved it seems as a binary. But you can check cooridnates with query `select st_astext(bounding_box) from "RealEstateRequests"`
bilal.catic commented 2019-05-24 16:58:36 +02:00 (Migrated from gitlab.com)
Copy Link

Why northWest two times ?

Why northWest two times ?
bilal.catic commented 2019-05-24 17:03:57 +02:00 (Migrated from gitlab.com)
Copy Link

Probably forgotten console.log statement

Probably forgotten console.log statement
bilal.catic commented 2019-05-24 17:10:30 +02:00 (Migrated from gitlab.com)
Copy Link

You don't need this, there is function in helpers/codes.js file, on bottom, getMunicipalityName

You don't need this, there is function in helpers/codes.js file, on bottom, `getMunicipalityName`
bilal.catic commented 2019-05-24 17:10:50 +02:00 (Migrated from gitlab.com)
Copy Link

Same as comment above

Same as comment above
bilal.catic commented 2019-05-24 17:11:46 +02:00 (Migrated from gitlab.com)
Copy Link

Check comment below

Check comment below
bilal.catic commented 2019-05-24 17:13:36 +02:00 (Migrated from gitlab.com)
Copy Link

You can get municipality name (real name, not Id) using function from helpers/codes.js, on bottom, getMunicipalityName

for example getMunicipalityName(request.region, req.body.municipality);

You can get municipality name (real name, not Id) using function from helpers/codes.js, on bottom, `getMunicipalityName` for example `getMunicipalityName(request.region, req.body.municipality);`
nedimu commented 2019-05-27 09:00:02 +02:00 (Migrated from gitlab.com)
Copy Link

Fixed

Fixed
nedimu commented 2019-05-27 09:00:08 +02:00 (Migrated from gitlab.com)
Copy Link

Fixed

Fixed
nedimu commented 2019-05-27 09:00:33 +02:00 (Migrated from gitlab.com)
Copy Link

Polygons must start and end at same point

Polygons must start and end at same point
nedimu commented 2019-05-27 09:00:57 +02:00 (Migrated from gitlab.com)
Copy Link

Fixed

Fixed
nedimu commented 2019-05-27 09:19:06 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/marketalarm/web/merge_requests/10/diffs?diff_id=43226399&start_sha=be416ffc0ce0a0f25a21d55bb5995acfb5636d7c#9f690fc3fa305927cf56429bc75886f9b0653a84_6_6)
nedimu commented 2019-05-27 09:19:06 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/marketalarm/web/merge_requests/10/diffs?diff_id=43226399&start_sha=be416ffc0ce0a0f25a21d55bb5995acfb5636d7c#abc5f215c174ae41211aa73370672f115b59ef10_20_20)
nedimu commented 2019-05-27 09:19:06 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/marketalarm/web/merge_requests/10/diffs?diff_id=43226399&start_sha=be416ffc0ce0a0f25a21d55bb5995acfb5636d7c#abc5f215c174ae41211aa73370672f115b59ef10_27_26)
nedimu commented 2019-05-27 09:19:07 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/marketalarm/web/merge_requests/10/diffs?diff_id=43226399&start_sha=be416ffc0ce0a0f25a21d55bb5995acfb5636d7c#abc5f215c174ae41211aa73370672f115b59ef10_11_11)
nedimu commented 2019-05-27 09:19:07 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/marketalarm/web/merge_requests/10/diffs?diff_id=43226399&start_sha=be416ffc0ce0a0f25a21d55bb5995acfb5636d7c#425888ceea73d641b1d795da07a78afd6da2742f_15_14)
nedimu commented 2019-05-27 09:19:07 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 6fbacb32 - Fixed bounding box bug, and removed unecesary params

Compare with previous version

added 1 commit <ul><li>6fbacb32 - Fixed bounding box bug, and removed unecesary params</li></ul> [Compare with previous version](https://gitlab.com/saburly/marketalarm/web/merge_requests/10/diffs?diff_id=43226399&start_sha=be416ffc0ce0a0f25a21d55bb5995acfb5636d7c)
bilal.catic commented 2019-05-27 10:35:05 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
bilal.catic commented 2019-05-27 10:35:05 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 5bf95e0594

mentioned in commit 5bf95e0594add86d3515ddd42045fefbb120452f
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-web#10
Delete Branch "google-maps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?