Results title text made into link.

app/crawler/savers/postgres.js

@@ -1,7 +1,6 @@
 const moment = require("moment");
 
 const { bulkUpsertRealEstates } = require("../../helpers/db/realEstate");
-const { bulkUpsertPriceHistory } = require("../../helpers/db/priceHistory");
 
 class PostgresSaver {
   connect() {
@@ -12,21 +11,6 @@ class PostgresSaver {
 
   async save(results) {
     const savedRecords = await bulkUpsertRealEstates(results);
-    //Extruding data for price history table
-    const resultPrices = savedRecords.map(realEstate => {
-      //Null values canot be recognized by ignore duplicates in sequalize
-      //Value price = 0 indicates 'cijena na upit'
-      const priceTmp =
-        realEstate.dataValues.price === null ? 0 : realEstate.dataValues.price;
-
-      return {
-        realEstateId: realEstate.dataValues.id,
-        price: priceTmp,
-        createdAt: realEstate.dataValues.createdAt,
-        updatedAt: realEstate.dataValues.updatedAt
-      };
-    });
-    const savedPrices = await bulkUpsertPriceHistory(resultPrices);
 
     if (Array.isArray(savedRecords)) {
       const newRealEstates = [];

app/helpers/db/priceHistory.js

@@ -1,20 +0,0 @@
-"use strict";
-const db = require("../../models/index");
-const sequelize = require("sequelize");
-
-const bulkUpsertPriceHistory = async priceHistoryData => {
-  try {
-    const order = [["realEstateId", "desc"]];
-
-    return await db.PriceHistory.bulkCreate(priceHistoryData, {
-      order,
-      ignoreDuplicates: true
-    });
-  } catch (e) {
-    console.log("Error bulk upserting priceHistory : ", e);
-  }
-};
-
-module.exports = {
-  bulkUpsertPriceHistory
-};

app/helpers/emailContentGenerator.js

@@ -23,16 +23,19 @@ const generateRealEstateLinks = realEstates => {
 const generateNotificationEmail = (
   realEstates,
   searchRequestId,
+  noAllRealEstates,
   dailyNotification = false
 ) => {
   const truncateList = realEstates.length > MAX_REAL_ESTATES_IN_EMAIL;
+
   const realEstatesToShow = truncateList
     ? realEstates.slice(0, MAX_REAL_ESTATES_IN_EMAIL)
     : realEstates;
 
   const allRealEstatesLink = `${APP_URL}/nekretnine/${searchRequestId}`;
+
   const realEstateLinks = generateRealEstateLinks(realEstatesToShow);
-  const moreRealEstates = `<div>Kompletan spisak nekretnina možete pogledati na <a href="${allRealEstatesLink}">listi nekretnina</a><div>`;
+  const moreRealEstates = `<div>Kompletan spisak nekretnina (${noAllRealEstates}) možete pogledati na <a href="${allRealEstatesLink}">listi nekretnina</a><div>`;
   const emailFooter = generateEmailFooter(searchRequestId);
   const asapMessageBody =
     realEstates.length > 1
@@ -70,6 +73,7 @@ const generateNewSearchRequestEmail = (searchRequest, matchingRealEstates) => {
   } = searchRequest;
 
   const realEstateLinks = generateRealEstateLinks(matchingRealEstates);
+
   const instantRealEstatesText = `<br/>
        <div>
         U međuvremenu pogledajte neke od nedavno objavljenih nekretnina koje odgovaraju Vašim uslovima pretrage :<br/>

app/migrations/20200121000524-add-priceHistory-table.js

@@ -1,42 +0,0 @@
-"use strict";
-
-module.exports = {
-  up: (queryInterface, Sequelize) => {
-    const tableFields = {
-      id: {
-        type: Sequelize.BIGINT,
-        autoIncrement: true,
-        allowNull: false,
-        primaryKey: true
-      },
-      realEstateId: {
-        type: Sequelize.BIGINT,
-        allowNull: false,
-        unique: "uniquePriceRealEstate",
-        references: {
-          model: "RealEstates",
-          key: "id"
-        },
-        onUpdate: "CASCADE",
-        onDelete: "SET NULL"
-      },
-      price: {
-        type: Sequelize.REAL,
-        unique: "uniquePriceRealEstate"
-      },
-      createdAt: {
-        type: Sequelize.DATE,
-        defaultValue: Sequelize.literal("NOW()")
-      },
-      updatedAt: {
-        type: Sequelize.DATE,
-        defaultValue: Sequelize.literal("NOW()")
-      }
-    };
-    return queryInterface.createTable("PriceHistory", tableFields);
-  },
-
-  down: queryInterface => {
-    return queryInterface.dropTable("PriceHistory", {});
-  }
-};

app/migrations/20200121094500-add-constraint-priceHistory.js

@@ -1,10 +0,0 @@
-"use strict";
-module.exports = {
-  up: (queryInterface, Sequelize) =>
-    queryInterface.addConstraint("PriceHistory", ["realEstateId", "price"], {
-      type: "unique",
-      name: "uniquePriceRealEstate"
-    }),
-  down: queryInterface =>
-    queryInterface.removeConstraint("PriceHistory", "uniquePriceRealEstate")
-};

app/models/priceHistory.js

@@ -1,44 +0,0 @@
-"use strict";
-
-module.exports = (sequalize, DataTypes) => {
-  const PriceHistory = sequalize.define(
-    "PriceHistory",
-    {
-      id: {
-        type: DataTypes.BIGINT,
-        autoIncrement: true,
-        primaryKey: true,
-        allowNull: false
-      },
-      realEstateId: {
-        type: DataTypes.BIGINT,
-        allowNull: false,
-        unique: "uniquePriceRealEstate",
-        references: {
-          model: "RealEstates",
-          key: "id"
-        },
-        onUpdate: "CASCADE",
-        onDelete: "SET NULL"
-      },
-      price: {
-        type: DataTypes.REAL,
-        unique: "uniquePriceRealEstate"
-      }
-    },
-    {
-      freezeTableName: true
-    }
-  );
-
-  PriceHistory.associate = models => {
-    PriceHistory.hasMany(models.RealEstate, {
-      foreignKey: "id",
-      sourceKey: "realEstateId",
-      targetKey: "id",
-      as: "realEstates"
-    });
-  };
-
-  return PriceHistory;
-};

app/public/main.css

@@ -154,3 +154,7 @@ h3 {
   margin-top: 2rem;
   margin-bottom: 1rem;
 }
+
+.estates-link {
+  color: rgba(0, 0, 0, 0.87);
+}

app/seeders/20200121150443-initial-price-history.js

@@ -1,34 +0,0 @@
-"use strict";
-
-const { RealEstate } = require("../models");
-
-module.exports = {
-  async up(queryInterface, Sequelize) {
-    //Reading initial data from RealEstate table in db
-    const realEstateInitialData = await RealEstate.findAll();
-    //Extruding data for table PriceHistory
-    const priceHistoryInitialData = realEstateInitialData.map(realEstate => {
-      //Null values canot be recognized by ignore duplicates in sequalize
-      //Value price = 0 indicates 'cijena na upit'
-      const priceTmp =
-        realEstate.dataValues.price === null ? 0 : realEstate.dataValues.price;
-
-      return {
-        realEstateId: realEstate.dataValues.id,
-        price: priceTmp,
-        createdAt: realEstate.dataValues.createdAt,
-        updatedAt: realEstate.dataValues.updatedAt
-      };
-    });
-
-    return queryInterface.bulkInsert(
-      "PriceHistory",
-      priceHistoryInitialData,
-      {}
-    );
-  },
-
-  async down(queryInterface, Sequelize) {
-    return queryInterface.bulkDelete("PriceHistory", null, {});
-  }
-};

app/services/notificationService.js

@@ -8,7 +8,10 @@ const {
   generateNewSearchRequestEmail,
   generateEmailSubject
 } = require("../helpers/emailContentGenerator");
-const { findNotNotifiedMatches } = require("../helpers/db/searchRequestMatch");
+const {
+  findNotNotifiedMatches,
+  findRealEstatesForSearchRequest
+} = require("../helpers/db/searchRequestMatch");
 const { sendEmail } = require("../services/emailService");
 
 const notifyForNewRealEstates = async newRealEstates => {
@@ -39,10 +42,18 @@ const notifyMatches = async (matches, dailyNotification = false) => {
     const { email, subscribed } = searchRequest;
     if (notifyNow && subscribed) {
       const allMatchingRealEstates = matches[id].realEstates || [];
+
+      //Variable allMatchingRealEstates are real estates that are "new" on the market
+      //the ones that we notify user in this moment, not all that already exists in db
+      //New variable allRealEstates are all real estates that exists in db for search req
+      const allRealEstates = await findRealEstatesForSearchRequest(id);
+      const noAllRealEstates = allRealEstates.length;
+
       if (allMatchingRealEstates.length > 0) {
         const emailContent = generateNotificationEmail(
           allMatchingRealEstates,
           id,
+          noAllRealEstates,
           dailyNotification
         );
         const emailSubject = generateEmailSubject(

app/views/realEstates.ejs

@@ -1,13 +1,16 @@
 <div class="row center-align">
-    <ul class="collection with-header">
-      <% for(const realEstate of realEstates) { %>
-      <li class="collection-item">
-        <div><%= realEstate.title %>
-          <a href="<%= realEstate.url %>" class="kivi-color secondary-content">
+  <ul class="collection with-header">
+    <% for(const realEstate of realEstates) { %>
+    <li class="collection-item">
+      <div>
+        <a href="<%= realEstate.url %>" class="estates-link">
+          <%= realEstate.title %>
+          <div class="kivi-color secondary-content">
             <i class="material-icons">send</i>
-          </a>
-        </div>
-      </li>
-      <% } %>
-    </ul>
-  </div>
+          </div>
+        </a>
+      </div>
+    </li>
+    <% } %>
+  </ul>
+</div>

package.json

@@ -8,7 +8,6 @@
     "start": "node ./index.js",
     "start-mon": "nodemon ./index.js",
     "migrate": "cd app && npx sequelize db:migrate",
-    "seed": "cd app && npx sequelize db:seed:all",
     "setup": "docker build -t marketalerts .  && docker run -e POSTGRES_USER=docker -e POSTGRES_PASSWORD=docker -e POSTGRES_DB=marketalerts --name pg_marketalerts -d -p 5432:5432 marketalerts && sleep 10 && npm run migrate",
     "docker-start": "docker start pg_marketalerts",
     "docker-stop": "docker stop pg_marketalerts",