senaduka/old-roraccounting
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change MoneyMove model #2

Merged
bilal.catic merged 2 commits from implement-new-logic-for-ledger-update into master 2020-05-20 16:49:30 +02:00
Conversation 8 Commits 2 Files Changed 2 +56 -26
bilal.catic commented 2020-05-20 13:39:26 +02:00 (Migrated from gitlab.com)
Copy Link
  • Handle MoneyMove request
  • Create one or two MoneyMove records based on params
* Handle MoneyMove request * Create one or two MoneyMove records based on params
bilal.catic commented 2020-05-20 13:46:24 +02:00 (Migrated from gitlab.com)
Copy Link

Ako save! ne uspije, desit će se exception, pa pošto ranije nije hendlan, nisam ništa dodao oko toga (mada mislim da bi trebalo dodati rescue pa vratiti false eventualno)

Iz istog razloga nisam dodao rescue iznad, kod kreiranja move_from i move_to unutar kojih se može desiti exception (kad se traži Homie)

Ako save! ne uspije, desit će se exception, pa pošto ranije nije hendlan, nisam ništa dodao oko toga (mada mislim da bi trebalo dodati rescue pa vratiti false eventualno) Iz istog razloga nisam dodao rescue iznad, kod kreiranja `move_from` i `move_to` unutar kojih se može desiti exception (kad se traži Homie)
bilal.catic commented 2020-05-20 13:47:42 +02:00 (Migrated from gitlab.com)
Copy Link

Kod prethodnog načina je bila greška gdje je trebalo još dodati parametar broj decimala, pa sam čitajući o BigIntu vidio da u railsu može ići .to_d. Ima li neke negativne posljedice ili može ovako ?

Kod prethodnog načina je bila greška gdje je trebalo još dodati parametar broj decimala, pa sam čitajući o BigIntu vidio da u railsu može ići `.to_d`. Ima li neke negativne posljedice ili može ovako ?
senaduka commented 2020-05-20 15:26:59 +02:00 (Migrated from gitlab.com)
Copy Link

Remove To: and From: as these strings need to be translated so just [#{to_homie_name}] is ok.

Remove To: and From: as these strings need to be translated so just [#{to_homie_name}] is ok.
senaduka commented 2020-05-20 15:34:31 +02:00 (Migrated from gitlab.com)
Copy Link

save as integer ( number of cents )

save as integer ( number of cents )
bilal.catic commented 2020-05-20 16:05:38 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/saburly/gangsta/roraccounting/-/merge_requests/2/diffs?diff_id=91522381&start_sha=42bffaa52b84f2765d3a0c9e5f836369c442ac1a#627a812dbaf7b1dd4f5b07e649139d615ba51258_45_37)
bilal.catic commented 2020-05-20 16:05:39 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3cc8cb7d - change description format</li></ul> [Compare with previous version](/saburly/gangsta/roraccounting/-/merge_requests/2/diffs?diff_id=91522381&start_sha=42bffaa52b84f2765d3a0c9e5f836369c442ac1a)
senaduka commented 2020-05-20 16:49:30 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 0045c19b0e

mentioned in commit 0045c19b0e7a5695fe91f0222940b7880dda9906
senaduka commented 2020-05-20 16:49:30 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-roraccounting#2
Delete Branch "implement-new-logic-for-ledger-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?