generate member practice summary report without booking change checks

Stop adding non existing bookings

See merge request saburly/psihologija!83

client/src/components/DateRangePicker/index.js

@@ -0,0 +1,142 @@
+import React, { Component } from 'react';
+import moment from 'moment';
+
+import { Form, Message, Grid } from 'semantic-ui-react';
+
+import { defaultDateFormat } from '../../constants/constants';
+
+class DateRangePicker extends Component {
+    constructor(props) {
+        super(props);
+
+        const initialStartDate = props.startDate ? moment(props.startDate, defaultDateFormat) : moment().startOf('month');
+        let initialEndDate = props.endDate ? moment(props.endDate, defaultDateFormat) : moment();
+
+        if (initialStartDate > initialEndDate){
+            initialEndDate = initialStartDate.add(1, 'day');
+        }
+
+        this.state = {
+            startDate: initialStartDate,
+            endDate: initialEndDate,
+            error: null,
+            startDateLabel: props.startDateLabel || 'Start date',
+            endDateLabel: props.endDateLabel || 'End date',
+        };
+    }
+
+    onStartDateChange(event) {
+        const { endDate, startDateLabel, endDateLabel } = this.state;
+
+        const newStartDate = moment(event.target.value, defaultDateFormat);
+        if (newStartDate > endDate){
+            this.setState({
+                error: `${startDateLabel} cannot be after ${endDateLabel}`
+            });
+            return;
+        }
+        this.setState({startDate: newStartDate, error: null});
+    }
+
+    onEndDateChange(event) {
+        const { startDate, startDateLabel, endDateLabel } = this.state;
+
+        const newEndDate = moment(event.target.value, defaultDateFormat);
+        if (newEndDate < startDate){
+            this.setState({
+                error: `${startDateLabel} cannot be after ${endDateLabel}`
+            });
+            return;
+        }
+        this.setState({endDate: newEndDate, error: null});
+    }
+
+    onDismiss() {
+        this.setState({error: null});
+    }
+
+    onButtonClick() {
+        const { onDatesUpdate } = this.props;
+        const { startDate, endDate } = this.state;
+
+        if (onDatesUpdate){
+            onDatesUpdate({
+                startDate: startDate.format(defaultDateFormat),
+                endDate: endDate.format(defaultDateFormat),
+            });
+        }
+    }
+
+    componentDidMount() {
+        this.onButtonClick();
+    }
+
+    render() {
+        const { startDate, endDate, error, startDateLabel, endDateLabel } = this.state;
+        const { inlineButton } = this.props;
+
+        const buttonLabel = this.props.buttonLabel || 'Save';
+
+        const startDateValue = startDate.format(defaultDateFormat);
+        const endDateValue = endDate.format(defaultDateFormat);
+
+        const buttonRender = (
+            <Grid.Column width={inlineButton ? 3 : null}>
+                { inlineButton && <label>{'\u00A0'}</label> }
+                <Form.Button onClick={this.onButtonClick.bind(this)}>{buttonLabel}</Form.Button>
+            </Grid.Column>
+        );
+
+        return (
+            <Form>
+                <Grid stackable columns={inlineButton ? null : 'equal'}>
+                    <Grid.Row>
+                        <Grid.Column width={inlineButton ? 7 : null}>
+                            <label>{startDateLabel}</label>
+                            <Form.Input
+                                fluid
+                                required
+                                type="date"
+                                value={startDateValue}
+                                onChange={this.onStartDateChange.bind(this)}
+                            />
+                        </Grid.Column>
+                        <Grid.Column width={inlineButton ? 6 : null}>
+                            <label>{endDateLabel}</label>
+                            <Form.Input
+                                fluid
+                                required
+                                type="date"
+                                value={endDateValue}
+                                onChange={this.onEndDateChange.bind(this)}
+                            />
+                        </Grid.Column>
+                        {
+                            inlineButton && buttonRender
+                        }
+                    </Grid.Row>
+                    { error &&
+                        <Grid.Row>
+                            <Grid.Column>
+                                <Message color="orange" onDismiss={this.onDismiss.bind(this)}>
+                                    <Message.Header>Wrong date</Message.Header>
+                                    <p><b>{startDateLabel}</b> has to be before <b>{endDateLabel}</b></p>
+                                </Message>
+                            </Grid.Column>
+                        </Grid.Row>
+                    }
+                    {
+                        !inlineButton &&
+                        <Grid.Row>
+                            {buttonRender}
+                        </Grid.Row>
+                    }
+                </Grid>
+            </Form>
+        );
+    }
+}
+
+export default DateRangePicker;
+
+

client/src/components/MemberIncidentsTables/components/SingleIncidentsTable.js

@@ -1,167 +1,384 @@
-import React from 'react';
+import React, { Component } from 'react';
-import { Loader } from 'semantic-ui-react';
+import { connect } from 'react-redux';
-import ReactTable from 'react-table';
+import { Loader, Button } from 'semantic-ui-react';
 import 'react-table/react-table.css';
 import { NavLink } from 'react-router-dom';
 
+import SelectTable from "../../SelectTable";
+
 import {incidentsReportHeaderTitles} from '../../../constants/constants';
 import {
     incidentTableTypes,
     incidentDescriptions,
     incidentLevelDescriptions,
     UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION, UNLOCKED_INCIDENT_STANDALONE, UNSCHEDULED_INCIDENT_AFTER_RESERVATION,
-    UNSCHEDULED_INCIDENT_BEFORE_RESERVATION, UNSCHEDULED_INCIDENT_STANDALONE
+    UNSCHEDULED_INCIDENT_BEFORE_RESERVATION, UNSCHEDULED_INCIDENT_STANDALONE, BOOKING_CANCELED_LATE, BOOKING_MOVED_TO_ANOTHER_DAY,
+    BOOKING_SHORTENED
 } from '../../../constants/enums';
 import { doorLockRelatedWithReservationIncidentHeaders, standaloneDoorLockIncidentHeaders, bookingChangeIncidentHeaders } from '../../../constants/constants';
+import { deleteIncidents, updateIncidentFees } from "../../../store/actions";
 
+class SingleIncidentsTable extends Component {
+    state = {
+        selectedUnlockedIncidentIds: [],
+        selectedUnscheduledIncidentIds: [],
+        selectedBookingChangeIncidentIds: [],
+        changedUnlockedIncidentIds: {},
+        changedUnscheduledIncidentIds: {},
+        changedBookingChangeIncidentIds: {},
+        inputIdToFocus: null,
+    };
 
-const SingleIncidentsTable = props => {
+    onSelectChange = (selectedIncidents) => {
-    const {
+        const newSelectedUnlockedIncidentIds = [];
-        loading,
+        const newSelectedUnscheduledIncidentIds = [];
-        title,
+        const newSelectedBookingChangeIncidentIds = [];
-        openMemberSummaryOnMemberClick,
-        hideMemberName,
-        tableType
-    } = props;
-    const incidents = props.incidents ? props.incidents : [];
-    const columns = [];
 
-    if (incidents && incidents.length > 0){
+        selectedIncidents.forEach(incident => {
-        let tableHeaders;
+            const incidentDetails = incident.split('-');
-        switch (tableType) {
+            // incident is described as : select-incidentType-incidentId
-            case incidentTableTypes.INCIDENTS_RELATED_TO_RESERVATIONS:
+            if (Array.isArray(incidentDetails) && incidentDetails.length > 2){
-                tableHeaders = doorLockRelatedWithReservationIncidentHeaders;
+                const incidentType = parseInt(incidentDetails[1]);
-                break;
+                const incidentId = parseInt(incidentDetails[2]);
-            case incidentTableTypes.STANDALONE_INCIDENTS:
-                tableHeaders = standaloneDoorLockIncidentHeaders;
-                break;
-            case incidentTableTypes.BOOKING_CHANGE_INCIDENTS:
-                tableHeaders = bookingChangeIncidentHeaders;
-                break;
-            default:
-                break;
-        }
 
-        tableHeaders.forEach((header) => {
+                switch (incidentType) {
-            const columnTitle = incidentsReportHeaderTitles[header];
+                    case 2:
-
+                    case 5:
-            let showColumn = true;
+                        newSelectedUnlockedIncidentIds.push(incidentId);
-            if (header === 'memberName' && hideMemberName){
+                        break;
-                showColumn = false;
+                    case 3:
-            }
+                    case 4:
-
+                    case 6:
-            if (columnTitle && showColumn){
+                        newSelectedUnscheduledIncidentIds.push(incidentId);
-                const columnAlignments = {
+                        break;
-                    left: 'left',
+                    case 7:
-                    right: 'right',
+                    case 8:
-                };
+                    case 9:
-                let columnContentsAlignment = columnAlignments.left;
+                        newSelectedBookingChangeIncidentIds.push(incidentId);
-
+                        break;
-                columns.push({
+                    default:
-                    Header: incidentsReportHeaderTitles[header],
+                        break;
-                    accessor: header,
+                }
-                    Cell: props => {
-                        let cellValue = '';
-                        let urlValue = undefined;
-
-                        switch (props.column.id) {
-                            case 'memberName':
-                                const memberId = props.row['_original'].memberId;
-                                urlValue = `/specific-member-incidents-report/${memberId}`;
-                                cellValue = props.value;
-                                break;
-                            case 'resourceName':
-                                if (props.row['_original'].resourceName){
-                                    cellValue = props.row['_original'].resourceName || '---';
-                                }else{
-                                    const oldResourceName = props.row['_original'].oldResourceName || '---';
-                                    const newResourceName = props.row['_original'].newResourceName || '---';
-                                    if (oldResourceName !== newResourceName){
-                                        cellValue = `${oldResourceName}\n${newResourceName}`;
-                                    }else{
-                                        cellValue = oldResourceName;
-                                    }
-                                }
-                                break;
-                            case 'reservation':
-                                const bookingStart = props.row['_original'].bookingStart;
-                                const bookingEnd = props.row['_original'].bookingEnd;
-                                cellValue = `${bookingStart}\n${bookingEnd}`;
-                                break;
-                            case 'doorLockTimestamps':
-                                const unlockTimestamp = props.row['_original'].unlockTimestamp;
-                                const lockTimestamp = props.row['_original'].lockTimestamp;
-                                cellValue = `${unlockTimestamp ? unlockTimestamp : '---'}\n${lockTimestamp ? lockTimestamp : '---'}`;
-                                break;
-                            case 'incidentType':
-                                cellValue = incidentDescriptions[props.value];
-                                break;
-                            case 'incidentLevel':
-                                cellValue = incidentLevelDescriptions[props.value];
-                                break;
-                            case 'feeDescription':
-                                const { incidentType, incidentLevel, timeIntervalsToCharge } = props.row['_original'];
-
-                                switch (incidentType) {
-                                    case UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION:
-                                    case UNLOCKED_INCIDENT_STANDALONE:
-                                        cellValue = `${incidentLevelDescriptions[incidentLevel]}`;
-                                        break;
-                                    case UNSCHEDULED_INCIDENT_BEFORE_RESERVATION:
-                                    case UNSCHEDULED_INCIDENT_AFTER_RESERVATION:
-                                    case UNSCHEDULED_INCIDENT_STANDALONE:
-                                        cellValue = `${timeIntervalsToCharge} x 5 min`;
-                                        break;
-                                    default:
-                                        cellValue = '';
-                                        break;
-                                }
-                                break;
-                            case 'totalChargeFee':
-                                const totalFee = (props.row['_original'].incidentPrice || props.value) || 0;
-                                const totalFeeFormatted = parseFloat(totalFee).toFixed(2);
-                                cellValue = `$ ${totalFeeFormatted}`;
-                                columnContentsAlignment = columnAlignments.right;
-                                break;
-                            case 'oldReservation':
-                                const oldBookingStart = props.row['_original'].oldBookingStart;
-                                const oldBookingEnd = props.row['_original'].oldBookingEnd;
-                                cellValue = `${oldBookingStart}\n${oldBookingEnd}`;
-                                break;
-                            case 'newReservation':
-                                const newBookingStart = props.row['_original'].newBookingStart || '---';
-                                const newBookingEnd = props.row['_original'].newBookingEnd || '---';
-                                cellValue = `${newBookingStart}\n${newBookingEnd}`;
-                                break;
-                            default:
-                                cellValue = props.value;
-                        }
-
-                        if (openMemberSummaryOnMemberClick && urlValue){
-                            return <NavLink to={urlValue}>{cellValue}</NavLink>
-                        }else{
-                            return <div style={{ textAlign: columnContentsAlignment, whiteSpace: 'pre' }}>{cellValue}</div>
-                        }
-                    }
-                });
             }
         });
-    }
 
-    return (
+        this.setState({
-        <div>
+            selectedUnlockedIncidentIds: newSelectedUnlockedIncidentIds,
-            <h4>{title}</h4>
+            selectedUnscheduledIncidentIds: newSelectedUnscheduledIncidentIds,
-            <Loader active={loading} />
+            selectedBookingChangeIncidentIds: newSelectedBookingChangeIncidentIds
-            {
+        });
-                !loading && incidents &&
+    };
-                <ReactTable
+
-                    data={incidents}
+    deleteSelectedFees = () => {
-                    multiSort={false}
+        const { dateRange, deleteIncidentsById, memberId } = this.props;
-                    columns={columns}
+        const { selectedUnlockedIncidentIds, selectedUnscheduledIncidentIds, selectedBookingChangeIncidentIds } = this.state;
-                />
+
+        const incidentsToDelete = {
+            unlockedIncidentIds: selectedUnlockedIncidentIds,
+            unscheduledIncidentIds: selectedUnscheduledIncidentIds,
+            bookingChangeIncidentIds: selectedBookingChangeIncidentIds
+        };
+
+        deleteIncidentsById(dateRange, incidentsToDelete, memberId);
+        this.setState({
+            selectedUnlockedIncidentIds: [],
+            selectedUnscheduledIncidentIds: [],
+            selectedBookingChangeIncidentIds: []
+        });
+    };
+
+    updateChangedFees = () => {
+        const { dateRange, updateIncidentsById, memberId } = this.props;
+        const { changedUnlockedIncidentIds, changedUnscheduledIncidentIds, changedBookingChangeIncidentIds } = this.state;
+
+        const incidentFeesToUpdate = {
+            unlockedIncidentFees: changedUnlockedIncidentIds,
+            unscheduledIncidentFees: changedUnscheduledIncidentIds,
+            bookingChangeIncidentFees: changedBookingChangeIncidentIds
+        };
+
+        updateIncidentsById(dateRange, incidentFeesToUpdate, memberId);
+        this.setState({
+            changedUnlockedIncidentIds: {},
+            changedUnscheduledIncidentIds: {},
+            changedBookingChangeIncidentIds: {}
+        });
+    };
+
+    render(){
+        const {
+            loading,
+            title,
+            openMemberSummaryOnMemberClick,
+            hideMemberName,
+            tableType
+        } = this.props;
+
+        const {
+            selectedUnlockedIncidentIds,
+            selectedUnscheduledIncidentIds,
+            selectedBookingChangeIncidentIds,
+            changedUnlockedIncidentIds,
+            changedUnscheduledIncidentIds,
+            changedBookingChangeIncidentIds,
+            inputIdToFocus
+        } = this.state;
+
+        const totalSelected = selectedUnlockedIncidentIds.length + selectedUnscheduledIncidentIds.length + selectedBookingChangeIncidentIds.length;
+        const numberOfSelectedText = totalSelected > 0 ? ` (${totalSelected})` : '';
+
+        const totalChanged =
+            Object.keys(changedUnlockedIncidentIds).length +
+            Object.keys(changedUnscheduledIncidentIds).length +
+            Object.keys(changedBookingChangeIncidentIds).length;
+        const numberOfChangedText = totalChanged > 0 ? ` (${totalChanged})` : '';
+
+        const incidents = this.props.incidents ? this.props.incidents : [];
+        incidents.forEach(incident => {
+            incident.id = `${incident.incidentType}-${incident.incidentId}`;
+        });
+        const columns = [];
+
+        if (incidents && incidents.length > 0){
+            let tableHeaders;
+            switch (tableType) {
+                case incidentTableTypes.INCIDENTS_RELATED_TO_RESERVATIONS:
+                    tableHeaders = doorLockRelatedWithReservationIncidentHeaders;
+                    break;
+                case incidentTableTypes.STANDALONE_INCIDENTS:
+                    tableHeaders = standaloneDoorLockIncidentHeaders;
+                    break;
+                case incidentTableTypes.BOOKING_CHANGE_INCIDENTS:
+                    tableHeaders = bookingChangeIncidentHeaders;
+                    break;
+                default:
+                    break;
             }
-        </div>
-    );
-};
 
-export default SingleIncidentsTable;
+            const priceChangeHandler = (element) => {
+                if (element && element.target){
+                    const {value: newValue, id: incidentDescriptionID} = element.target;
+                    const newValueFloat = parseFloat(newValue);
+                    const incidentData = incidentDescriptionID.split('-');
+                    const incidentType = parseInt(incidentData[0]) || null;
+                    const incidentID = parseInt(incidentData[1]) || null;
+
+                    if ((newValueFloat || (newValueFloat === 0) || (isNaN(newValueFloat))) && incidentType && incidentID){
+                        const changedUnlockedIncidentIdsCopy = Object.assign({}, changedUnlockedIncidentIds);
+                        const changedUnscheduledIncidentIdsCopy = Object.assign({}, changedUnscheduledIncidentIds);
+                        const changedBookingChangeIncidentIdsCopy = Object.assign({}, changedBookingChangeIncidentIds);
+
+                        switch (incidentType) {
+                            case UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION:
+                            case UNLOCKED_INCIDENT_STANDALONE:
+                                changedUnlockedIncidentIdsCopy[incidentID] = newValueFloat;
+                                this.setState({changedUnlockedIncidentIds: changedUnlockedIncidentIdsCopy, inputIdToFocus: incidentDescriptionID});
+                                break;
+
+                            case UNSCHEDULED_INCIDENT_BEFORE_RESERVATION:
+                            case UNSCHEDULED_INCIDENT_AFTER_RESERVATION:
+                            case UNSCHEDULED_INCIDENT_STANDALONE:
+                                changedUnscheduledIncidentIdsCopy[incidentID] = newValueFloat;
+                                this.setState({changedUnscheduledIncidentIds: changedUnscheduledIncidentIdsCopy, inputIdToFocus: incidentDescriptionID});
+                                break;
+
+                            case BOOKING_MOVED_TO_ANOTHER_DAY:
+                            case BOOKING_SHORTENED:
+                            case BOOKING_CANCELED_LATE:
+                                changedBookingChangeIncidentIdsCopy[incidentID] = newValueFloat;
+                                this.setState({changedBookingChangeIncidentIds: changedBookingChangeIncidentIdsCopy, inputIdToFocus: incidentDescriptionID});
+                                break;
+                        }
+                    }
+                }
+            };
+
+            tableHeaders.forEach((header) => {
+                const columnTitle = incidentsReportHeaderTitles[header];
+
+                let showColumn = true;
+                if (header === 'memberName' && hideMemberName){
+                    showColumn = false;
+                }
+
+                if (columnTitle && showColumn){
+                    const columnAlignments = {
+                        left: 'left',
+                        right: 'right',
+                    };
+                    let columnContentsAlignment = columnAlignments.left;
+
+                    columns.push({
+                        Header: incidentsReportHeaderTitles[header],
+                        accessor: header,
+                        Cell: props => {
+                            let cellValue = '';
+                            let urlValue = undefined;
+                            let clickablePrice = undefined;
+                            let priceAsNumber = undefined;
+                            let priceInputID = undefined;
+                            let priceFontColor = 'black';
+
+                            switch (props.column.id) {
+                                case 'memberName':
+                                    const memberId = props.row['_original'].memberId;
+                                    urlValue = `/specific-member-incidents-report/${memberId}`;
+                                    cellValue = props.value;
+                                    break;
+                                case 'resourceName':
+                                    if (props.row['_original'].resourceName){
+                                        cellValue = props.row['_original'].resourceName || '---';
+                                    }else{
+                                        const oldResourceName = props.row['_original'].oldResourceName || '---';
+                                        const newResourceName = props.row['_original'].newResourceName || '---';
+                                        if (oldResourceName !== newResourceName){
+                                            cellValue = `${oldResourceName}\n${newResourceName}`;
+                                        }else{
+                                            cellValue = oldResourceName;
+                                        }
+                                    }
+                                    break;
+                                case 'reservation':
+                                    const bookingStart = props.row['_original'].bookingStart;
+                                    const bookingEnd = props.row['_original'].bookingEnd;
+                                    cellValue = `${bookingStart}\n${bookingEnd}`;
+                                    break;
+                                case 'doorLockTimestamps':
+                                    const unlockTimestamp = props.row['_original'].unlockTimestamp;
+                                    const lockTimestamp = props.row['_original'].lockTimestamp;
+                                    cellValue = `${unlockTimestamp ? unlockTimestamp : '---'}\n${lockTimestamp ? lockTimestamp : '---'}`;
+                                    break;
+                                case 'incidentType':
+                                    cellValue = incidentDescriptions[props.value];
+                                    break;
+                                case 'incidentLevel':
+                                    cellValue = incidentLevelDescriptions[props.value];
+                                    break;
+                                case 'feeDescription':
+                                    const { incidentType, incidentLevel, timeIntervalsToCharge } = props.row['_original'];
+
+                                    switch (incidentType) {
+                                        case UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION:
+                                        case UNLOCKED_INCIDENT_STANDALONE:
+                                            cellValue = `${incidentLevelDescriptions[incidentLevel]}`;
+                                            break;
+                                        case UNSCHEDULED_INCIDENT_BEFORE_RESERVATION:
+                                        case UNSCHEDULED_INCIDENT_AFTER_RESERVATION:
+                                        case UNSCHEDULED_INCIDENT_STANDALONE:
+                                            cellValue = `${timeIntervalsToCharge} x 5 min`;
+                                            break;
+                                        default:
+                                            cellValue = '';
+                                            break;
+                                    }
+                                    break;
+                                case 'totalChargeFee':
+                                    clickablePrice = true;
+                                    let totalFee = 0;
+
+                                    let changedIncidentsProxy;
+                                    switch (props.row['_original'].incidentType) {
+                                        case UNLOCKED_INCIDENT_STANDALONE:
+                                        case UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION:
+                                            changedIncidentsProxy = changedUnlockedIncidentIds;
+                                            break;
+                                        case UNSCHEDULED_INCIDENT_STANDALONE:
+                                        case UNSCHEDULED_INCIDENT_BEFORE_RESERVATION:
+                                        case UNSCHEDULED_INCIDENT_AFTER_RESERVATION:
+                                            changedIncidentsProxy = changedUnscheduledIncidentIds;
+                                            break;
+                                        case BOOKING_CANCELED_LATE:
+                                        case BOOKING_MOVED_TO_ANOTHER_DAY:
+                                        case BOOKING_SHORTENED:
+                                            changedIncidentsProxy = changedBookingChangeIncidentIds;
+                                            break;
+                                    }
+                                    const changedFee = changedIncidentsProxy[props.row['_original'].incidentId];
+
+                                    if (typeof changedFee === 'number'){
+                                        // Not undefined, maybe 0 or NaN
+                                        if (isNaN(changedFee)){
+                                            totalFee = '';
+                                        }else{
+                                            totalFee = changedFee;
+                                            priceFontColor = 'red';
+                                        }
+                                    }else{
+                                        //Not defined, in this context means it is not changed
+                                        totalFee = parseFloat((props.row['_original'].incidentPrice || props.value) || 0).toFixed(2);
+                                    }
+                                    // const totalFeeFormatted = parseFloat(totalFee).toFixed(2);
+                                    priceAsNumber = totalFee;
+                                    priceInputID = `${props.row['_original'].incidentType || ''}-${props.row['_original'].incidentId || ''}`;
+                                    // cellValue = `$ ${totalFeeFormatted}`;
+                                    columnContentsAlignment = columnAlignments.right;
+                                    break;
+                                case 'oldReservation':
+                                    const oldBookingStart = props.row['_original'].oldBookingStart;
+                                    const oldBookingEnd = props.row['_original'].oldBookingEnd;
+                                    cellValue = `${oldBookingStart}\n${oldBookingEnd}`;
+                                    break;
+                                case 'newReservation':
+                                    const newBookingStart = props.row['_original'].newBookingStart || '---';
+                                    const newBookingEnd = props.row['_original'].newBookingEnd || '---';
+                                    cellValue = `${newBookingStart}\n${newBookingEnd}`;
+                                    break;
+                                default:
+                                    cellValue = props.value;
+                            }
+
+                            if (clickablePrice){
+                                return <p>$ <input
+                                        id={priceInputID}
+                                        style={{ color: priceFontColor }}
+                                        type={'number'}
+                                        onChange={priceChangeHandler}
+                                        value={priceAsNumber}
+                                        autoFocus={priceInputID === inputIdToFocus}
+                                    />
+                                </p>
+                            }else{
+                                if (openMemberSummaryOnMemberClick && urlValue){
+                                    return <NavLink to={urlValue}>{cellValue}</NavLink>
+                                }else{
+                                    return <div style={{ textAlign: columnContentsAlignment, whiteSpace: 'pre' }}>{cellValue}</div>
+                                }
+                            }
+                        }
+                    });
+                }
+            });
+        }
+
+        return (
+            <div>
+                <h4>{title}</h4>
+                <Loader active={loading} />
+                {
+                    <Button disabled={loading || totalSelected === 0} onClick={this.deleteSelectedFees}>{`Delete selected ${numberOfSelectedText}`}</Button>
+                }
+                {
+                    <Button disabled={loading || totalChanged === 0} onClick={this.updateChangedFees}>{`Save changed ${numberOfChangedText}`}</Button>
+                }
+                <br/><br/>
+                {
+                    !loading && incidents &&
+                    <SelectTable
+                        data={incidents}
+                        multiSort={false}
+                        columns={columns}
+                        keyField="id"
+                        onSelectChange={this.onSelectChange}
+                    />
+                }
+            </div>
+        );
+    }
+}
+
+const mapDispatchToProps = (dispatch) => ({
+    deleteIncidentsById: (dateRange, incidentsToDelete, memberId) => deleteIncidents(dispatch, {dateRange, incidentsToDelete, memberId}),
+    updateIncidentsById: (dateRange, updatedIncidentsData, memberId) => updateIncidentFees(dispatch, {dateRange, updatedIncidentsData, memberId})
+});
+
+export default connect(null, mapDispatchToProps)(SingleIncidentsTable);

client/src/components/MemberIncidentsTables/index.js

@@ -8,7 +8,7 @@ import {
 } from '../../constants/enums';
 
 export default function MemberIncidentsTables (props) {
-    const { pendingIncidents, incidents, hideMemberName } = props;
+    const { pendingIncidents, incidents, hideMemberName, dateRange, memberId } = props;
 
     const incidentsRelatedToReservations = [];
     const standaloneIncidents = [];
@@ -46,6 +46,8 @@ export default function MemberIncidentsTables (props) {
             openMemberSummaryOnMemberClick
             hideMemberName={hideMemberName}
             tableType={incidentTableTypes.INCIDENTS_RELATED_TO_RESERVATIONS}
+            dateRange={dateRange}
+            memberId={memberId}
         />
     );
 
@@ -56,6 +58,8 @@ export default function MemberIncidentsTables (props) {
             openMemberSummaryOnMemberClick
             hideMemberName={hideMemberName}
             tableType={incidentTableTypes.STANDALONE_INCIDENTS}
+            dateRange={dateRange}
+            memberId={memberId}
         />
     );
 
@@ -66,6 +70,8 @@ export default function MemberIncidentsTables (props) {
             openMemberSummaryOnMemberClick
             hideMemberName={hideMemberName}
             tableType={incidentTableTypes.BOOKING_CHANGE_INCIDENTS}
+            dateRange={dateRange}
+            memberId={memberId}
         />
     );
 

client/src/components/SelectTable/index.js

@@ -0,0 +1,111 @@
+import React, { Component } from 'react';
+import Table from 'react-table';
+import SelectTableHOC from 'react-table/lib/hoc/selectTable';
+
+const SelectTableElement = SelectTableHOC(Table);
+
+class SelectTable extends Component {
+    static defaultProps = {
+        keyField: "id"
+    };
+
+    /**
+     * Toggle a single checkbox for select table
+     */
+    toggleSelection = (key, shift, row) => {
+        // start off with the existing state
+        let selection = [...this.state.selection];
+        const keyIndex = selection.indexOf(key);
+
+        // check to see if the key exists
+        if (keyIndex >= 0) {
+            // it does exist so we will remove it using destructing
+            selection = [
+                ...selection.slice(0, keyIndex),
+                ...selection.slice(keyIndex + 1)
+            ];
+        } else {
+            // it does not exist so add it
+            selection.push(key);
+        }
+        // update the state
+        this.props.onSelectChange(selection);
+        this.setState({ selection });
+    };
+
+    /**
+     * Toggle all checkboxes for select table
+     */
+    toggleAll = () => {
+        const { keyField } = this.props;
+        const selectAll = !this.state.selectAll;
+        const selection = [];
+
+        if (selectAll) {
+            // we need to get at the internals of ReactTable
+            const wrappedInstance = this.checkboxTable.getWrappedInstance();
+            // the 'sortedData' property contains the currently accessible records based on the filter and sort
+            const currentRecords = wrappedInstance.getResolvedState().sortedData;
+            // we just push all the IDs onto the selection array
+            currentRecords.forEach(item => {
+                selection.push(`select-${item._original[keyField]}`);
+            });
+        }
+        this.props.onSelectChange(selection);
+        this.setState({ selectAll, selection });
+    };
+
+    /**
+     * Whether or not a row is selected for select table
+     */
+    isSelected = key => {
+        return this.state.selection.includes(`select-${key}`);
+    };
+
+    rowFn = (state, rowInfo, column, instance) => {
+        const { selection } = this.state;
+
+        return {
+            onClick: (e, handleOriginal) => {
+                // console.log("It was in this row:", rowInfo);
+
+                // IMPORTANT! React-Table uses onClick internally to trigger
+                // events like expanding SubComponents and pivots.
+                // By default a custom 'onClick' handler will override this functionality.
+                // If you want to fire the original onClick handler, call the
+                // 'handleOriginal' function.
+                if (handleOriginal) {
+                    handleOriginal();
+                }
+            },
+            style: {
+                background:
+                    rowInfo &&
+                    selection.includes(`select-${rowInfo.original.id}`) &&
+                    "lightgreen"
+            }
+        };
+    };
+
+    state = {
+        selectAll: false,
+        selection: []
+    };
+
+    render() {
+        return (
+            <SelectTableElement
+                {...this.props}
+                ref={r => (this.checkboxTable = r)}
+                toggleSelection={this.toggleSelection}
+                selectAll={this.state.selectAll}
+                selectType="checkbox"
+                toggleAll={this.toggleAll}
+                isSelected={this.isSelected}
+                getTrProps={this.rowFn}
+            />
+        );
+    }
+}
+
+export default SelectTable;

client/src/constants/constants.js

@@ -1,3 +1,5 @@
+export const CONTAINER_WIDTH_PERCENTAGE = 90;
+
 export const defaultDateFormat = 'YYYY-MM-DD';
 
 export const doorLockRelatedWithReservationIncidentHeaders = [
@@ -5,6 +7,7 @@ export const doorLockRelatedWithReservationIncidentHeaders = [
     'resourceName',
     'memberName',
     'reservation',
+    'doorLockTimestamps',
     'incidentType',
     'feeDescription',
     'totalChargeFee'

client/src/scenes/Home/index.js

@@ -4,12 +4,13 @@ import { Container, Message } from 'semantic-ui-react';
 
 import MainMenu from '../../components/MainMenu';
 import { mainMenuItems } from '../../constants/menuItems';
+import {CONTAINER_WIDTH_PERCENTAGE} from "../../constants/constants";
 
 class Home extends Component {
 
     render () {
         return (
-            <Container>
+            <Container style={ {width: `${CONTAINER_WIDTH_PERCENTAGE}%`} }>
                 <MainMenu/>
                 <h3>SIMA SPACE </h3>
                 <hr/>

client/src/scenes/IncidentsReport/index.js

@@ -3,11 +3,12 @@ import { connect } from 'react-redux';
 import { Container } from 'semantic-ui-react';
 
 import MainMenu from '../../components/MainMenu';
-import MonthSelector from '../../components/MonthSelector';
+import DateRangePicker from '../../components/DateRangePicker';
 import MemberIncidentsTables from '../../components/MemberIncidentsTables';
 import GenerateFeesInORDButton from '../../components/GenerateFeesInORDButton';
 
 import { fetchIncidents } from '../../store/actions';
+import { CONTAINER_WIDTH_PERCENTAGE } from '../../constants/constants';
 
 class IncidentsReport extends Component {
     state = {dateRange: null};
@@ -33,11 +34,11 @@ class IncidentsReport extends Component {
         }
 
         return (
-            <Container>
+            <Container style={ {width: `${CONTAINER_WIDTH_PERCENTAGE}%`} }>
                 <MainMenu/>
                 <h3>Incidents Report</h3>
                 <hr/>
-                <MonthSelector buttonLabel="Show report" onDatesUpdate={this.onDatesUpdate} inlineButton />
+                <DateRangePicker buttonLabel="Show report" onDatesUpdate={this.onDatesUpdate} inlineButton />
                 <br/>
                 <GenerateFeesInORDButton
                     disabled={loading}
@@ -46,7 +47,7 @@ class IncidentsReport extends Component {
                 <br/><br/>
                 <hr/>
                 <br/>
-                <MemberIncidentsTables pendingIncidents={loading} incidents={incidents} />
+                <MemberIncidentsTables pendingIncidents={loading} incidents={incidents} dateRange={dateRange} />
             </Container>
         );
     }

client/src/scenes/MemberPracticeSummaryReport/index.js

@@ -5,6 +5,7 @@ import { Container, Button, Loader, Input, Message, Grid } from 'semantic-ui-rea
 import MainMenu from '../../components/MainMenu';
 
 import { fetchMemberPracticeSummaryReport } from '../../store/actions';
+import {CONTAINER_WIDTH_PERCENTAGE} from "../../constants/constants";
 
 class MemberPracticeSummaryReport extends Component {
 
@@ -54,7 +55,7 @@ class MemberPracticeSummaryReport extends Component {
         error = fetchReportError ? fetchReportError : error;
 
         return (
-            <Container>
+            <Container style={ {width: `${CONTAINER_WIDTH_PERCENTAGE}%`} }>
                 <MainMenu/>
                 <h3>Member Practice Summary Report</h3>
                 <hr/>

client/src/scenes/RoomOfficeNameMapping/components/SingleMapping.js

@@ -76,67 +76,71 @@ class SingleMapping extends Component {
     };
 
     render() {
-        const { singleMapping: { officeSlug, resourceSlug } } = this.props;
+        try {
-        const { officeId, resourceId, officeOptions, allResourceOptions, pendingMappings } = this.props;
+            const {singleMapping: {officeSlug, resourceSlug}} = this.props;
-        const { showDeletePrompt, newOfficeId, newResourceId } = this.state;
+            const {officeId, resourceId, officeOptions, allResourceOptions, pendingMappings} = this.props;
+            const {showDeletePrompt, newOfficeId, newResourceId} = this.state;
 
-        const selectedOfficeId = newOfficeId ? newOfficeId : officeId;
+            const selectedOfficeId = newOfficeId ? newOfficeId : officeId;
-        const selectedResourceId = newResourceId ? newResourceId : resourceId;
+            const selectedResourceId = newResourceId ? newResourceId : resourceId;
 
-        const resourceOptions = allResourceOptions && officeId ? allResourceOptions[selectedOfficeId].roomOptions : [];
+            const resourceOptions = allResourceOptions && officeId ? allResourceOptions[selectedOfficeId].roomOptions : [];
 
-        const enableActions = !pendingMappings;
+            const enableActions = !pendingMappings;
-        const enableSave = enableActions && ((newOfficeId !== null) || (newResourceId !== null));
+            const enableSave = enableActions && ((newOfficeId !== null) || (newResourceId !== null));
-        const saveIconColor = enableSave ? 'green' : null;
+            const saveIconColor = enableSave ? 'green' : null;
 
-        return (
+            return (
-            <Table.Row>
+                <Table.Row>
-                <PromptMessage
+                    <PromptMessage
-                    onClose={this.onPromptClose}
+                        onClose={this.onPromptClose}
-                    onActionNo={this.onPromptClose}
+                        onActionNo={this.onPromptClose}
-                    onActionYes={this.onPromptYes}
+                        onActionYes={this.onPromptYes}
-                    title={'Delete mapping'}
+                        title={'Delete mapping'}
-                    message={'Do you want to delete this mapping ?'}
+                        message={'Do you want to delete this mapping ?'}
-                    show={showDeletePrompt}
+                        show={showDeletePrompt}
-                />
-                <Table.Cell>
-                    <Label size={'big'}>{`[${officeSlug}-${resourceSlug}]`}</Label>
-                </Table.Cell>
-                <Table.Cell>
-                    <Dropdown
-                        options={officeOptions}
-                        defaultValue={officeId}
-                        onChange={this.onOfficeChange}
                     />
-                </Table.Cell>
+                    <Table.Cell>
-                <Table.Cell>
+                        <Label size={'big'}>{`[${officeSlug}-${resourceSlug}]`}</Label>
-                    <Dropdown
+                    </Table.Cell>
-                        options={resourceOptions}
+                    <Table.Cell>
-                        value={selectedResourceId}
+                        <Dropdown
-                        onChange={this.onResourceChange}
+                            options={officeOptions}
-                    />
+                            defaultValue={officeId}
-                </Table.Cell>
+                            onChange={this.onOfficeChange}
-                <Table.Cell>
+                        />
-                    <Icon
+                    </Table.Cell>
-                        circular
+                    <Table.Cell>
-                        name={'check'}
+                        <Dropdown
-                        size={'large'}
+                            options={resourceOptions}
-                        disabled={!enableSave}
+                            value={selectedResourceId}
-                        link={enableSave || null}
+                            onChange={this.onResourceChange}
-                        color={saveIconColor}
+                        />
-                        onClick={this.onMappingUpdate}
+                    </Table.Cell>
-                    />
+                    <Table.Cell>
-                    <Icon
+                        <Icon
-                        circular
+                            circular
-                        name={'trash'}
+                            name={'check'}
-                        size={'large'}
+                            size={'large'}
-                        disabled={!enableActions}
+                            disabled={!enableSave}
-                        link={enableActions || null}
+                            link={enableSave || null}
-                        onClick={this.deleteMapping}
+                            color={saveIconColor}
-                    />
+                            onClick={this.onMappingUpdate}
-                </Table.Cell>
+                        />
-            </Table.Row>
+                        <Icon
-        );
+                            circular
+                            name={'trash'}
+                            size={'large'}
+                            disabled={!enableActions}
+                            link={enableActions || null}
+                            onClick={this.deleteMapping}
+                        />
+                    </Table.Cell>
+                </Table.Row>
+            );
+        }catch (e) {
+            return null;
+        }
     }
 }
 

client/src/scenes/RoomOfficeNameMapping/index.js

@@ -5,6 +5,7 @@ import { Container, Message, Loader, Table } from 'semantic-ui-react';
 import MainMenu from '../../components/MainMenu';
 import { fetchMappings } from '../../store/actions';
 import SingleMapping from './components/SingleMapping';
+import {CONTAINER_WIDTH_PERCENTAGE} from "../../constants/constants";
 
 class RoomOfficeNameMapping extends Component {
 
@@ -47,7 +48,7 @@ class RoomOfficeNameMapping extends Component {
         });
 
         return (
-            <Container>
+            <Container style={ {width: `${CONTAINER_WIDTH_PERCENTAGE}%`} }>
                 <Loader active={pendingMappings} />
                 <MainMenu/>
                 <h3>Room Office Mapping</h3>

client/src/scenes/SpecificMemberIncidentsReport/index.js

@@ -3,13 +3,14 @@ import { connect } from 'react-redux';
 import { Container, Grid } from 'semantic-ui-react';
 
 import MainMenu from '../../components/MainMenu';
-import MonthSelector from '../../components/MonthSelector';
+import DateRangePicker from '../../components/DateRangePicker';
 import MemberSelector from './components/MemberSelector';
 import MemberSummary from './components/MemberSummary';
 import MemberIncidentsTables from '../../components/MemberIncidentsTables';
 import GenerateFeesInORDButton from '../../components/GenerateFeesInORDButton';
 
 import { fetchMemberIncidents } from '../../store/actions';
+import {CONTAINER_WIDTH_PERCENTAGE} from "../../constants/constants";
 
 class SpecificMemberIncidentsReport extends Component {
     constructor(props){
@@ -48,7 +49,7 @@ class SpecificMemberIncidentsReport extends Component {
         const addFeesButtonDisabled = !memberId || !dateRange || loading;
 
         return (
-            <Container>
+            <Container style={ {width: `${CONTAINER_WIDTH_PERCENTAGE}%`} }>
                 <MainMenu/>
                 <h3>Member Incidents Report</h3>
                 <hr/>
@@ -58,7 +59,7 @@ class SpecificMemberIncidentsReport extends Component {
                             <MemberSelector onMemberSelect={this.onMemberSelectionUpdate.bind(this)} defaultMemberId={memberId} />
                         </Grid.Column>
                         <Grid.Column>
-                            <MonthSelector inlineButton onDatesUpdate={this.onDateRangeUpdate.bind(this)}/>
+                            <DateRangePicker inlineButton onDatesUpdate={this.onDateRangeUpdate.bind(this)}/>
                         </Grid.Column>
                     </Grid.Row>
                     <Grid.Row>
@@ -82,7 +83,13 @@ class SpecificMemberIncidentsReport extends Component {
                     <Grid.Row/>
                     <Grid.Row>
                         <Grid.Column>
-                            <MemberIncidentsTables incidents={memberIncidents} pendingIncidents={loading} hideMemberName/>
+                            <MemberIncidentsTables
+                                incidents={memberIncidents}
+                                pendingIncidents={loading}
+                                hideMemberName
+                                dateRange={dateRange}
+                                memberId={memberId}
+                            />
                         </Grid.Column>
                     </Grid.Row>
                 </Grid>

client/src/scenes/UploadDLockData/index.js

@@ -4,10 +4,11 @@ import { Container, Form } from 'semantic-ui-react';
 import MainMenu from '../../components/MainMenu';
 import FileUpload from './components/FileUpload';
 import UploadResults from './components/UploadResults';
+import {CONTAINER_WIDTH_PERCENTAGE} from "../../constants/constants";
 
 function UploadDLockData() {
     return (
-        <Container>
+        <Container style={ {width: `${CONTAINER_WIDTH_PERCENTAGE}%`} }>
             <MainMenu/>
             <h3>DLock Data</h3>
             <hr/>

client/src/store/actions/integrationActions.js

@@ -88,6 +88,36 @@ export const fetchIncidents = (dispatch, dateRange) => {
         });
 };
 
+export const deleteIncidents = (dispatch, deleteData) => {
+    const pendingAction = deleteData.memberId ? FETCH_MEMBER_INCIDENTS_PENDING : FETCH_INCIDENTS_PENDING;
+    const successAction = deleteData.memberId ? FETCH_MEMBER_INCIDENTS_SUCCESS : FETCH_INCIDENTS_SUCCESS;
+    const failedAction = deleteData.memberId ? FETCH_MEMBER_INCIDENTS_FAILED : FETCH_INCIDENTS_FAILED;
+
+    dispatch({type: pendingAction});
+    API.delete(`/integration/fees`, { data: deleteData })
+        .then(response => {
+            dispatch({type: successAction, payload: response.data});
+        })
+        .catch(error => {
+            dispatch({type: failedAction, payload: error.response});
+        });
+};
+
+export const updateIncidentFees = (dispatch, updateData) => {
+    const pendingAction = updateData.memberId ? FETCH_MEMBER_INCIDENTS_PENDING : FETCH_INCIDENTS_PENDING;
+    const successAction = updateData.memberId ? FETCH_MEMBER_INCIDENTS_SUCCESS : FETCH_INCIDENTS_SUCCESS;
+    const failedAction = updateData.memberId ? FETCH_MEMBER_INCIDENTS_FAILED : FETCH_INCIDENTS_FAILED;
+
+    dispatch({type: pendingAction});
+    API.patch(`/integration/fees`, updateData)
+        .then(response => {
+            dispatch({type: successAction, payload: response.data});
+        })
+        .catch(error => {
+            dispatch({type: failedAction, payload: error.response});
+        });
+};
+
 export const fetchMembersList = (dispatch) => {
     dispatch({type: FETCH_MEMBERS_PENDING});
     API.get('officeRnD/membersList')

constants/constants.js

@@ -14,37 +14,37 @@ const unlockedIncidentLevelsPrices = {
         id: 0,
         title: 'UNLOCKED_0',
         price: parseInt(process.env.UNLOCK_0) || 0,
-        description: 'First month - warning',
+        description: 'first month - warning',
     },
     UNLOCKED_1: {
         id: 1,
         title: 'UNLOCKED_1',
         price: parseInt(process.env.UNLOCK_1) || 10,
-        description: 'Second month',
+        description: 'second month',
     },
     UNLOCKED_2: {
         id: 2,
         title: 'UNLOCKED_2',
         price: parseInt(process.env.UNLOCK_2) || 20,
-        description: 'Third month',
+        description: 'third month',
     },
     UNLOCKED_3: {
         id: 3,
         title: 'UNLOCKED_3',
         price: parseInt(process.env.UNLOCK_3) || 30,
-        description: 'Fourth month',
+        description: 'fourth month',
     },
     UNLOCKED_4: {
         id: 4,
         title: 'UNLOCKED_4',
         price: parseInt(process.env.UNLOCK_4) || 40,
-        description: 'Fifth month',
+        description: 'fifth month',
     },
     UNLOCKED_5: {
         id: 5,
         title: 'UNLOCKED_5',
         price: parseInt(process.env.UNLOCK_5) || 50,
-        description: 'Sixth month and onward',
+        description: 'sixth month and onward',
     }
 };
 const csvParserErrors = {
@@ -57,6 +57,8 @@ const csvParserErrors = {
 const officeRnDAPIErrors = {
     FAILED_TO_FETCH_MEMBERS: 'Failed to fetch members',
     FAILED_TO_FETCH_BOOKINGS: 'Failed to fetch booking reservations',
+    FAILED_TO_CREATE_BOOKINGS: 'Failed to create booking reservations',
+    FAILED_TO_DELETE_BOOKINGS: 'Failed to delete booking reservations',
     FAILED_TO_FETCH_FEES: 'Failed to fetch existing fees from ORD',
     FAILED_TO_FETCH_PLANS: 'Failed to fetch plans from ORD',
     FAILED_TO_DELETE_FEES: 'Failed to delete fees in ORD',
@@ -95,20 +97,21 @@ const incidentType = {
 };
 
 const incidentTypeExplanations = {};
-incidentTypeExplanations[incidentType.UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION] = 'Door left unlocked';
+incidentTypeExplanations[incidentType.UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION] = 'door left unlocked';
-incidentTypeExplanations[incidentType.UNLOCKED_INCIDENT_STANDALONE]               = 'Door left unlocked';
+incidentTypeExplanations[incidentType.UNLOCKED_INCIDENT_STANDALONE]               = 'door left unlocked';
-incidentTypeExplanations[incidentType.UNSCHEDULED_INCIDENT_BEFORE_RESERVATION]    = 'Room used before reservation';
+incidentTypeExplanations[incidentType.UNSCHEDULED_INCIDENT_BEFORE_RESERVATION]    = 'room used before reservation';
-incidentTypeExplanations[incidentType.UNSCHEDULED_INCIDENT_AFTER_RESERVATION]     = 'Room used after reservation';
+incidentTypeExplanations[incidentType.UNSCHEDULED_INCIDENT_AFTER_RESERVATION]     = 'room used after reservation';
-incidentTypeExplanations[incidentType.UNSCHEDULED_INCIDENT_STANDALONE]            = 'Room used without reservation';
+incidentTypeExplanations[incidentType.UNSCHEDULED_INCIDENT_STANDALONE]            = 'room used without reservation';
-incidentTypeExplanations[incidentType.BOOKING_MOVED_TO_ANOTHER_DAY]               = 'Reservation moved to another day';
+incidentTypeExplanations[incidentType.BOOKING_MOVED_TO_ANOTHER_DAY]               = 'reservation moved to another day in less than 24 hrs';
-incidentTypeExplanations[incidentType.BOOKING_SHORTENED]                          = 'Reservation shortened after grace period';
+incidentTypeExplanations[incidentType.BOOKING_SHORTENED]                          = 'reservation shortened after grace period';
-incidentTypeExplanations[incidentType.BOOKING_CANCELED_LATE]                      = 'Reservation cancelled after grace period';
+incidentTypeExplanations[incidentType.BOOKING_CANCELED_LATE]                      = 'reservation cancelled after grace period';
 
 const UI_TIMEZONE = process.env.UI_TIMEZONE || 'America/Los_Angeles';
 
 const DEFAULT_DATE_FORMAT = 'YYYY-MM-DD';
 
 const MAX_BACK_TO_BACK_DIFFERENCE = parseInt(process.env.MAX_BACK_TO_BACK_DIFFERENCE) || 0;
+const UNSCHEDULED_USE_INITIAL_TIME_SEGMENT_LENGTH = parseInt(process.env.UNSCHEDULED_USE_INITIAL_TIME_SEGMENT_LENGTH) || 7;
 const UNSCHEDULED_TIME_RESOLUTION = parseInt(process.env.UNSCHEDULED_USE_TIME_RESOLUTION) || 5;
 const UNSCHEDULED_CHARGE_PRICE = parseFloat(process.env.UNSCHEDULED_USE_CHARGE_PRICE) || 5;
 
@@ -137,6 +140,8 @@ const UNPAID_FEE_STATUS = 'not_paid';
 
 const ALLOW_SENDING_FEES = parseInt(process.env.ALLOW_SENDING_FEES_FOR_CURRENT_AND_FUTURE_MONTHS) ? true : false;
 
+const TRIM_DLOCK_NAMES_LENGTH = parseInt(process.env.TRIM_DLOCK_NAMES_LENGTH) || 22;
+
 module.exports = {
     VALID_CSV_HEADERS,
     USER_ENTRY_EVENT,
@@ -152,6 +157,7 @@ module.exports = {
     UI_TIMEZONE,
     DEFAULT_DATE_FORMAT,
     MAX_BACK_TO_BACK_DIFFERENCE,
+    UNSCHEDULED_USE_INITIAL_TIME_SEGMENT_LENGTH,
     UNSCHEDULED_TIME_RESOLUTION,
     UNSCHEDULED_CHARGE_PRICE,
     BOOKING_CHANGE_PERCENTAGE_CHARGE,
@@ -162,4 +168,5 @@ module.exports = {
     UNPAID_FEE_STATUS,
     CUSTOM_FEES_PREFIXES,
     ALLOW_SENDING_FEES,
+    TRIM_DLOCK_NAMES_LENGTH
 };

controllers/integration.js

@@ -2,13 +2,25 @@
 
 const moment = require('moment-timezone');
 
-const { getMappingsFromDatabase, fetchOffices, fetchResources, saveNewMappingToDatabase, deleteMappingById, updateMappingById } = require('../services/officeRnD/resources');
+const {
+    getMappingsFromDatabase,
+    fetchOffices,
+    fetchResources,
+    saveNewMappingToDatabase,
+    deleteMappingById,
+    updateMappingById } = require('../services/officeRnD/resources');
 const { getAllIncidents, getMemberPracticeSummaryReport } = require('../services/integration/reports');
 const { getMembersFeesForDateRange } = require('../services/integration/invoiceIntegration');
 const { deleteFeesFromORD, addFeesToORD } = require('../services/officeRnD/fees');
 const { reformatMembershipsName } = require('../services/officeRnD/memberships');
 const { checkBookingChanges } = require('../services/integration/checkBookingChange');
 const { checkIfProcessing } = require('../services/integration/processingStatus');
+const {
+    deleteUnlockedIncidentsById,
+    deleteUnscheduledIncidentsById,
+    updateUnscheduledIncidentsById,
+    updateUnlockedIncidentsById } = require('../services/integration/doorLockCharges');
+const { deleteBookingChangeIncidentsById, updateBookingChangeIncidentsById } = require('../services/integration/bookingChangeCharges');
 
 const { UI_TIMEZONE, DEFAULT_DATE_FORMAT, ALLOW_SENDING_FEES, integrationServiceErrors } = require('../constants/constants');
 
@@ -175,6 +187,92 @@ const addFees = (req, res) => {
     }
 };
 
+const deleteFees = (req, res) => {
+    const deleteData = req.body;
+    const dateRange = deleteData.dateRange ? deleteData.dateRange : null;
+    const incidents = deleteData.incidentsToDelete ? deleteData.incidentsToDelete : null;
+    const memberId = deleteData.memberId ? deleteData.memberId : null;
+
+    const unlockedIncidentIds = incidents.unlockedIncidentIds ? incidents.unlockedIncidentIds : [];
+    const unscheduledIncidentIds = incidents.unscheduledIncidentIds ? incidents.unscheduledIncidentIds : [];
+    const bookingChangeIncidentIds = incidents.bookingChangeIncidentIds ? incidents.bookingChangeIncidentIds : [];
+
+    req.params.startDate = dateRange.startDate ? dateRange.startDate : null;
+    req.params.endDate = dateRange.endDate ? dateRange.endDate : null;
+
+    if (Array.isArray(unlockedIncidentIds) && Array.isArray(unscheduledIncidentIds) && Array.isArray(bookingChangeIncidentIds)){
+        const asyncDeleteActions = [
+            deleteUnlockedIncidentsById(unlockedIncidentIds),
+            deleteUnscheduledIncidentsById(unscheduledIncidentIds),
+            deleteBookingChangeIncidentsById(bookingChangeIncidentIds)
+        ];
+
+        Promise.all(asyncDeleteActions)
+            .then(() => {
+                if (memberId){
+                    req.params.memberId = memberId;
+                    getMemberIncidents(req, res);
+                }else{
+                    getAllIncidentsController(req, res);
+                }
+            })
+            .catch((error) => {
+                console.log('Error deleting incidents : ', error);
+                res.status(500).send();
+            });
+    }else{
+        if (memberId){
+            req.params.memberId = memberId;
+            getMemberIncidents(req, res);
+        }else{
+            getAllIncidentsController(req, res);
+        }
+    }
+};
+
+const updateFees = (req, res) => {
+    const updateData = req.body;
+    const dateRange = updateData.dateRange ? updateData.dateRange : null;
+    const incidents = updateData.updatedIncidentsData ? updateData.updatedIncidentsData : null;
+    const memberId = updateData.memberId ? updateData.memberId : null;
+
+    const unlockedIncidentFees = incidents.unlockedIncidentFees ? incidents.unlockedIncidentFees : {};
+    const unscheduledIncidentFees = incidents.unscheduledIncidentFees ? incidents.unscheduledIncidentFees : {};
+    const bookingChangeIncidentFees = incidents.bookingChangeIncidentFees ? incidents.bookingChangeIncidentFees : {};
+
+    req.params.startDate = dateRange.startDate ? dateRange.startDate : null;
+    req.params.endDate = dateRange.endDate ? dateRange.endDate : null;
+
+    if (unlockedIncidentFees && unscheduledIncidentFees && bookingChangeIncidentFees){
+        const asyncUpdateActions = [
+            updateUnlockedIncidentsById(unlockedIncidentFees),
+            updateUnscheduledIncidentsById(unscheduledIncidentFees),
+            updateBookingChangeIncidentsById(bookingChangeIncidentFees)
+        ];
+
+        Promise.all(asyncUpdateActions)
+            .then(() => {
+                if (memberId){
+                    req.params.memberId = memberId;
+                    getMemberIncidents(req, res);
+                }else{
+                    getAllIncidentsController(req, res);
+                }
+            })
+            .catch((error) => {
+                console.log('Error updating incidents : ', error);
+                res.status(500).send();
+            });
+    }else{
+        if (memberId){
+            req.params.memberId = memberId;
+            getMemberIncidents(req, res);
+        }else{
+            getAllIncidentsController(req, res);
+        }
+    }
+};
+
 const checkProcessingStatus = (req, res) => {
     checkIfProcessing()
         .then((processing) => {
@@ -227,4 +325,6 @@ module.exports = {
     addFees,
     checkProcessingStatus,
     getPracticeSummaryReport,
+    deleteFees,
+    updateFees
 };

environment.env

@@ -8,6 +8,7 @@ EARLIEST_UNLOCK=Time in minutes
 
 UI_TIMEZONE=Timezone for user interface | https://en.wikipedia.org/wiki/List_of_tz_database_time_zones | example : America/Los_Angeles
 
+UNSCHEDULED_USE_INITIAL_TIME_SEGMENT_LENGTH=Time in minutes when first unscheduled use charge will be applied
 UNSCHEDULED_USE_TIME_RESOLUTION=Time in minutes
 UNSCHEDULED_USE_CHARGE_PRICE=Charge price
 
@@ -41,6 +42,8 @@ CUSTOM_FEES_PREFIXES=Array of prefixes to recognize manually added fees. Comma-s
 
 ALLOW_SENDING_FEES_FOR_CURRENT_AND_FUTURE_MONTHS=0 - false => Sending fees is disabled for current and future months, 1 - true => Sending fees is never disabled
 
+TRIM_DLOCK_NAMES_LENGTH=Length of names in DLOCK files that will be taken to compare with ORD member names
+
 #More about pool option : http://docs.sequelizejs.com/class/lib/sequelize.js~Sequelize.html
 DB_POOL_MAX_CONNECTIONS=Maximum number of connection in pool (ex. 18)
 DB_POOL_ACQUIRE=The maximum time, in milliseconds, that pool will try to get connection before throwing error (ex. 120000)

migrations/20191120144357-add-deleted-column-for-unlocked-incidents-table.js

@@ -0,0 +1,14 @@
+'use strict';
+
+module.exports = {
+  up: (queryInterface, Sequelize) => {
+    return queryInterface.addColumn('unlockedIncidents', 'deleted', {
+      type: Sequelize.BOOLEAN,
+      defaultValue: false,
+    });
+  },
+
+  down: (queryInterface, Sequelize) => {
+    return queryInterface.removeColumn('unlockedIncidents', 'deleted');
+  }
+};

migrations/20191120144439-add-deleted-column-for-unscheduled-incidents-table.js

@@ -0,0 +1,14 @@
+'use strict';
+
+module.exports = {
+  up: (queryInterface, Sequelize) => {
+    return queryInterface.addColumn('unscheduledIncidents', 'deleted', {
+      type: Sequelize.BOOLEAN,
+      defaultValue: false,
+    });
+  },
+
+  down: (queryInterface, Sequelize) => {
+    return queryInterface.removeColumn('unscheduledIncidents', 'deleted');
+  }
+};

models/unlockedIncident.js

@@ -22,6 +22,7 @@ module.exports = (sequelize, DataTypes) => {
         },
         incidentLevelPrice: DataTypes.FLOAT,
         unlockTimestamp: DataTypes.DATE,
+        deleted: DataTypes.BOOLEAN
     }, {});
     unlockedIncident.associate = function(models) {
         // associations can be defined here

models/unscheduledIncident.js

@@ -19,6 +19,7 @@ module.exports = (sequelize, DataTypes) => {
         totalChargeFee: DataTypes.FLOAT,
         unlockTimestamp: DataTypes.DATE,
         lockTimestamp: DataTypes.DATE,
+        deleted: DataTypes.BOOLEAN
     }, {});
     unscheduledIncident.associate = function(models) {
         // associations can be defined here

routes/index.js

@@ -13,6 +13,8 @@ const {
     addFees,
     checkProcessingStatus,
     getPracticeSummaryReport,
+    deleteFees,
+    updateFees
 } = require('../controllers/integration');
 
 const { calculateDoorLockCharges } = require('../services/integration/doorLockCharges');
@@ -34,6 +36,8 @@ router.get('/integration/report/allIncidents/:startDate/:endDate', getAllInciden
 router.get('/officeRnD/membersList', fetchMembersList);
 
 router.post('/integration/addFees', addFees);
+router.delete('/integration/fees', deleteFees);
+router.patch('/integration/fees', updateFees);
 
 router.get('/integration/processing', checkProcessingStatus);
 
@@ -42,6 +46,14 @@ router.get('/integration/report/practiceSummary/:year', getPracticeSummaryReport
 
 
 // temporary route, manually trigger door lock charge calculations
-router.get('/calculate', (req, res) => { calculateDoorLockCharges(); res.send();});
+router.get('/calculate', (req, res) => {
+    calculateDoorLockCharges()
+        .then(() => {
+            res.send('Done');
+        })
+        .catch((err) => {
+            res.send(`Error \r\n ${err}`);
+        });
+});
 
 module.exports = router;

services/doorLock/doorLock.js

@@ -14,11 +14,12 @@ const {
     VALID_CSV_HEADERS,
     doorLockEvents,
     csvParserErrors,
+    TRIM_DLOCK_NAMES_LENGTH
 } = require('../../constants/constants');
 
 const { fetchAllMembers } = require('../officeRnD/members');
 const { getMappingsFromDatabase } = require('../officeRnD/resources');
-const { getFirstReservationInBlock } = require('../officeRnD/bookings');
+const { getFirstReservationInBlock, getFirstPreviousBooking } = require('../officeRnD/bookings');
 
 const extractMappingFromFileName = (fileName) => {
     const contentBetweenBracketsRegex = /\[(.*?)\]/;
@@ -53,7 +54,12 @@ const parseDoorLockDataFile = (file) => {
                 const membersMap = {};
                 const unknownMembersMap = {};
 
-                allMembers.forEach((member) => membersMap[member.name] = member);
+                allMembers.forEach((member) => {
+                    const limitedMemberName = member.name ? member.name.substring(0, TRIM_DLOCK_NAMES_LENGTH) || undefined : undefined;
+                    if (limitedMemberName){
+                        membersMap[limitedMemberName] = member;
+                    }
+                });
 
                 const mappingFromFileName = extractMappingFromFileName(file.name);
                 const mappingObject = checkIfMappingExsists(mappingFromFileName, mappings);
@@ -110,18 +116,20 @@ const parseDoorLockDataFile = (file) => {
                             const firstEntry = results[i];
                             const secondEntry = results[i+1];
 
-                            if (firstEntry && (firstEntry.event === USER_ENTRY_EVENT)){
+                            const trimmedName = firstEntry && firstEntry.name ? firstEntry.name.substring(0, TRIM_DLOCK_NAMES_LENGTH) || undefined : undefined;
-                                const memberObject = membersMap[firstEntry.name];
+
+                            if (firstEntry && trimmedName && (firstEntry.event === USER_ENTRY_EVENT)){
+                                const memberObject = membersMap[trimmedName];
 
                                 if (!memberObject){
                                     //Check if member is already labeled as unknown
-                                    const unknownMember = unknownMembersMap[firstEntry.name];
+                                    const unknownMember = unknownMembersMap[trimmedName];
 
                                     if (!unknownMember){
-                                        unknownMembersMap[firstEntry.name] = firstEntry.name;
+                                        unknownMembersMap[trimmedName] = trimmedName;
                                         unknownMembersToReport.push({
                                             error: csvParserErrors.UNKNOWN_MEMBER,
-                                            details: firstEntry.name,
+                                            details: trimmedName,
                                             file: file.name,
                                         });
                                     }
@@ -137,7 +145,7 @@ const parseDoorLockDataFile = (file) => {
                                     //Verify that member is registered in OfficeRnD system
                                     if (memberObject){
                                         const entryData = {
-                                            memberName: firstEntry.name,
+                                            memberName: trimmedName,
                                             memberNumber: firstEntry['user no'],
                                             memberId: memberObject.memberId,
                                             timestamp,
@@ -197,6 +205,14 @@ const getUnlockEntryForReservation = (reservation, previousReservation) => {
 
         const toTimestamp = reservation.end;
 
+        // if (reservation.memberId === '5ce785af422bdd00967fb781') {
+        //     console.log('=======================');
+        //     console.log('\tStart : ', moment.tz(reservation.start, reservation.timezone).format('DD.MM, HH:mm'));
+        //     console.log('\tEnd   : ', moment.tz(reservation.end, reservation.timezone).format('DD.MM, HH:mm'));
+        //     console.log('\t----------------------------------');
+        //     console.log('\tFrom time : ', fromTimestamp);
+        //     console.log('\tTo time   : ', toTimestamp);
+        // }
 
         const filters = {
             memberId,
@@ -222,7 +238,25 @@ const getUnlockEntryForReservation = (reservation, previousReservation) => {
 
                 const entriesBeforeReservationStart = entries.filter((entry) => moment.utc(entry.timestamp).isBefore(reservation.start));
 
+                // if (memberId === '5ce785af422bdd00967fb781') {
+                //     console.log('Start : ', moment.tz(reservation.start, UI_TIMEZONE).format('DD.MM HH:mm'));
+                //     console.log('End   : ', moment.tz(reservation.end, UI_TIMEZONE).format('DD.MM HH:mm'));
+                //     console.log('\tPrevious reservation ');
+                //     console.log('\tStart : ', previousReservation ? moment.tz(previousReservation.start, UI_TIMEZONE).format('DD.MM HH:mm') : '-');
+                //     console.log('\tEnd   : ', previousReservation ? moment.tz(previousReservation.end, UI_TIMEZONE).format('DD.MM HH:mm') : '-');
+                //     console.log('\t---------------------------');
+                //     console.log('\tSearch for entries : ');
+                //     console.log('\tFrom : ', fromTimestamp ? moment.tz(fromTimestamp, UI_TIMEZONE).format('DD.MM HH:mm') : '-');
+                //     console.log('\tTo   : ', toTimestamp ? moment.tz(toTimestamp, UI_TIMEZONE).format('DD.MM HH:mm') : '-');
+                //     console.log('\t---------------------------');
+                //     console.log('\tEntries before reservation start : ');
+                // }
+
                 entriesBeforeReservationStart.forEach((entry) => {
+                    // if (memberId === '5ce785af422bdd00967fb781') {
+                    //     console.log('\t', entry.event, '\t', moment.tz(entry.timestamp, UI_TIMEZONE).format('DD.MM HH:mm'));
+                    // }
+
                     if (!eventFound) {
                         if (entry.event === doorLockEvents.USER_UNLOCKED) {
                             if (pairedLockEntry) {
@@ -240,13 +274,25 @@ const getUnlockEntryForReservation = (reservation, previousReservation) => {
                 });
 
                 if (eventFound){
+                    // if (memberId === '5ce785af422bdd00967fb781') {
+                    //     console.log('\t=> FOUND UNLOCK ENTRY - NO NEED TO LOOK AFTER <=');
+                    // }
                     resolve(candidateUnlockEntry);
                 } else {
                     candidateUnlockEntry = null;
                     const numberOfEntriesLeft = entries.length - entriesBeforeReservationStart.length;
                     const entriesAfterReservationStart = entries.slice(0, numberOfEntriesLeft);
+                    const invertedEntriesAfterReservationStart = entriesAfterReservationStart.reverse();
+
+                    // if (memberId === '5ce785af422bdd00967fb781') {
+                    //     console.log('\t-----------------------------');
+                    //     console.log('\tEntries after reservation start : ');
+                    // }
+                    invertedEntriesAfterReservationStart.forEach((entry) => {
+                        // if (memberId === '5ce785af422bdd00967fb781') {
+                        //     console.log('\t', entry.event, '\t', moment.tz(entry.timestamp, UI_TIMEZONE).format('DD.MM HH:mm'));
+                        // }
 
-                    entriesAfterReservationStart.forEach((entry) => {
                         if (!eventFound) {
                             if (entry.event === doorLockEvents.USER_UNLOCKED) {
                                 eventFound = true;
@@ -287,7 +333,7 @@ const getLockEntryForReservation = (reservation, nextReservation) => {
             resourceId,
         };
 
-        const order = [['timestamp', 'ASC']];
+        const order = [['timestamp', 'DESC']];
 
         db.doorLockEvent.findAll({
             attributes,
@@ -295,47 +341,31 @@ const getLockEntryForReservation = (reservation, nextReservation) => {
             order,
         })
             .then((entries) => {
-                let candidateLockEntry = null;
-                let pairedUnlockEntry = null;
-                let eventFound = false;
 
-                const entriesAfterReservationEnd = entries.filter((entry) => moment.utc(entry.timestamp).isAfter(reservation.end));
+                const entriesBeforeReservationEnd = entries.filter(entry => moment.utc(entry.timestamp).isBefore(reservation.end));
 
-                entriesAfterReservationEnd.forEach((entry) => {
+                if (entriesBeforeReservationEnd.length > 0){
-                    if (!eventFound) {
+                    const lastEntryInReservationTime = entriesBeforeReservationEnd[0];
-                        if (entry.event === doorLockEvents.USER_LOCKED) {
+                    if (lastEntryInReservationTime.event === doorLockEvents.USER_LOCKED){
-                            if (pairedUnlockEntry) {
+                        resolve(lastEntryInReservationTime);
-                                pairedUnlockEntry = null;
+                        return;
-                                candidateLockEntry = null;
-                            } else {
-                                candidateLockEntry = entry;
-                                eventFound = true;
-                            }
-                        }
-                        if (entry.event === doorLockEvents.USER_UNLOCKED){
-                            pairedUnlockEntry = entry;
-                        }
                     }
-                });
-
-                if (eventFound){
-                    resolve(candidateLockEntry);
-                } else {
-                    candidateLockEntry = null;
-                    const numberOfEntriesLeft = entries.length - entriesAfterReservationEnd.length;
-                    const entriesBeforeReservationEnd = entries.slice(0, numberOfEntriesLeft);
-
-                    entriesBeforeReservationEnd.reverse().forEach((entry) => {
-                        if (!eventFound) {
-                            if (entry.event === doorLockEvents.USER_LOCKED) {
-                                eventFound = true;
-                                candidateLockEntry = entry;
-                            }
-                        }
-                    });
-
-                    resolve(candidateLockEntry);
                 }
+
+
+
+                // Phase 2
+                const numberOfEntriesLeft = entries.length - entriesBeforeReservationEnd.length;
+                const entriesAfterReservationEnd = entries.slice(0, numberOfEntriesLeft).reverse();
+                if (entriesAfterReservationEnd.length > 0){
+                    const firstEntryAfterReservation = entriesAfterReservationEnd[0];
+                    if (firstEntryAfterReservation.event === doorLockEvents.USER_LOCKED){
+                        resolve(firstEntryAfterReservation);
+                        return;
+                    }
+                }
+
+                resolve(null);
             })
             .catch((error) => reject(error));
     });
@@ -343,7 +373,7 @@ const getLockEntryForReservation = (reservation, nextReservation) => {
 
 const getEntriesBetween = (fromTimestamp, toTimestamp, resourceId) => {
     return new Promise((resolve, reject) => {
-        if (!fromTimestamp || !toTimestamp || !resourceId){
+        if (!resourceId){
             resolve([]);
         }else {
             const andTimestampFilters = [];
@@ -395,11 +425,25 @@ const getLastEntryForReservation = (reservation) => {
                 const order = [['timestamp', 'DESC']];
 
                 db.doorLockEvent.findAll({where: filters, order})
-                    .then((entries) => {
+                    .then(async(entries) => {
                         if (entries && entries.length > 0){
                             resolve(entries[0]);
                         } else {
-                            resolve (undefined);
+                            //No entry found in this block of reservations, now check if there is unlock entry for the first reservation in block, before reservation start time
+
+                            try {
+                                const firstPreviousBookingBeforeFirstInBlock = await getFirstPreviousBooking(firstReservationInBlock);
+                                const unlockEntryForFirstInBlock = await getUnlockEntryForReservation(firstReservationInBlock, firstPreviousBookingBeforeFirstInBlock);
+
+                                if (unlockEntryForFirstInBlock){
+                                    resolve(unlockEntryForFirstInBlock);
+                                }else{
+                                    resolve(undefined);
+                                }
+
+                            }catch (e) {
+                                reject(e);
+                            }
                         }
                     })
                     .catch((error) => reject(error));

services/integration/bookingChangeCharges.js

@@ -146,7 +146,7 @@ const getIncidentsFromChanges = (changes) => {
                                         reservationsForAdditionalCheck.push(reservationId);
                                     }
                                 } else {
-                                    console.log('\t\tNo');
+                                    // console.log('\t\tNo');
                                     // Reservation moved to another day
                                     // Add cancellation charge
                                     const chargeFee = oldReservationLength * reservationHourlyRate * BOOKING_CHANGE_PERCENTAGE_CHARGE / 100;
@@ -274,6 +274,31 @@ const deleteBookingChangeIncidents = (incidents) => {
     return Promise.all(asyncActions);
 };
 
+const deleteBookingChangeIncidentsById = (incidentIds) => {
+    const filters = {
+        id: {
+            [Op.in]: incidentIds
+        }
+    };
+    return db.bookingChangeIncident.update({deleted: true},{where: filters});
+};
+
+const updateBookingChangeIncidentsById = (incidentFees) => {
+    const incidentIds = Object.keys(incidentFees);
+
+    const asyncUpdateActions = [];
+
+    incidentIds.forEach((incidentId) => {
+        const newFeeCharge = parseFloat(incidentFees[incidentId]);
+
+        if (newFeeCharge || (newFeeCharge === 0)){
+            asyncUpdateActions.push(db.bookingChangeIncident.update({chargeFee: newFeeCharge}, {where: {id: incidentId}}));
+        }
+    });
+
+    return Promise.all(asyncUpdateActions);
+};
+
 module.exports = {
     getChargedCanceledReservations,
     getIncidentsFromChanges,
@@ -281,4 +306,6 @@ module.exports = {
     getShorteningIncidentsForReservationId,
     getReservationsIncidentsForRemoval,
     deleteBookingChangeIncidents,
+    deleteBookingChangeIncidentsById,
+    updateBookingChangeIncidentsById
 };

services/integration/bookings.js

@@ -88,7 +88,24 @@ const getAllBookingsForMembersInDateRange = (dateRange, memberIds) => {
     });
 };
 
+const deleteBookingsRemovedFromORD = (reservationIds) => {
+    if (!Array.isArray(reservationIds)){
+        return 0;
+    }
+
+    const filter = {
+        reservationId: {
+            [Op.notIn]: reservationIds
+        }
+    };
+
+    return db.bookingReservation.destroy({
+        where: filter
+    });
+};
+
 module.exports = {
     getActiveBookingsForMembersInDateRange,
     getAllBookingsForMembersInDateRange,
+    deleteBookingsRemovedFromORD
 };

services/integration/checkBookingChange.js

@@ -3,6 +3,7 @@
 const { fetchAllBookings, bulkWriteReservationsWithChangesTracking } = require('../officeRnD/bookings');
 const { fetchResources } = require('../officeRnD/resources');
 const { fetchRates } = require('../officeRnD/rates');
+const { deleteBookingsRemovedFromORD } = require('./bookings');
 const { officeRnDAPIErrors } = require('../../constants/constants');
 const {
     getIncidentsFromChanges,
@@ -23,23 +24,38 @@ const checkBookingChanges = () => {
 
                 const ratesMap = {};
                 rates.forEach(rate => {
-                    const { rateId, price } = rate;
+                    const { rateId, price, weekendPrice } = rate;
-                    ratesMap[rateId] = price;
+                    ratesMap[rateId] = {
+                        price,
+                        weekendPrice
+                    };
                 });
 
                 const resourcesMap = {};
                 resources.forEach(resource => {
                     const { resourceId, rate } = resource;
-                    resource.price = ratesMap[rate] || 0;
+                    resource.price = ratesMap[rate] || {price: 0, weekendPrice: 0};
                     resourcesMap[resourceId] = resource;
                 });
 
-                bulkWriteReservationsWithChangesTracking(reservations, resourcesMap)
+                const reservationsInORD = [];
-                    .then((changes) => {
+                reservations.forEach(reservation => {
+                    const { reservationId } = reservation;
+                    reservationsInORD.push(reservationId);
+                });
+
+                const asyncActions = [deleteBookingsRemovedFromORD(reservationsInORD), bulkWriteReservationsWithChangesTracking(reservations, resourcesMap)];
+
+                Promise.all(asyncActions)
+                    .then((asyncActionResults) => {
+                        const changes = asyncActionResults[1];
+                        // console.log(changes);
                         bulkWriteChanges(changes)
                             .then(() => {
                                 getIncidentsFromChanges(changes)
                                     .then(({incidents, reservationsForAdditionalCheck}) => {
+                                        // console.log('=====INCIDENTS=====');
+                                        // console.log(incidents);
                                         bulkWriteBookingChangeIncidents(incidents)
                                             .then(() => {
                                                 getReservationsIncidentsForRemoval(reservationsForAdditionalCheck)

services/integration/doorLockCharges.js

@@ -2,6 +2,7 @@
 
 const moment = require('moment-timezone');
 const db = require('../../models/index');
+const Op = require('sequelize').Op;
 
 const {
     doorLockEvents,
@@ -9,16 +10,18 @@ const {
     unlockedIncidentLevelsPrices,
     UNSCHEDULED_CHARGE_PRICE,
     MAX_BACK_TO_BACK_DIFFERENCE,
+    UNSCHEDULED_USE_INITIAL_TIME_SEGMENT_LENGTH,
     UNSCHEDULED_TIME_RESOLUTION,
     UI_TIMEZONE
 } = require('../../constants/constants');
 const { getUnlockEntryForReservation, getLockEntryForReservation, getEntriesBetween, getLastEntryForReservation } = require('../doorLock/doorLock');
-const { getAllFinishedBookings, getFirstPreviousBooking, getFirstNextBooking } = require('../officeRnD/bookings');
+const { getAllFinishedBookings, getFirstPreviousBooking, getFirstNextBooking, getLastReservationInBlock } = require('../officeRnD/bookings');
 
 const getSortedIncidentsForMember = (memberId) => {
     const attributes = ['bookingStart', 'incidentLevel', 'incidentLevelPrice', 'unlockTimestamp'];
     const filters = {
-        memberId
+        memberId,
+        deleted: false
     };
     const order = [['unlockTimestamp', 'DESC']];
 
@@ -48,6 +51,7 @@ const insertUnscheduledIncidents = (incidents) => {
             totalChargeFee,
             unlockTimestamp,
             lockTimestamp,
+            deleted: false
         };
 
         asyncJobs.push(db.unscheduledIncident.findOrCreate({
@@ -67,6 +71,35 @@ const insertUnscheduledIncidents = (incidents) => {
     return Promise.all(asyncJobs);
 };
 
+const deleteUnscheduledIncidentsById = (incidentIds) => {
+    const filters = {
+        id: {
+            [Op.in]: incidentIds
+        }
+    };
+    return db.unscheduledIncident.update({deleted: true},{where: filters});
+};
+
+const updateUnscheduledIncidentsById = (incidentFees) => {
+    const incidentIds = Object.keys(incidentFees);
+
+    const asyncUpdateActions = [];
+
+    incidentIds.forEach((incidentId) => {
+        const newFeeCharge = parseFloat(incidentFees[incidentId]);
+
+        if (newFeeCharge || (newFeeCharge === 0)){
+            asyncUpdateActions.push(db.unscheduledIncident.update({
+                totalChargeFee: newFeeCharge,
+                chargePrice: newFeeCharge,
+                timeIntervalsToCharge: 1
+            }, {where: {id: incidentId}}));
+        }
+    });
+
+    return Promise.all(asyncUpdateActions);
+};
+
 const insertUnlockedIncidents = (incidents) => {
     const asyncJobs = [];
     incidents.forEach((incident) => {
@@ -82,6 +115,7 @@ const insertUnlockedIncidents = (incidents) => {
             unlockTimestamp,
             incidentLevel,
             incidentLevelPrice,
+            deleted: false
         };
 
         asyncJobs.push(db.unlockedIncident.findOrCreate({
@@ -92,7 +126,6 @@ const insertUnlockedIncidents = (incidents) => {
                 bookingStart: start,
                 bookingEnd: end,
                 unlockTimestamp,
-                incidentLevel,
             },
             defaults: {...incidentForDB},
         }));
@@ -101,6 +134,31 @@ const insertUnlockedIncidents = (incidents) => {
     return Promise.all(asyncJobs);
 };
 
+const deleteUnlockedIncidentsById = (incidentIds) => {
+    const filters = {
+        id: {
+            [Op.in]: incidentIds
+        }
+    };
+    return db.unlockedIncident.update({deleted: true},{where: filters});
+};
+
+const updateUnlockedIncidentsById = (incidentFees) => {
+    const incidentIds = Object.keys(incidentFees);
+
+    const asyncUpdateActions = [];
+
+    incidentIds.forEach((incidentId) => {
+       const newFeeCharge = parseFloat(incidentFees[incidentId]);
+
+       if (newFeeCharge || (newFeeCharge === 0)){
+           asyncUpdateActions.push(db.unlockedIncident.update({incidentLevelPrice: newFeeCharge}, {where: {id: incidentId}}));
+       }
+    });
+
+    return Promise.all(asyncUpdateActions);
+};
+
 const setUnlockedIncidentsLevel = (incidents) => {
     return new Promise ((resolve, reject) => {
         const sortingFunction = (incidentA, incidentB) => {
@@ -139,7 +197,7 @@ const setUnlockedIncidentsLevel = (incidents) => {
                 const incidentsWithLevel = [];
 
                 incidents.forEach((incident) => {
-                    const memberLastIncident = membersLastIncident[incident.memberId];
+                    const memberLastIncident = Object.assign({}, membersLastIncident[incident.memberId]);
 
                     const formattedIncident = {
                         reservation: incident.reservation,
@@ -154,8 +212,8 @@ const setUnlockedIncidentsLevel = (incidents) => {
                         formattedIncident.incidentLevel = unlockedIncidentLevelsPrices.UNLOCKED_0.title;
                         formattedIncident.incidentLevelPrice = unlockedIncidentLevelsPrices.UNLOCKED_0.price;
                     } else {
-                        const lastIncidentTime = moment.utc(memberLastIncident.incidentTimestamp).startOf('month');
+                        const lastIncidentTime = moment.tz(memberLastIncident.incidentTimestamp, UI_TIMEZONE).startOf('month');
-                        const currentIncidentTime = moment.utc(incident.unlockTimestamp).startOf('month');
+                        const currentIncidentTime = moment.tz(incident.unlockTimestamp, UI_TIMEZONE).startOf('month');
                         const timeDiff = Math.abs(lastIncidentTime.diff(currentIncidentTime, 'months'));
 
                         if (timeDiff >= (parseInt(process.env.UNLOCK_STREAK_REPAIR_AFTER) || 6)){
@@ -215,7 +273,7 @@ const analyseReservation = (reservation) => {
                             const previousReservationEnd = moment.utc(previousReservation.end);
                             timeDifferenceFromPreviousReservation = currentReservationStart.diff(previousReservationEnd, 'minutes');
                         }
-                        const previousReservationIsBackToBack = timeDifferenceFromPreviousReservation < MAX_BACK_TO_BACK_DIFFERENCE;
+                        const previousReservationIsBackToBack = timeDifferenceFromPreviousReservation <= MAX_BACK_TO_BACK_DIFFERENCE;
 
 
                         let timeDifferenceBeforeNextReservation = MAX_BACK_TO_BACK_DIFFERENCE + 100;
@@ -223,14 +281,17 @@ const analyseReservation = (reservation) => {
                             const nextReservationStart = moment.utc(nextReservation.start);
                             timeDifferenceBeforeNextReservation = nextReservationStart.diff(currentReservationEnd, 'minutes');
                         }
-                        const nextReservationIsBackToBack = timeDifferenceBeforeNextReservation < MAX_BACK_TO_BACK_DIFFERENCE;
+                        const nextReservationIsBackToBack = timeDifferenceBeforeNextReservation <= MAX_BACK_TO_BACK_DIFFERENCE;
 
                         let timeDifferenceFromUnlockEntry = 0;
                         if (unlockEntry) {
                             const unlockTime = moment.utc(unlockEntry.timestamp);
                             timeDifferenceFromUnlockEntry = currentReservationStart.diff(unlockTime, 'minutes');
                         }
-                        const timeIntervalsToChargeBefore = Math.floor(timeDifferenceFromUnlockEntry / UNSCHEDULED_TIME_RESOLUTION);
+
+                        let timeIntervalsToChargeBefore = Math.floor(timeDifferenceFromUnlockEntry / UNSCHEDULED_TIME_RESOLUTION);
+                        timeIntervalsToChargeBefore -= 1; // Remove first N minutes, N = UNSCHEDULED_TIME_RESOLUTION
+
                         const totalChargeFeeBefore = timeIntervalsToChargeBefore * UNSCHEDULED_CHARGE_PRICE;
                         const chargeBefore = totalChargeFeeBefore > 0;
 
@@ -239,10 +300,54 @@ const analyseReservation = (reservation) => {
                             const lockTime = moment.utc(lockEntry.timestamp);
                             timeDifferenceFromLockEntry = lockTime.diff(currentReservationEnd, 'minutes');
                         }
-                        const timeIntervalsToChargeAfter = Math.floor(timeDifferenceFromLockEntry / UNSCHEDULED_TIME_RESOLUTION);
+                        let timeIntervalsToChargeAfter = Math.floor(timeDifferenceFromLockEntry / UNSCHEDULED_TIME_RESOLUTION);
+                        timeIntervalsToChargeAfter -= 1; // Remove first N minutes, N = UNSCHEDULED_TIME_RESOLUTION
+
                         const totalChargeFeeAfter = timeIntervalsToChargeAfter * UNSCHEDULED_CHARGE_PRICE;
                         const chargeAfter = totalChargeFeeAfter > 0;
 
+                        // const reservationMoment = moment.tz(reservation.start, reservation.timezone);
+                        // if (reservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-11-21 00:00:16+00')) {
+                        //     console.log('\r\n\r\n==== ANALYSE RESERVATION ==== ');
+                        //     console.log('\tStart : ', reservationMoment.format('DD.MM, HH:mm'));
+                        //     console.log('\tEnd   : ', moment.tz(reservation.end, reservation.timezone).format('DD.MM, HH:mm'));
+                        //     console.log('\t----------------------------------');
+                        //     console.log('\tFirst previous reservation : ');
+                        //     if (previousReservation) {
+                        //         console.log('\t\tStart : ', moment.tz(previousReservation.start, previousReservation.timezone).format('DD.MM, HH:mm'));
+                        //         console.log('\t\tEnd   : ', moment.tz(previousReservation.end, previousReservation.timezone).format('DD.MM, HH:mm'));
+                        //     } else {
+                        //         console.log('\t\tNO PREVIOUS RESERVATION');
+                        //     }
+                        //
+                        //     console.log('\tFirst next reservation : ');
+                        //     if (nextReservation) {
+                        //         console.log('\t\tStart : ', moment.tz(nextReservation.start, nextReservation.timezone).format('DD.MM, HH:mm'));
+                        //         console.log('\t\tEnd   : ', moment.tz(nextReservation.end, nextReservation.timezone).format('DD.MM, HH:mm'));
+                        //     } else {
+                        //         console.log('\t\tNO NEXT RESERVATION');
+                        //     }
+                        //     console.log('\t----------------------------------');
+                        //     if (unlockEntry) {
+                        //         console.log('\tUnlock entry : ', moment.tz(unlockEntry.timestamp, reservation.timezone).format('DD.MM, HH:mm'));
+                        //     } else {
+                        //         console.log('\tUnlock entry : NO UNLOCK ENTRY');
+                        //     }
+                        //     if (lockEntry) {
+                        //         console.log('\tLock entry : ', moment.tz(lockEntry.timestamp, reservation.timezone).format('DD.MM, HH:mm'));
+                        //     } else {
+                        //         console.log('\tLock entry : NO LOCK ENTRY');
+                        //     }
+                        //
+                        //     console.log('\t----------------------------------');
+                        //     console.log('\tTime before : ');
+                        //     console.log('\t\tOriginal : ', timeDifferenceFromUnlockEntry);
+                        //     console.log('\t\tModified : ', timeIntervalsToChargeBefore);
+                        //     console.log('\tTime after : ');
+                        //     console.log('\t\tOriginal : ', timeDifferenceFromLockEntry);
+                        //     console.log('\t\tModified : ', timeIntervalsToChargeAfter);
+                        // }
+
                         const result = {
                             currentReservation: reservation,
                             previousReservation,
@@ -295,135 +400,61 @@ const getIncidentData = (reservation) => {
                     timeIntervalsToChargeAfter,
                 } = result;
                 const incidents = [];
-                const incidentsAsyncJobs = [];
                 const { resourceId } = currentReservation;
 
-                // 0a. Check for unscheduled use between current and previous reservation
+                // const reservationMoment = moment.tz(currentReservation.start, currentReservation.timezone);
-                const analysePreviousJob = [];
+                // if (currentReservation.memberId === '5d240cd34a3efa00882d9526') {
-                if (previousReservation && !previousReservationIsBackToBack){
+                //     console.log('\r\n\r\n==== ANALYSE RESERVATION [GET INCIDENT DATA] ==== ');
-                    analysePreviousJob.push(analyseReservation(previousReservation));
+                //     console.log('\tStart : ', reservationMoment.format('DD.MM, HH:mm'));
-                }else {
+                //     console.log('\tEnd   : ', moment.tz(currentReservation.end, currentReservation.timezone).format('DD.MM, HH:mm'));
-                    analysePreviousJob.push(undefined);
+                //     console.log('\t----------------------------------');
-                }
+                //     console.log('\tFirst previous reservation : is back to back [', previousReservationIsBackToBack ? 'T' : 'F' , ']');
+                //     if (previousReservation) {
+                //         console.log('\t\tStart : ', moment.tz(previousReservation.start, previousReservation.timezone).format('DD.MM, HH:mm'));
+                //         console.log('\t\tEnd   : ', moment.tz(previousReservation.end, previousReservation.timezone).format('DD.MM, HH:mm'));
+                //     } else {
+                //         console.log('\t\tNO PREVIOUS RESERVATION');
+                //     }
+                //
+                //     console.log('\tFirst next reservation : is back to back [', nextReservationIsBackToBack ? 'T' : 'F', ']');
+                //     if (nextReservation) {
+                //         console.log('\t\tStart : ', moment.tz(nextReservation.start, nextReservation.timezone).format('DD.MM, HH:mm'));
+                //         console.log('\t\tEnd   : ', moment.tz(nextReservation.end, nextReservation.timezone).format('DD.MM, HH:mm'));
+                //     } else {
+                //         console.log('\t\tNO NEXT RESERVATION');
+                //     }
+                //     console.log('\t----------------------------------');
+                //     if (unlockEntry) {
+                //         console.log('\tUnlock entry : ', moment.tz(unlockEntry.timestamp, reservation.timezone).format('DD.MM, HH:mm'));
+                //     } else {
+                //         console.log('\tUnlock entry : NO UNLOCK ENTRY');
+                //     }
+                //     if (lockEntry) {
+                //         console.log('\tLock entry : ', moment.tz(lockEntry.timestamp, reservation.timezone).format('DD.MM, HH:mm'));
+                //     } else {
+                //         console.log('\tLock entry : NO LOCK ENTRY');
+                //     }
+                // }
 
-                incidentsAsyncJobs.push(
+                //**********************
-                Promise.all(analysePreviousJob)
-                    .then(([previousReservationResults]) => {
-                        let fromTimestamp;
-                        let toTimestamp;
 
-                        if (previousReservationResults){
+                const emptyReservation = {
-                            const previousReservationLockEntry = previousReservationResults.lockEntry;
+                    reservationId: null,
-
+                    start: null,
-                            fromTimestamp = previousReservationLockEntry && previousReservationLockEntry.timestamp ?
+                    end: null,
-                                previousReservationLockEntry.timestamp : previousReservation.end;
+                };
-                            toTimestamp = unlockEntry && unlockEntry.timestamp ?
-                                unlockEntry.timestamp : reservation.start;
-                        }else{
-                            fromTimestamp = undefined;
-                            toTimestamp = unlockEntry && unlockEntry.timestamp ?
-                                unlockEntry.timestamp : reservation.start;
-                        }
-
-                        incidentsAsyncJobs.push(
-                        getEntriesBetween(fromTimestamp, toTimestamp, resourceId)
-                            .then((entriesBetween) => {
-                                incidentsAsyncJobs.push(
-                                    new Promise((resolve, reject) => {
-                                        let pairUnlockEntry = null;
-                                        let pairLockEntry = null;
-
-                                        entriesBetween.forEach((entry) => {
-                                            if (entry && entry.event){
-                                                switch(entry.event){
-                                                    case doorLockEvents.USER_UNLOCKED:
-                                                        if (!pairUnlockEntry){
-                                                            pairUnlockEntry = entry;
-                                                        }else{
-                                                            const emptyReservation = {
-                                                                reservationId: null,
-                                                                start: null,
-                                                                end: null,
-                                                            };
-
-                                                            incidents.push({
-                                                                incidentType: incidentType.UNLOCKED_INCIDENT_STANDALONE,
-                                                                reservation: emptyReservation,
-                                                                unlockTimestamp: pairUnlockEntry.timestamp,
-                                                                memberId: pairUnlockEntry.memberId,
-                                                                resourceId,
-                                                            });
-
-                                                            pairLockEntry = null;
-                                                            pairUnlockEntry = entry;
-                                                        }
-                                                        break;
-                                                    case doorLockEvents.USER_LOCKED:
-                                                        if (pairUnlockEntry && !pairLockEntry){
-                                                            pairLockEntry = entry;
-                                                            const emptyReservation = {
-                                                                reservationId: null,
-                                                                start: null,
-                                                                end: null,
-                                                            };
-                                                            const unlockMoment = moment.utc(pairUnlockEntry.timestamp);
-                                                            const lockMoment = moment.utc(pairLockEntry.timestamp);
-
-                                                            if (lockMoment.tz(UI_TIMEZONE).isSame(unlockMoment.tz(UI_TIMEZONE), 'day')){
-                                                                const timeDifference = lockMoment.diff(unlockMoment, 'minutes');
-                                                                const timeIntervalsToCharge = Math.floor(timeDifference / UNSCHEDULED_TIME_RESOLUTION);
-                                                                const totalChargeFee = timeIntervalsToCharge * UNSCHEDULED_CHARGE_PRICE;
-                                                                if (timeIntervalsToCharge > 0){
-                                                                    incidents.push({
-                                                                        incidentType: incidentType.UNSCHEDULED_INCIDENT_STANDALONE,
-                                                                        reservation: emptyReservation,
-                                                                        unlockTimestamp: pairUnlockEntry.timestamp,
-                                                                        lockTimestamp: pairLockEntry.timestamp,
-                                                                        memberId: pairUnlockEntry.memberId,
-                                                                        resourceId,
-                                                                        chargePrice: UNSCHEDULED_CHARGE_PRICE,
-                                                                        timeIntervalsToCharge,
-                                                                        totalChargeFee,
-                                                                    });
-                                                                }
-                                                            }else{
-                                                                const emptyReservation = {
-                                                                    reservationId: null,
-                                                                    start: null,
-                                                                    end: null,
-                                                                };
-
-                                                                incidents.push({
-                                                                    incidentType: incidentType.UNLOCKED_INCIDENT_STANDALONE,
-                                                                    reservation: emptyReservation,
-                                                                    unlockTimestamp: pairUnlockEntry.timestamp,
-                                                                    memberId: pairUnlockEntry.memberId,
-                                                                    resourceId,
-                                                                });
-                                                            }
-
-                                                            pairUnlockEntry = null;
-                                                            pairLockEntry = null;
-                                                        }else{
-                                                            if (!pairUnlockEntry){
-                                                                pairLockEntry = entry;
-                                                                //Only lock entry, ignore now
-                                                            }
-                                                            pairLockEntry = null;
-                                                            pairUnlockEntry = null;
-                                                        }
-                                                }
-                                            }
-                                        });
-                                        resolve(null);
-                                }));
-                            })
-                            .catch((error) => reject(error)));
-                    })
-                    .catch((error) => reject(error)));
 
                 // 1. Check if member entered before reservation start time
+                // if (currentReservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-12-01 00:00:16+00')) {
+                //     console.log('\r\n\r\nChecking if member entered before reservation start time :');
+                //     console.log('\tunlockEntry          : ', unlockEntry && unlockEntry.timestamp ? unlockEntry.timestamp : 'NO UNLOCK ENTRY');
+                //     console.log('\tCharge before        : ', chargeBefore);
+                //     console.log('\tThere is prev. res   : ', previousReservationIsBackToBack);
+                // }
                 if (unlockEntry && chargeBefore && !previousReservationIsBackToBack) {
+                    // if (currentReservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-12-01 00:00:16+00')) {
+                    //     console.log('\tIncident : YES');
+                    // }
                     incidents.push({
                         incidentType: incidentType.UNSCHEDULED_INCIDENT_BEFORE_RESERVATION,
                         reservation,
@@ -435,10 +466,23 @@ const getIncidentData = (reservation) => {
                         timeIntervalsToCharge: timeIntervalsToChargeBefore,
                         totalChargeFee: totalChargeFeeBefore,
                     });
+                }else{
+                    // if (currentReservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-12-01 00:00:16+00')) {
+                    //     console.log('\tIncident : NO');
+                    // }
                 }
 
                 // 2. Check if member left after reservation end time
+                // if (currentReservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-12-01 00:00:16+00')) {
+                //     console.log('\r\n\r\nChecking if member left after reservation end time :');
+                //     console.log('\tlockEntry            : ', lockEntry && lockEntry.timestamp ? lockEntry.timestamp : 'NO LOCK ENTRY');
+                //     console.log('\tCharge after         : ', chargeAfter);
+                //     console.log('\tThere is res after   : ', nextReservationIsBackToBack);
+                // }
                 if (lockEntry && chargeAfter && !nextReservationIsBackToBack) {
+                    // if (currentReservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-12-01 00:00:16+00')) {
+                    //     console.log('\tIncident : YES');
+                    // }
                     incidents.push({
                         incidentType: incidentType.UNSCHEDULED_INCIDENT_AFTER_RESERVATION,
                         reservation,
@@ -450,18 +494,108 @@ const getIncidentData = (reservation) => {
                         timeIntervalsToCharge: timeIntervalsToChargeAfter,
                         totalChargeFee: totalChargeFeeAfter,
                     });
+                }else{
+                    // if (currentReservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-12-01 00:00:16+00')) {
+                    //     console.log('\tIncident : NO');
+                    // }
                 }
 
                 // 3. Check if member forgot to lock the door
+                // if (currentReservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-12-01 00:00:16+00')) {
+                //     console.log('\r\n\r\nChecking if member left unlocked door :');
+                //     console.log('\tunlockEntry        : ', unlockEntry && unlockEntry.timestamp ? unlockEntry.timestamp : 'NO UNLOCK ENTRY');
+                //     console.log('\tlockEntry          : ', lockEntry && lockEntry.timestamp ? lockEntry.timestamp : 'NO LOCK ENTRY');
+                //     console.log('\tThere is res before: ', previousReservationIsBackToBack);
+                //     console.log('\tThere is res after : ', nextReservationIsBackToBack);
+                // }
+                let forgotToLockAsyncCheck;
+                let asyncUnscheduledUseTest = [];
                 if (!lockEntry && !nextReservationIsBackToBack){
-                    const emptyReservation = {
+
-                        reservationId: null,
+                    // Special check
-                        start: null,
+
-                        end: null,
+                    const checkForUnscheduledUseInBrakeBetweenReservations = async () => {
+                        try {
+                            if (nextReservation) {
+                                const lastReservationInBlockAfterBrake = await getLastReservationInBlock(nextReservation);
+
+                                const fromTimestamp = nextReservation.start;
+                                const toTimestamp = lastReservationInBlockAfterBrake.end;
+
+                                const entriesInBlock = await getEntriesBetween(fromTimestamp, toTimestamp, reservation.resourceId);
+
+                                // const reservationMoment = moment.tz(reservation.start, reservation.timezone);
+                                // if (reservation.memberId === '5d240cd34a3efa00882d9526') {
+                                //     console.log('\r\n\r\n==== ANALYSE RESERVATION [GET INCIDENT DATA] ==== ');
+                                //     console.log('\tStart : ', reservationMoment.format('DD.MM, HH:mm'));
+                                //     console.log('\tEnd   : ', moment.tz(reservation.end, reservation.timezone).format('DD.MM, HH:mm'));
+                                //     console.log('\t----------------------------------');
+                                //     console.log('\tLast reservation in block after brake :');
+                                //     console.log('\t\tStart : ', moment.tz(lastReservationInBlockAfterBrake.start, UI_TIMEZONE).format('DD.MM, HH:mm'));
+                                //     console.log('\t\tEnd   : ', moment.tz(lastReservationInBlockAfterBrake.end, UI_TIMEZONE).format('DD.MM, HH:mm'));
+                                //     console.log('\tSearch entries : ');
+                                //     console.log('\t\tFrom :', moment.tz(fromTimestamp, UI_TIMEZONE).format('DD.MM, HH:mm'));
+                                //     console.log('\t\tTo   :', moment.tz(toTimestamp, UI_TIMEZONE).format('DD.MM, HH:mm'));
+                                //     console.log('\tFirst entry : ');
+                                // }
+
+                                const addStandaloneUnscheduledIncident = () => {
+
+                                    const unlockMoment = reservation.end ? moment.utc(reservation.end) : null;
+                                    const lockMoment = nextReservation.start ? moment.utc(nextReservation.start) : null;
+
+                                    if (unlockMoment && lockMoment) {
+                                        const timeDifference = lockMoment.diff(unlockMoment, 'minutes');
+                                        const timeIntervalsToCharge = Math.floor(timeDifference / UNSCHEDULED_TIME_RESOLUTION);
+                                        const totalChargeFee = timeIntervalsToCharge * UNSCHEDULED_CHARGE_PRICE;
+                                        if (timeIntervalsToCharge > 0) {
+                                            incidents.push({
+                                                incidentType: incidentType.UNSCHEDULED_INCIDENT_STANDALONE,
+                                                reservation: emptyReservation,
+                                                unlockTimestamp: reservation.end,
+                                                lockTimestamp: nextReservation.start,
+                                                memberId: reservation.memberId,
+                                                resourceId: reservation.resourceId,
+                                                chargePrice: UNSCHEDULED_CHARGE_PRICE,
+                                                timeIntervalsToCharge,
+                                                totalChargeFee,
+                                            });
+                                        }
+                                    }
+                                };
+
+                                if (Array.isArray(entriesInBlock) && entriesInBlock.length > 0) {
+                                    const firstEntry = entriesInBlock[0];
+                                    // console.log('\t\tTimestamp : ', moment.tz(firstEntry.timestamp, UI_TIMEZONE).format('DD.MM, HH:mm'));
+                                    // console.log('\t\tEvent     : ', firstEntry.event);
+                                    if (firstEntry && firstEntry.event &&
+                                        firstEntry.memberId === reservation.memberId &&
+                                        firstEntry.event === doorLockEvents.USER_LOCKED) {
+
+                                        addStandaloneUnscheduledIncident();
+                                    }
+                                } else {
+                                    const reservationAfterLastReservationInBlock = await getFirstNextBooking(nextReservation);
+
+                                    if (reservationAfterLastReservationInBlock) {
+                                        const lastReservationLockEntry = await getLockEntryForReservation(lastReservationInBlockAfterBrake, reservationAfterLastReservationInBlock);
+                                        if (lastReservationLockEntry) {
+                                            addStandaloneUnscheduledIncident();
+                                        }
+                                    }
+                                }
+                            }
+                        }catch (e) {
+                            console.log('ERROR while checking for unscheduled use in brake between reservations ');
+                            console.log(e);
+                        }
                     };
 
-                    if (unlockEntry){
 
+                    if (unlockEntry){
+                        // if (currentReservation.memberId === '5ce785af422bdd00967fb781' && reservationMoment.isAfter('2019-12-01 00:00:16+00')) {
+                        //     console.log('\tIncident : YES [#1]');
+                        // }
                         incidents.push({
                             incidentType: incidentType.UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION,
                             unlockTimestamp: unlockEntry.timestamp,
@@ -469,6 +603,8 @@ const getIncidentData = (reservation) => {
                             resourceId: unlockEntry.resourceId,
                             reservation: reservation && reservation.dataValues ? reservation.dataValues : emptyReservation,
                         });
+
+                        asyncUnscheduledUseTest.push(checkForUnscheduledUseInBrakeBetweenReservations());
                     } else {
                         // No lock entry, no unlock entry and no reservation after this one
                         // This is either :
@@ -480,29 +616,203 @@ const getIncidentData = (reservation) => {
                         if (previousReservationIsBackToBack){
                             // To ensure that this is last reservation in block (there is previous but no next reservation back to back)
                             // Now, just check if member actually locked before in the reservation time
-                            incidentsAsyncJobs.push(
+
-                            getLastEntryForReservation(reservation)
+                            forgotToLockAsyncCheck = getLastEntryForReservation(reservation);
+                            forgotToLockAsyncCheck
                                 .then((lastEntry) => {
-                                    if (lastEntry && lastEntry.event === doorLockEvents.USER_UNLOCKED){
+                                    if (lastEntry) {
-                                        incidents.push({
+                                        if (lastEntry && lastEntry.event === doorLockEvents.USER_UNLOCKED) {
-                                            incidentType: incidentType.UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION,
+                                            incidents.push({
-                                            unlockTimestamp: lastEntry.timestamp,
+                                                incidentType: incidentType.UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION,
-                                            memberId: lastEntry.memberId,
+                                                unlockTimestamp: lastEntry.timestamp,
-                                            resourceId: lastEntry.resourceId,
+                                                memberId: lastEntry.memberId,
-                                            reservation: reservation && reservation.dataValues ? reservation.dataValues : emptyReservation,
+                                                resourceId: lastEntry.resourceId,
-                                        });
+                                                reservation: reservation && reservation.dataValues ? reservation.dataValues : emptyReservation,
+                                            });
+
+                                            asyncUnscheduledUseTest.push(checkForUnscheduledUseInBrakeBetweenReservations());
+                                        }
                                     }
                                 })
-                                .catch((error) => reject(error)));
+                                .catch((error) => reject(error));
                         }
                     }
                 }
 
-                Promise.all(incidentsAsyncJobs)
+
-                    .then(() => {
+
-                        resolve(incidents);
+                // 4. Check for unscheduled use between current and previous reservation
+                const analysePreviousJob = [];
+                if (previousReservation && !previousReservationIsBackToBack){
+                    analysePreviousJob.push(analyseReservation(previousReservation));
+                }else {
+                    analysePreviousJob.push(undefined);
+                }
+
+                Promise.all(analysePreviousJob)
+                    .then(([previousReservationResults]) => {
+                        let fromTimestamp;
+                        let toTimestamp;
+
+                        if (previousReservationResults){
+                            const previousReservationLockEntry = previousReservationResults.lockEntry;
+                            const previousReservationUnlockEntry = previousReservationResults.unlockEntry;
+
+                            //Special check for bookings with break between
+                            // Check this for duplication, previous special check in step 3. can catch this scenario
+                            // if (previousReservation &&
+                            //     !previousReservationIsBackToBack &&
+                            //     previousReservation.memberId === currentReservation.memberId &&
+                            //     previousReservationUnlockEntry && !previousReservationLockEntry &&
+                            //     !unlockEntry && lockEntry //current reservation unlock / lock entries
+                            // ) {
+                            //
+                            //     const unlockMoment = previousReservation.end ? moment.utc(previousReservation.end) : null;
+                            //     const lockMoment = currentReservation.start ? moment.utc(currentReservation.start) : null;
+                            //
+                            //     if (unlockMoment && lockMoment){
+                            //         const timeDifference = lockMoment.diff(unlockMoment, 'minutes');
+                            //         const timeIntervalsToCharge = Math.floor(timeDifference / UNSCHEDULED_TIME_RESOLUTION);
+                            //         const totalChargeFee = timeIntervalsToCharge * UNSCHEDULED_CHARGE_PRICE;
+                            //         if (timeIntervalsToCharge > 0) {
+                            //             incidents.push({
+                            //                 incidentType: incidentType.UNSCHEDULED_INCIDENT_STANDALONE,
+                            //                 reservation: emptyReservation,
+                            //                 unlockTimestamp: previousReservation.end,
+                            //                 lockTimestamp: currentReservation.start,
+                            //                 memberId: currentReservation.memberId,
+                            //                 resourceId,
+                            //                 chargePrice: UNSCHEDULED_CHARGE_PRICE,
+                            //                 timeIntervalsToCharge,
+                            //                 totalChargeFee,
+                            //             });
+                            //         }
+                            //     }
+                            // }
+
+                            fromTimestamp = previousReservationLockEntry && previousReservationLockEntry.timestamp ?
+                                previousReservationLockEntry.timestamp : previousReservation.end;
+                            toTimestamp = unlockEntry && unlockEntry.timestamp ?
+                                unlockEntry.timestamp : reservation.start;
+                        }else{
+                            fromTimestamp = undefined;
+                            toTimestamp = unlockEntry && unlockEntry.timestamp ?
+                                unlockEntry.timestamp : reservation.start;
+                        }
+
+                        // Let's skip this if previous reservation is back-to-back
+                        let getEntriesAsyncCheck;
+                        if (previousReservation && previousReservationIsBackToBack){
+                            //Skip
+                        }else{
+                            getEntriesAsyncCheck = getEntriesBetween(fromTimestamp, toTimestamp, resourceId);
+                        }
+
+                        //Now wait for "forgotToLockAsyncCheck", and possible "getEntriesBetween" to finish
+                        Promise.all([forgotToLockAsyncCheck, getEntriesAsyncCheck, asyncUnscheduledUseTest])
+                            .then((asyncActionResults) => {
+                                const entriesBetween = asyncActionResults[1];
+                                if (Array.isArray(entriesBetween)){
+                                    let pairUnlockEntry = null;
+                                    let pairLockEntry = null;
+
+                                    //Inspect all entries and insert detected incidents
+                                    entriesBetween.forEach((entry) => {
+                                        // console.log('\tEvent : ', entry.event);
+                                        // console.log('\tEvent : ', entry.timestamp ? moment.tz(entry.timestamp, UI_TIMEZONE).format('DD.MM, HH:mm') : '-');
+                                        if (entry && entry.event){
+                                            switch(entry.event){
+                                                case doorLockEvents.USER_UNLOCKED:
+                                                    if (!pairUnlockEntry){
+                                                        pairUnlockEntry = entry;
+                                                    }else{
+                                                        incidents.push({
+                                                            incidentType: incidentType.UNLOCKED_INCIDENT_STANDALONE,
+                                                            reservation: emptyReservation,
+                                                            unlockTimestamp: pairUnlockEntry.timestamp,
+                                                            memberId: pairUnlockEntry.memberId,
+                                                            resourceId,
+                                                        });
+
+                                                        pairLockEntry = null;
+                                                        pairUnlockEntry = entry;
+                                                    }
+                                                    break;
+                                                case doorLockEvents.USER_LOCKED:
+                                                    if (pairUnlockEntry && !pairLockEntry){
+                                                        pairLockEntry = entry;
+
+                                                        const unlockMoment = moment.utc(pairUnlockEntry.timestamp);
+                                                        const lockMoment = moment.utc(pairLockEntry.timestamp);
+
+                                                        const entriesOnSameDay = lockMoment.tz(UI_TIMEZONE).isSame(unlockMoment.tz(UI_TIMEZONE), 'day');
+                                                        const sameMember = pairUnlockEntry.memberId === pairLockEntry.memberId;
+
+                                                        if ((entriesOnSameDay && !sameMember) || (!entriesOnSameDay)){
+                                                            incidents.push({
+                                                                incidentType: incidentType.UNLOCKED_INCIDENT_STANDALONE,
+                                                                reservation: emptyReservation,
+                                                                unlockTimestamp: pairUnlockEntry.timestamp,
+                                                                memberId: pairUnlockEntry.memberId,
+                                                                resourceId,
+                                                            });
+                                                        }else if (entriesOnSameDay && sameMember){
+                                                            const timeDifference = lockMoment.diff(unlockMoment, 'minutes');
+                                                            const timeIntervalsToCharge = Math.floor(timeDifference / UNSCHEDULED_TIME_RESOLUTION);
+                                                            const totalChargeFee = timeIntervalsToCharge * UNSCHEDULED_CHARGE_PRICE;
+                                                            if (timeIntervalsToCharge > 0){
+                                                                incidents.push({
+                                                                    incidentType: incidentType.UNSCHEDULED_INCIDENT_STANDALONE,
+                                                                    reservation: emptyReservation,
+                                                                    unlockTimestamp: pairUnlockEntry.timestamp,
+                                                                    lockTimestamp: pairLockEntry.timestamp,
+                                                                    memberId: pairUnlockEntry.memberId,
+                                                                    resourceId,
+                                                                    chargePrice: UNSCHEDULED_CHARGE_PRICE,
+                                                                    timeIntervalsToCharge,
+                                                                    totalChargeFee,
+                                                                });
+                                                            }
+                                                        }
+                                                        pairUnlockEntry = null;
+                                                        pairLockEntry = null;
+                                                    }else{
+                                                        pairLockEntry = null;
+                                                        pairUnlockEntry = null;
+                                                    }
+                                            }
+                                        }
+                                    });
+
+                                    if (pairUnlockEntry){
+                                        incidents.push({
+                                            incidentType: incidentType.UNLOCKED_INCIDENT_STANDALONE,
+                                            reservation: emptyReservation,
+                                            unlockTimestamp: pairUnlockEntry.timestamp,
+                                            memberId: pairUnlockEntry.memberId,
+                                            resourceId,
+                                        });
+
+                                        pairLockEntry = null;
+                                        pairUnlockEntry = null;
+                                    }
+                                }
+                                resolve(incidents);
+                            })
+                            .catch(error => reject(error));
                     })
-                    .catch((error) => reject(error));
+                    .catch(error => reject(error));
+                //
+                // Promise.all(incidentsAsyncJobs)
+                //     .then(() => {
+                //         // console.log('\tDone with Async jobs for reservation ');
+                //         // console.log('\t\tStart : ', reservationMoment.format('DD.MM, HH:mm'));
+                //         // console.log('\t\tEnd   : ', moment.tz(currentReservation.end, currentReservation.timezone).format('DD.MM, HH:mm'));
+                //
+                //         setTimeout(() => {resolve(incidents)}, 10000);
+                //         // resolve(incidents);
+                //     })
+                //     .catch((error) => reject(error));
 
             })
             .catch((error) => reject(error));
@@ -573,5 +883,9 @@ const calculateDoorLockCharges = () => {
 };
 
 module.exports = {
-    calculateDoorLockCharges
+    calculateDoorLockCharges,
+    deleteUnlockedIncidentsById,
+    deleteUnscheduledIncidentsById,
+    updateUnlockedIncidentsById,
+    updateUnscheduledIncidentsById
 };

services/integration/invoiceIntegration.js

@@ -17,6 +17,7 @@ const createFeeFromIncident = (incident) => {
             memberId,
             officeId,
             officeName,
+            officeSlug,
             resourceName,
             oldResourceName,
             newResourceName,
@@ -45,6 +46,10 @@ const createFeeFromIncident = (incident) => {
         let bookingTimeExplanation = '';
         let incidentTimeExplanation = '';
 
+        let additionalDateTimeExplanation = '';
+
+        let spacing = '';
+
         let roomExplanation = '';
         let dateExplanation = '';
 
@@ -62,7 +67,8 @@ const createFeeFromIncident = (incident) => {
 
         switch (incidentTypeNumber) {
             case incidentType.UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION:
-                roomExplanation = resourceName;
+                spacing = '   ';
+                roomExplanation = resourceName || 'Unknown';
                 dateExplanation = bookingStartMoment.clone().startOf('day').format('MMM DD');
                 bookingTimeExplanation = `[${bookingStartMoment.clone().format('HH:mm')} to ${bookingEndMoment.clone().format('HH:mm')}]`;
                 incidentTimeExplanation = `unlock : ${unlockMoment.clone().format('HH:mm')}`;
@@ -74,7 +80,8 @@ const createFeeFromIncident = (incident) => {
                 quantity = 1.00;
                 break;
             case incidentType.UNSCHEDULED_INCIDENT_BEFORE_RESERVATION:
-                roomExplanation = resourceName;
+                spacing = ' ';
+                roomExplanation = resourceName || 'Unknown';
                 dateExplanation = bookingStartMoment.clone().startOf('day').format('MMM DD');
                 bookingTimeExplanation = `[${bookingStartMoment.clone().format('HH:mm')} to ${bookingEndMoment.clone().format('HH:mm')}]`;
                 incidentTimeExplanation = `unlock : ${unlockMoment.clone().format('HH:mm')}`;
@@ -86,7 +93,8 @@ const createFeeFromIncident = (incident) => {
                 quantity = +timeIntervalsToCharge.toFixed(2);
                 break;
             case incidentType.UNSCHEDULED_INCIDENT_AFTER_RESERVATION:
-                roomExplanation = resourceName;
+                spacing = '   ';
+                roomExplanation = resourceName || 'Unknown';
                 dateExplanation = bookingStartMoment.clone().startOf('day').format('MMM DD');
                 bookingTimeExplanation = `[${bookingStartMoment.clone().format('HH:mm')} to ${bookingEndMoment.clone().format('HH:mm')}]`;
                 incidentTimeExplanation = `lock : ${lockMoment.clone().format('HH:mm')}`;
@@ -98,7 +106,8 @@ const createFeeFromIncident = (incident) => {
                 quantity = +timeIntervalsToCharge.toFixed(2);
                 break;
             case incidentType.UNLOCKED_INCIDENT_STANDALONE:
-                roomExplanation = resourceName;
+                spacing = '   ';
+                roomExplanation = resourceName || 'Unknown';
                 dateExplanation = unlockMoment.clone().startOf('day').format('MMM DD');
                 bookingTimeExplanation = `[${unlockMoment.clone().format('HH:mm')} to ${lockMoment.clone().format('HH:mm')}]`;
                 incidentTimeExplanation = `unlock : ${unlockMoment.clone().format('HH:mm')}`;
@@ -110,7 +119,8 @@ const createFeeFromIncident = (incident) => {
                 quantity = 1.00;
                 break;
             case incidentType.UNSCHEDULED_INCIDENT_STANDALONE:
-                roomExplanation = resourceName;
+                spacing = '  ';
+                roomExplanation = resourceName || 'Unknown';
                 dateExplanation = unlockMoment.clone().startOf('day').format('MMM DD');
                 bookingTimeExplanation = `[${unlockMoment.clone().format('HH:mm')} to ${lockMoment.clone().format('HH:mm')}]`;
                 //incidentTimeExplanation = `unlock : ${unlockMoment.clone().format('HH:mm')}, lock : ${lockMoment.clone().format('HH:mm')}`;
@@ -121,16 +131,18 @@ const createFeeFromIncident = (incident) => {
                 quantity = +timeIntervalsToCharge.toFixed(2);
                 break;
             case incidentType.BOOKING_MOVED_TO_ANOTHER_DAY:
+                spacing = '  ';
                 // if (oldResourceName !== newResourceName){
                 //     roomExplanation = `${oldResourceName} -> ${newResourceName}`;
                 // }else{
                 //     roomExplanation = oldResourceName;
                 // }
-                roomExplanation = newResourceName;
+                roomExplanation = newResourceName || 'Unknown';
 
                 // dateExplanation = `${oldBookingStartMoment.clone().format('ddd, MMM DD')} -> ${newBookingStartMoment.clone().format('ddd, MMM DD')}`;
-                dateExplanation = `${newBookingStartMoment.clone().format('MMM DD')}`;
+                dateExplanation = `${oldBookingStartMoment.clone().format('MMM DD')}`;
-                bookingTimeExplanation = `[${newBookingStartMoment.clone().format('HH:mm')} to ${newBookingEndMoment.clone().format('HH:mm')}]`;
+                bookingTimeExplanation = `[${oldBookingStartMoment.clone().format('HH:mm')} to ${oldBookingEndMoment.clone().format('HH:mm')}]`;
+                additionalDateTimeExplanation = ` -> ${newBookingStartMoment.clone().format('MMM DD')} [${newBookingStartMoment.clone().format('HH:mm')} to ${newBookingEndMoment.clone().format('HH:mm')}]`;
                 incidentTimeExplanation = `moved on : ${incidentTimestampMoment.clone().format('MMM DD, HH:mm')}`;
                 incidentExplanation += `, ${incidentTimeExplanation}`;
 
@@ -140,26 +152,30 @@ const createFeeFromIncident = (incident) => {
                 quantity = 1.00;
                 break;
             case incidentType.BOOKING_SHORTENED:
+                spacing = '   ';
                 // if (oldResourceName !== newResourceName){
                 //     roomExplanation = `${oldResourceName} -> ${newResourceName}`;
                 // }else{
                 //     roomExplanation = oldResourceName;
                 // }
-                roomExplanation = newResourceName;
+                roomExplanation = newResourceName || 'Unknown';
 
                 // dateExplanation = `${oldBookingStartMoment.clone().format('ddd, MMM DD')}`;
+
+                const originalBookingExplanation = `${oldBookingStartMoment.clone().format('HH:mm')} to ${oldBookingEndMoment.clone().format('HH:mm')}`;
                 dateExplanation = `${newBookingStartMoment.clone().format('MMM DD')}`;
                 bookingTimeExplanation = `[${newBookingStartMoment.clone().format('HH:mm')} to ${newBookingEndMoment.clone().format('HH:mm')}]`;
-                incidentTimeExplanation = `shortened on : ${incidentTimestampMoment.clone().format('MMM DD, HH:mm')}`;
+                incidentTimeExplanation = `reservation shortened from [${originalBookingExplanation}] on [${incidentTimestampMoment.clone().format('MMM DD, HH:mm')}]`;
-                incidentExplanation += `, ${incidentTimeExplanation}`;
+                incidentExplanation = `${incidentTimeExplanation}`;
 
-                date = incidentTimestampMoment.clone().startOf('day').format();
+                date = newBookingStartMoment.clone().utc(UI_TIMEZONE).startOf('day').format();
 
                 price = +totalChargeFee.toFixed(2);
                 quantity = 1.00;
                 break;
             case incidentType.BOOKING_CANCELED_LATE:
-                roomExplanation = oldResourceName;
+                spacing = '  ';
+                roomExplanation = oldResourceName || 'Unknown';
                 // dateExplanation = `${oldBookingStartMoment.clone().format('ddd, MMM DD')}`;
                 dateExplanation = `${oldBookingStartMoment.clone().format('MMM DD')}`;
                 bookingTimeExplanation = `[${oldBookingStartMoment.clone().format('HH:mm')} to ${oldBookingEndMoment.clone().format('HH:mm')}]`;
@@ -173,7 +189,7 @@ const createFeeFromIncident = (incident) => {
                 break;
         }
 
-        const formattedName = `${dateExplanation} ${bookingTimeExplanation} ${roomExplanation}, ${officeName}, ${incidentExplanation}`;
+        const formattedName = `${officeSlug}, ${dateExplanation} ${bookingTimeExplanation}${additionalDateTimeExplanation}${spacing}${roomExplanation}, ${incidentExplanation}`;
 
         return {
             name: formattedName,
@@ -202,14 +218,14 @@ const createFeeFromBooking = (booking, resourceMappings) => {
     const endMoment = moment.tz(end, DEFAULT_DATE_FORMAT, timezone);
     const reservationLength = endMoment.diff(startMoment, 'hours', true);
 
-    const officeName = officesMap[officeId].officeName || 'Unknown';
+    const officeSlug = officesMap[officeId].officeSlug || 'Unknown';
     const resourceName = resourcesMap[resourceId].resourceName || 'Unknown';
 
     const formattedDate = startMoment.clone().startOf('day').format('MMM DD');
     const formattedStartTime = startMoment.format('HH:mm');
     const formattedEndTime = endMoment.format('HH:mm');
 
-    const formattedName = `${formattedDate} [${formattedStartTime} to ${formattedEndTime}] ${resourceName}, ${officeName}`;
+    const formattedName = `${officeSlug}, ${formattedDate} [${formattedStartTime} to ${formattedEndTime}]  ${resourceName}`;
 
     return {
         name: formattedName,
@@ -228,9 +244,9 @@ const createNegativeFeeForDiscount = (memberData, dateRange) => {
     const { totalBookedHours, totalChargedHours, totalBookingChargedFee } = bookingData;
     const { memberId, officeId } = member;
 
-    let endDate = moment.utc().endOf('day').toISOString();
+    let dateForDiscount = moment.utc().subtract(1, 'month').startOf('month').toISOString();
-    if (dateRange.endDate){
+    if (dateRange.startDate){
-        endDate = moment.utc(dateRange.endDate, DEFAULT_DATE_FORMAT).endOf('day').toISOString();
+        dateForDiscount = moment.utc(dateRange.startDate, DEFAULT_DATE_FORMAT).startOf('month').toISOString();
     }
 
     let membershipFeeForDiscount = 0;
@@ -269,7 +285,7 @@ const createNegativeFeeForDiscount = (memberData, dateRange) => {
         name: formattedName,
         price: -discount.toFixed(2),
         quantity: 1,
-        date: endDate,
+        date: dateForDiscount,
         member: memberId,
         team: null,
         office: officeId,
@@ -330,7 +346,7 @@ const getMembersFeesForDateRange = (dateRange, memberIds) => {
                 allIncidents.forEach((incident) => {
                     const feeFromIncident = createFeeFromIncident(incident);
                     if (feeFromIncident){
-                        allFees.push(createFeeFromIncident(incident));
+                        allFees.push(feeFromIncident);
                     }
 
                     const incidentsValuableForDiscountCalculation = [
@@ -464,7 +480,7 @@ const getMembersFeesForDateRange = (dateRange, memberIds) => {
                         fee.team = memberIdTeamMappings[member] || null;
                         if (teamId){
                             //if member is part of the company, add name to the fee description/name
-                            fee.name += `, ${memberName}`;
+                            fee.name = `${memberName}, ${fee.name}`;
                         }
                     }
                 });

services/integration/reports.js

@@ -7,7 +7,6 @@ const Op = require('sequelize').Op;
 
 const workbookCreator = require('excel4node');
 
-const { checkBookingChanges } = require('./checkBookingChange');
 const { incidentType, UI_TIMEZONE, DEFAULT_DATE_FORMAT, integrationServiceErrors } = require('../../constants/constants');
 
 const { getAllBookingsForMembersInDateRange } = require('./bookings');
@@ -18,7 +17,9 @@ const { getChargedCanceledReservations } = require('../integration/bookingChange
 const getUnlockedIncidents = (startDate, endDate, memberIds) => {
     const attributes = ['id', 'reservationId', 'memberId', 'resourceId', 'bookingStart', 'bookingEnd', 'unlockTimestamp', 'incidentLevel', 'incidentLevelPrice'];
 
-    const filters = {};
+    const filters = {
+        deleted: false
+    };
 
     if (startDate && endDate) {
         const bookingStartCondition = {
@@ -76,7 +77,9 @@ const getUnscheduledIncidents = (startDate, endDate, memberIds) => {
         'totalChargeFee'
     ];
 
-    const filters = {};
+    const filters = {
+        deleted: false
+    };
 
     if (startDate && endDate) {
         const bookingStartCondition = {
@@ -218,18 +221,29 @@ const getAllIncidents = (dateRange, memberIds) => {
                 unlockedIncidents.forEach((unlockedIncident) => {
                     const incidentTypeNumber = unlockedIncident.reservationId ?
                         incidentType.UNLOCKED_INCIDENT_RELATED_WITH_RESERVATION : incidentType.UNLOCKED_INCIDENT_STANDALONE;
+
+                    const resourceObject = resourcesMap[unlockedIncident.resourceId];
+                    const officeObject = resourceObject ? officesMap[resourceObject.officeId] : null;
+
+                    const memberName = membersMap[unlockedIncident.memberId] ? membersMap[unlockedIncident.memberId].name : 'Unknown member';
+                    const resourceName = resourceObject ? resourceObject.resourceName : 'Unknown room';
+                    const officeId = resourceObject ? resourceObject.officeId : '';
+                    const officeName = officeObject ? officeObject.officeName : 'Unknown office';
+                    const officeSlug = officeObject ? officeObject.officeSlug : '-';
+
                     allIncidents.push({
                         incidentId: unlockedIncident.id,
                         memberId: unlockedIncident.memberId,
-                        memberName: membersMap[unlockedIncident.memberId].name,
+                        memberName,
-                        resourceName: resourcesMap[unlockedIncident.resourceId].resourceName,
+                        resourceName,
-                        officeId: resourcesMap[unlockedIncident.resourceId].officeId,
+                        officeId,
-                        officeName: officesMap[resourcesMap[unlockedIncident.resourceId].officeId].officeName,
+                        officeName,
-                        bookingStart: formatTime(unlockedIncident.bookingStart),
+                        officeSlug,
-                        bookingEnd: formatTime(unlockedIncident.bookingEnd),
+                        bookingStart: formatTime(unlockedIncident.bookingStart) || '-',
+                        bookingEnd: formatTime(unlockedIncident.bookingEnd) || '-',
                         bookingStartRaw: unlockedIncident.bookingStart,
                         bookingEndRaw: unlockedIncident.bookingEnd,
-                        unlockTimestamp: formatTime(unlockedIncident.unlockTimestamp),
+                        unlockTimestamp: formatTime(unlockedIncident.unlockTimestamp) || '-',
                         unlockTimestampRaw: unlockedIncident.unlockTimestamp,
                         incidentType: incidentTypeNumber,
                         incidentLevel: unlockedIncident.incidentLevel,
@@ -248,19 +262,30 @@ const getAllIncidents = (dateRange, memberIds) => {
                     }else{
                         incidentTypeNumber = incidentType.UNSCHEDULED_INCIDENT_STANDALONE;
                     }
+
+                    const resourceObject = resourcesMap[unscheduledIncident.resourceId];
+                    const officeObject = resourceObject ? officesMap[resourceObject.officeId] : null;
+
+                    const memberName = membersMap[unscheduledIncident.memberId] ? membersMap[unscheduledIncident.memberId].name : 'Unknown member';
+                    const resourceName = resourceObject ? resourceObject.resourceName : 'Unknown room';
+                    const officeId = resourceObject ? resourceObject.officeId : '';
+                    const officeName = officeObject ? officeObject.officeName : 'Unknown office';
+                    const officeSlug = officeObject ? officeObject.officeSlug : '-';
+
                     allIncidents.push({
                         incidentId: unscheduledIncident.id,
                         memberId: unscheduledIncident.memberId,
-                        memberName: membersMap[unscheduledIncident.memberId].name,
+                        memberName,
-                        resourceName: resourcesMap[unscheduledIncident.resourceId].resourceName,
+                        resourceName,
-                        officeId: resourcesMap[unscheduledIncident.resourceId].officeId,
+                        officeId,
-                        officeName: officesMap[resourcesMap[unscheduledIncident.resourceId].officeId].officeName,
+                        officeName,
-                        bookingStart: formatTime(unscheduledIncident.bookingStart),
+                        officeSlug,
-                        bookingEnd: formatTime(unscheduledIncident.bookingEnd),
+                        bookingStart: formatTime(unscheduledIncident.bookingStart) || '-',
+                        bookingEnd: formatTime(unscheduledIncident.bookingEnd) || '-',
                         bookingStartRaw: unscheduledIncident.bookingStart,
                         bookingEndRaw: unscheduledIncident.bookingEnd,
-                        unlockTimestamp: formatTime(unscheduledIncident.unlockTimestamp),
+                        unlockTimestamp: formatTime(unscheduledIncident.unlockTimestamp) || '-',
-                        lockTimestamp: formatTime(unscheduledIncident.lockTimestamp),
+                        lockTimestamp: formatTime(unscheduledIncident.lockTimestamp) || '-',
                         unlockTimestampRaw: unscheduledIncident.unlockTimestamp,
                         lockTimestampRaw: unscheduledIncident.lockTimestamp,
                         incidentType: incidentTypeNumber,
@@ -285,13 +310,14 @@ const getAllIncidents = (dateRange, memberIds) => {
                         deleted,
                         createdAt,
                     } = bookingChangeIncident;
-                    const memberName = membersMap[memberId].name;
+                    const memberName = membersMap[memberId] ? membersMap[memberId].name : 'Unknown member';
                     const oldResource = resourcesMap[oldResourceId];
                     const newResource = newResourceId ? resourcesMap[newResourceId] : null;
-                    const oldResourceName = oldResource.resourceName;
+                    const oldResourceName = oldResource ? oldResource.resourceName : 'Unknown room';
                     const newResourceName = newResource ? newResource.resourceName : null;
-                    const officeId = oldResource.officeId;
+                    const officeId = oldResource ? oldResource.officeId : '';
-                    const officeName = officesMap[officeId].officeName;
+                    const officeName = officesMap[officeId] ? officesMap[officeId].officeName : 'Unknown office';
+                    const officeSlug = officesMap[officeId] ? officesMap[officeId].officeSlug : '-';
                     allIncidents.push({
                         incidentId: id,
                         memberId,
@@ -300,10 +326,11 @@ const getAllIncidents = (dateRange, memberIds) => {
                         newResourceName,
                         officeId,
                         officeName,
-                        oldBookingStart: formatTime(oldBookingStart),
+                        officeSlug,
-                        oldBookingEnd: formatTime(oldBookingEnd),
+                        oldBookingStart: formatTime(oldBookingStart) || '-',
-                        newBookingStart: formatTime(newBookingStart),
+                        oldBookingEnd: formatTime(oldBookingEnd) || '-',
-                        newBookingEnd: formatTime(newBookingEnd),
+                        newBookingStart: formatTime(newBookingStart) || '-',
+                        newBookingEnd: formatTime(newBookingEnd) || '-',
                         oldBookingStartRaw: oldBookingStart,
                         oldBookingEndRaw: oldBookingEnd,
                         newBookingStartRaw: newBookingStart,
@@ -311,7 +338,7 @@ const getAllIncidents = (dateRange, memberIds) => {
                         incidentType,
                         totalChargeFee: chargeFee,
                         deleted,
-                        incidentTimestamp: formatTime(createdAt),
+                        incidentTimestamp: formatTime(createdAt) || '-',
                         incidentTimestampRaw: createdAt,
                     });
                 });
@@ -332,12 +359,12 @@ const getMemberPracticeSummaryReport = (year) => {
             endDate,
         };
 
-        const asyncJobs = [checkBookingChanges(), getAllBookingsForMembersInDateRange(dateRange), fetchAllMembers()];
+        const asyncJobs = [getAllBookingsForMembersInDateRange(dateRange), fetchAllMembers()];
 
         Promise.all(asyncJobs)
             .then((results) => {
-                const allBookings = results[1];
+                const allBookings = results[0];
-                const allMembers = results[2];
+                const allMembers = results[1];
 
                 const membersMap = {};
 
@@ -386,6 +413,7 @@ const getMemberPracticeSummaryReport = (year) => {
 
                 getChargedCanceledReservations(reservationIdsForAdditionalData)
                     .then((incidents) => {
+                        console.log('Charged canceled reservations ...');
                         incidents.forEach((incident) => {
                             const {memberId, oldBookingStart, oldBookingEnd} = incident.get();
 
@@ -503,15 +531,29 @@ const getMemberPracticeSummaryReport = (year) => {
                         const inactiveMemberIdsList = [];
 
                         memberIdsListFromReportMap.forEach((memberId) => {
-                            if (membersMap[memberId].active){
+                            if (memberId){
-                                activeMemberIdsList.push(memberId);
+                                if (membersMap[memberId] && membersMap[memberId].active){
+                                    activeMemberIdsList.push(memberId);
+                                }else{
+                                    console.log('[Get Member Practice Summary Report] Unknown member ');
+                                    console.log('\tmemberId : ', memberId);
+                                    console.log('\tmembersMap[memberId] : ', membersMap[memberId]);
+                                    inactiveMemberIdsList.push(memberId);
+                                }
                             }else{
-                                inactiveMemberIdsList.push(memberId);
+                                console.log('[Get Member Practice Summary Report] memberId is wrong : ', memberId);
                             }
                         });
 
                         const sortMemberIdsListByName = (memberId1, memberId2) => {
-                            if (membersMap[memberId1].name > membersMap[memberId2].name){
+                            const name1 = membersMap[memberId1] ? membersMap[memberId1].name || 'Unknown member' : null;
+                            const name2 = membersMap[memberId2] ? membersMap[memberId2].name || 'Unknown member' : null;
+
+                            if (!name1 || !name2){
+                                return 0;
+                            }
+
+                            if (name1 > name2){
                                 return 1;
                             }else{
                                 return -1;

services/officeRnD/bookings.js

@@ -5,7 +5,7 @@ const moment = require('moment-timezone');
 const Op = require('sequelize').Op;
 
 const { API } = require('../../helpers/api');
-const { officeRnDAPIErrors, MAX_BACK_TO_BACK_DIFFERENCE } = require('../../constants/constants');
+const { officeRnDAPIErrors, MAX_BACK_TO_BACK_DIFFERENCE, UI_TIMEZONE } = require('../../constants/constants');
 
 const fetchAllBookings = () => {
     return new Promise((resolve, reject) => {
@@ -14,24 +14,136 @@ const fetchAllBookings = () => {
                 const cleanedBookingReservations = [];
                 const bookingData = result && result.data ? result.data : [];
 
-                bookingData.forEach((fullBookingEntry) => {
+                const bookingsToCreate = [];
-                    const fees = fullBookingEntry && fullBookingEntry.fees ? fullBookingEntry.fees : [];
+                const bookingIdsToRemove = [];
-                    const firstFee = fees.length > 0 && fees[0].fee ? fees[0].fee : undefined;
-                    const hourlyRate = firstFee && firstFee.price ? firstFee.price : 0;
 
-                    cleanedBookingReservations.push({
+                bookingData.forEach(fullBookingEntry => {
-                        reservationId: fullBookingEntry['_id'],
+                    if (!fullBookingEntry){
-                        memberId: fullBookingEntry.member,
+                        return;
-                        officeId: fullBookingEntry.office,
+                    }
-                        resourceId: fullBookingEntry.resourceId,
+                    const fees = fullBookingEntry.fees ? fullBookingEntry.fees : [];
-                        start: fullBookingEntry.start.dateTime,
+                    const canceled = fullBookingEntry.canceled ? fullBookingEntry.canceled : false;
-                        end: fullBookingEntry.end.dateTime,
+                    const recurringReservation = fullBookingEntry.recurrence && fullBookingEntry.recurrence.rrule ?
-                        timezone: fullBookingEntry.timezone,
+                        fullBookingEntry.recurrence.rrule : null;
-                        canceled: fullBookingEntry.canceled || false,
+                    const tentative = fullBookingEntry.tentative ? fullBookingEntry.tentative : false;
-                        hourlyRate,
+                    const free = fullBookingEntry.free ? fullBookingEntry.free : false;
-                    });
+
+                    //Special case, canceled recurring reservation
+                    //It has empty fees array (fees.length = 0) and no "canceled" field
+                    //Normally, canceled reservation has canceled field
+                    //Also, it has rrule !== null
+                    //If it is tentative, it will have tentative = true, skip those (do not delete)
+                    //If it is free, it will have free = true, skip those (do not delete)
+                    if (fees.length === 0 && !canceled && recurringReservation && !tentative && !free){
+                        bookingIdsToRemove.push(fullBookingEntry['_id']);
+                    }
+
+                    if (fees.length > 1){
+                        // Recurring booking, let's create new booking
+                        const member = fullBookingEntry.member ? fullBookingEntry.member : null;
+                        const office = fullBookingEntry.office ? fullBookingEntry.office : null;
+                        const resourceId = fullBookingEntry.resourceId ? fullBookingEntry.resourceId : null;
+                        const team = fullBookingEntry.team ? fullBookingEntry.team : null;
+                        const organization = fullBookingEntry.organization ? fullBookingEntry.organization : null;
+                        const plan = fullBookingEntry.plan ? fullBookingEntry.plan : null;
+                        const timezone = fullBookingEntry.timezone ? fullBookingEntry.timezone : UI_TIMEZONE;
+                        const source = 'admin';
+
+                        const startMoment = fullBookingEntry && fullBookingEntry.start && fullBookingEntry.start.dateTime ?
+                            moment.utc(fullBookingEntry.start.dateTime) : null;
+                        const endMoment = fullBookingEntry && fullBookingEntry.end && fullBookingEntry.end.dateTime ?
+                            moment.utc(fullBookingEntry.end.dateTime) : null;
+
+                        fees.forEach(fee => {
+                            const dateMoment = fee.date ? moment.utc(fee.date) : null;
+
+                            if (startMoment && endMoment && dateMoment){
+                                const yearPart = dateMoment.year();
+                                const monthPart = dateMoment.month();
+                                const dayPart = dateMoment.date();
+
+                                const newStartMoment = startMoment.clone().tz(fullBookingEntry.timezone).year(yearPart).month(monthPart).date(dayPart);
+                                const newEndMoment = endMoment.clone().tz(fullBookingEntry.timezone).year(yearPart).month(monthPart).date(dayPart);
+
+                                bookingsToCreate.push({
+                                    start: {
+                                        dateTime: newStartMoment.toISOString()
+                                    },
+                                    end: {
+                                        dateTime: newEndMoment.toISOString()
+                                    },
+                                    team,
+                                    member,
+                                    resourceId,
+                                    office,
+                                    source,
+                                    timezone,
+                                    organization,
+                                    plan
+                                })
+                            }
+                        });
+
+                        bookingIdsToRemove.push(fullBookingEntry['_id']);
+                    }
                 });
-                resolve(cleanedBookingReservations);
+
+                //Here we now have possible bookings to create and then load again "check Booking changes"
+
+                if (bookingIdsToRemove.length > 0){
+                    //First delete, wait until operation is done, than create bookings (to avoid conflicting date/time)
+                    API.delete('bookings/?silent', { data: bookingIdsToRemove })
+                        .then(() => {
+                            //Now, insert new bookings
+                            API.post('bookings/?silent', bookingsToCreate)
+                                .then(() => {
+                                    //And fetch again all bookings
+                                    resolve(fetchAllBookings());
+                                })
+                                .catch((error) => {
+                                    console.log(officeRnDAPIErrors.FAILED_TO_CREATE_BOOKINGS);
+                                    console.log('Details : ', error);
+                                    reject(officeRnDAPIErrors.FAILED_TO_CREATE_BOOKINGS);
+                                });
+                        })
+                        .catch(error => {
+                            console.log(officeRnDAPIErrors.FAILED_TO_DELETE_BOOKINGS);
+                            console.log('Details : ', error);
+                            reject(officeRnDAPIErrors.FAILED_TO_DELETE_BOOKINGS);
+                        });
+                }else{
+                    bookingData.forEach((fullBookingEntry) => {
+                        const fees = fullBookingEntry && fullBookingEntry.fees ? fullBookingEntry.fees : [];
+                        const firstFee = fees.length > 0 && fees[0].fee ? fees[0].fee : undefined;
+                        const hourlyRate = firstFee && firstFee.price ? firstFee.price : 0;
+                        const free = fullBookingEntry.free ? fullBookingEntry.free :  false;
+                        const tentative = fullBookingEntry.tentative ? fullBookingEntry.tentative : false;
+
+                        const startMoment = fullBookingEntry && fullBookingEntry.start && fullBookingEntry.start.dateTime ?
+                            moment.utc(fullBookingEntry.start.dateTime) : null;
+                        const endMoment = fullBookingEntry && fullBookingEntry.end && fullBookingEntry.end.dateTime ?
+                            moment.utc(fullBookingEntry.end.dateTime) : null;
+
+                        // console.log('\r\n\r\nStart : ', startMoment.clone().tz(fullBookingEntry.timezone).format('DD.MM. HH:mm'), '[', startMoment.toISOString(),']');
+                        // console.log('End   : ', endMoment.clone().tz(fullBookingEntry.timezone).format('DD.MM. HH:mm'), '[', endMoment.toISOString(), ']');
+                        // console.log('Fees  : ');
+
+                        if (startMoment && endMoment && !free && !tentative){
+                            cleanedBookingReservations.push({
+                                reservationId: fullBookingEntry['_id'],
+                                memberId: fullBookingEntry.member,
+                                officeId: fullBookingEntry.office,
+                                resourceId: fullBookingEntry.resourceId,
+                                start: startMoment.toISOString(),
+                                end: endMoment.toISOString(),
+                                timezone: fullBookingEntry.timezone,
+                                canceled: fullBookingEntry.canceled || false,
+                                hourlyRate,
+                            });
+                        }
+                    });
+                    resolve(cleanedBookingReservations);
+                }
             })
             .catch((error) => {
                 console.log(officeRnDAPIErrors.FAILED_TO_FETCH_BOOKINGS);
@@ -149,6 +261,32 @@ const getFirstReservationInBlock = (reservation) => {
     });
 };
 
+const getLastReservationInBlock = async (reservation) => {
+    const { resourceId, memberId, end } = reservation;
+
+    const toTimestamp = moment.utc(end).add(MAX_BACK_TO_BACK_DIFFERENCE).toISOString();
+    const fromTimestamp = end;
+
+    const filters = {
+        resourceId,
+        memberId,
+        start: {
+            [Op.and]: [
+                {[Op.gte]: fromTimestamp},
+                {[Op.lte]: toTimestamp}
+            ]
+        }
+    };
+
+    const nextReservation = await db.bookingReservation.findOne({where: filters});
+    if (!nextReservation) {
+        return reservation;
+    } else {
+        return getLastReservationInBlock(nextReservation);
+    }
+
+};
+
 const writeBookingReservation = (bookingReservation) => {
     const { reservationId, memberId, officeId, resourceId, start, end, timezone, canceled, hourlyRate } = bookingReservation;
     const bookingReservationForDB = {
@@ -193,7 +331,15 @@ const bulkWriteReservationsWithChangesTracking = (reservations, resourcesMap) =>
                 if (parseFloat(instance.previous('hourlyRate') > 0)) {
                     instance.setDataValue('hourlyRate', instance.previous('hourlyRate'));
                 }else{
-                    const hourlyRate = resourceId ? resourcesMap[resourceId].price : 0;
+                    //Determine if we should apply weekend price or work day price
+                    const newStartWeekDay = moment.utc(instance.start).isoWeekday();
+                    const isWeekend = newStartWeekDay > 5; //6 - Saturday, 7 - Sunday
+                    let hourlyRate;
+                    if (isWeekend){
+                        hourlyRate = resourceId ? resourcesMap[resourceId].price.weekendPrice : 0;
+                    }else{
+                        hourlyRate = resourceId ? resourcesMap[resourceId].price.price : 0;
+                    }
                     instance.setDataValue('hourlyRate', hourlyRate);
                 }
             }
@@ -266,5 +412,6 @@ module.exports = {
     getFirstNextBooking,
     getFirstPreviousBooking,
     getFirstReservationInBlock,
+    getLastReservationInBlock,
     bulkWriteReservationsWithChangesTracking,
 };

services/officeRnD/fees.js

@@ -22,9 +22,14 @@ const deleteFeesFromORD = (dateRange, memberIds) => {
                 const fetchedFees = feesResponse.data ? feesResponse.data : [];
                 const fetchedPlans = plansResponse.data ? plansResponse.data : [];
 
+                const planIsRateMap = {};
+
                 const manualFeeNames = [];
                 fetchedPlans.forEach((plan) => {
-                    const { name } = plan;
+                    const { name, _id, isRate } = plan;
+
+                    planIsRateMap[_id] = !!isRate;
+
                     if (name && name.length > 0){
                         manualFeeNames.push(name);
                     }
@@ -40,18 +45,24 @@ const deleteFeesFromORD = (dateRange, memberIds) => {
                 const feeIdsToRemove = [];
 
                 fetchedFees.forEach((fee) => {
-                    const { member, date, invoice, name } = fee;
+                    const { member, date, invoice, name, plan } = fee;
                     const { status } = invoice;
                     const feeId = fee['_id'];
+                    const feePlanIsRate = plan ? planIsRateMap[plan] : null;
 
                     const isDateInDateRange = startDate.isSameOrBefore(date) && endDate.isSameOrAfter(date);
                     let manuallyAddedFee = false;
-                    if (manualFeeNames.indexOf(name) === -1){
+
-                        if (name && name[0] && CUSTOM_FEES_PREFIXES.indexOf(name[0]) !== -1){
+                    if (plan && !feePlanIsRate){
+                        manuallyAddedFee = true;
+                    }else{
+                        if (manualFeeNames.indexOf(name) === -1){
+                            if (name && name[0] && CUSTOM_FEES_PREFIXES.indexOf(name[0]) !== -1){
+                                manuallyAddedFee = true;
+                            }
+                        }else{
                             manuallyAddedFee = true;
                         }
-                    }else{
-                        manuallyAddedFee = true;
                     }
 
                     const memberFeesShouldBeDeleted = filterByMemberIds ? memberIdsMap[member] : true;
@@ -63,7 +74,7 @@ const deleteFeesFromORD = (dateRange, memberIds) => {
                     }
                 });
 
-                API.delete('fees', { data: feeIdsToRemove })
+                API.delete('fees/?silent', { data: feeIdsToRemove })
                     .then(() => {
                         resolve(feesToSkip);
                     })

services/officeRnD/rates.js

@@ -9,9 +9,17 @@ const fetchRates = () => {
                 const rates = result.data || [];
                 const cleanedRates = [];
                 rates.forEach(rate => {
+                    const additionalRates = rate.rates;
+                    let weekendRate = rate.price; //fallback price
+                    additionalRates.forEach(additionalRate => {
+                        if (additionalRate.isWeekendRate){
+                            weekendRate = additionalRate.price;
+                        }
+                    });
                     cleanedRates.push({
                         rateId: rate['_id'],
                         price: rate.price,
+                        weekendPrice: weekendRate
                     });
                 });
                 resolve(cleanedRates);

services/officeRnD/resources.js

@@ -15,6 +15,7 @@ const fetchOffices = () => {
                     cleanedOffices.push({
                         officeId: office['_id'],
                         officeName: office.name,
+                        officeSlug: office.description,
                     });
                 });
                 resolve(cleanedOffices);