senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

show tooltip for max cost margin #83

Merged
bilal.catic merged 3 commits from max-cost-margin-tooltip into development 2018-12-05 20:39:29 +01:00
Conversation 9 Commits 3 Files Changed 2 +10 -1
bilal.catic commented 2018-12-03 17:30:43 +01:00 (Migrated from gitlab.com)
Copy Link

SMOKE TEST :

verify that info icon is shown next to "Max cost margin" label in package price editor screen and it displays "Product deactivation limit (total cost)"

SMOKE TEST : verify that info icon is shown next to "Max cost margin" label in package price editor screen and it displays "Product deactivation limit (total cost)"
bilal.catic commented 2018-12-03 17:31:34 +01:00 (Migrated from gitlab.com)
Copy Link

added 10 commits

  • a1cf3d32...89080780 - 9 commits from branch development
  • 4ac600c2 - show tooltip for max cost margin

Compare with previous version

added 10 commits <ul><li>a1cf3d32...89080780 - 9 commits from branch <code>development</code></li><li>4ac600c2 - show tooltip for max cost margin</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/83/diffs?diff_id=28620950&start_sha=a1cf3d32804c5711b5a146ba0225d171ae0f654a)
akrdzic commented 2018-12-05 11:14:22 +01:00 (Migrated from gitlab.com)
Copy Link

Please use https://developer.wordpress.org/resource/dashicons/#editor-help icon for consistency

Please use https://developer.wordpress.org/resource/dashicons/#editor-help icon for consistency
akrdzic commented 2018-12-05 12:17:26 +01:00 (Migrated from gitlab.com)
Copy Link

Using 'title' attribute gives tooltip that is not consistent with the rest of the interface.
Here we could use filter woocommerce_screen_ids to add current screen id product_page_wiaas-package_price_editor to recognized woocommerce pages so woocommerce scripts and styles will be loaded. Then wc_help_tip function could be used to render tooltip that is the same
as that on other woocommerce pages.

Using 'title' attribute gives tooltip that is not consistent with the rest of the interface. Here we could use filter `woocommerce_screen_ids` to add current screen id `product_page_wiaas-package_price_editor` to recognized woocommerce pages so woocommerce scripts and styles will be loaded. Then `wc_help_tip` function could be used to render tooltip that is the same as that on other woocommerce pages.
bilal.catic commented 2018-12-05 15:13:27 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/83/diffs?diff_id=28803225&start_sha=4ac600c22ac3310cd581908463c52a1bb34961bc#e7d41539a887c199004150b4d66c2d78f4f2d265_191_191)
bilal.catic commented 2018-12-05 15:13:28 +01:00 (Migrated from gitlab.com)
Copy Link

added 4 commits

  • 4ac600c2...f33c6aa6 - 2 commits from branch development
  • a5fb4e51 - show tooltip for max cost margin
  • d799cf04 - use wordpress icons for consistency

Compare with previous version

added 4 commits <ul><li>4ac600c2...f33c6aa6 - 2 commits from branch <code>development</code></li><li>a5fb4e51 - show tooltip for max cost margin</li><li>d799cf04 - use wordpress icons for consistency</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/83/diffs?diff_id=28803225&start_sha=4ac600c22ac3310cd581908463c52a1bb34961bc)
bilal.catic commented 2018-12-05 15:28:12 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 1f5fcdec - use woocommerce help tip

Compare with previous version

added 1 commit <ul><li>1f5fcdec - use woocommerce help tip</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/83/diffs?diff_id=28804389&start_sha=d799cf04f7d5440893b0847462b048fb9309a296)
bilal.catic commented 2018-12-05 19:52:46 +01:00 (Migrated from gitlab.com)
Copy Link

added 6 commits

  • 1f5fcdec...392b1134 - 3 commits from branch development
  • bb9dc470 - show tooltip for max cost margin
  • 4aed08a9 - use wordpress icons for consistency
  • e4da6c7d - use woocommerce help tip

Compare with previous version

added 6 commits <ul><li>1f5fcdec...392b1134 - 3 commits from branch <code>development</code></li><li>bb9dc470 - show tooltip for max cost margin</li><li>4aed08a9 - use wordpress icons for consistency</li><li>e4da6c7d - use woocommerce help tip</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/83/diffs?diff_id=28822044&start_sha=1f5fcdecb21839c5cd8f85d4bd59d058919539d5)
akrdzic commented 2018-12-05 20:39:29 +01:00 (Migrated from gitlab.com)
Copy Link

merged

merged
akrdzic commented 2018-12-05 20:39:29 +01:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit a3761f3c71

mentioned in commit a3761f3c718fb458c36ce265cce894c2791be5f8
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#83
Delete Branch "max-cost-margin-tooltip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?