senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add phone number field in backoffice profile #75

Merged
bilal.catic merged 5 commits from add-phone-number-field-in-backoffice-profile into development 2018-11-22 13:24:42 +01:00
Conversation 7 Commits 5 Files Changed 5 +52
bilal.catic commented 2018-11-21 12:30:32 +01:00 (Migrated from gitlab.com)
Copy Link

SMOKE TEST :

  1. Validate that phone field exists in backoffice user profile page
  2. Enter invalid number and try to save (valid number contains only digits, + sign and spaces), there should be error
  3. Enter valid number and save, there should be no error
  4. Go to frontend and validate that number is changed
  5. Enter invalid number in frontend and save, there should be error
  6. Enter valid number in frontend and save, there should be no error
  7. Go to backoffice profile and check that number is updated
SMOKE TEST : 1. Validate that phone field exists in backoffice user profile page 2. Enter invalid number and try to save (valid number contains only digits, + sign and spaces), there should be error 3. Enter valid number and save, there should be no error 4. Go to frontend and validate that number is changed 5. Enter invalid number in frontend and save, there should be error 6. Enter valid number in frontend and save, there should be no error 7. Go to backoffice profile and check that number is updated
bilal.catic commented 2018-11-22 11:27:49 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8d954469 - use woocommerce validation</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/75/diffs?diff_id=27851473&start_sha=68c760a42695b3298d13d6d63283c661781c6807)
akrdzic commented 2018-11-22 11:46:17 +01:00 (Migrated from gitlab.com)
Copy Link

Add file wiaas_validation_function where you will have function wiaas_is_phone and then use this function here.

Add file `wiaas_validation_function` where you will have function `wiaas_is_phone` and then use this function here.
bilal.catic commented 2018-11-22 12:08:59 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/75/diffs?diff_id=27855049&start_sha=8d954469ee81e1e9967ced7189fedd80f796e9de#e59c48a1e80f738f2a843df919dd6e55dd35d95f_151_151)
bilal.catic commented 2018-11-22 12:09:01 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 217dfb18 - add validation functions class

Compare with previous version

added 1 commit <ul><li>217dfb18 - add validation functions class</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/75/diffs?diff_id=27855049&start_sha=8d954469ee81e1e9967ced7189fedd80f796e9de)
bilal.catic commented 2018-11-22 13:22:17 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>09fc3f80 - Rename class</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/75/diffs?diff_id=27863061&start_sha=217dfb188973b77ae57c19d0f6435b45c0035965)
akrdzic commented 2018-11-22 13:24:42 +01:00 (Migrated from gitlab.com)
Copy Link

merged

merged
akrdzic commented 2018-11-22 13:24:44 +01:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 61ff7dbc60

mentioned in commit 61ff7dbc60fea60c90d1846e5d8065f154db08c1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#75
Delete Branch "add-phone-number-field-in-backoffice-profile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?