senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Added support for sending customer emails #69

Merged
nedimu merged 4 commits from support-email into development 2018-11-19 13:24:13 +01:00
Conversation 18 Commits 4 Files Changed 5 +78 -5
nedimu commented 2018-11-16 17:15:36 +01:00 (Migrated from gitlab.com)
Copy Link

Smoke test

  1. Add WIAAS_SUPPORT_EMAIL variable to your local development.env file and put recipient email as value for that variable (this variable defaults to support@co-ideation.com if it is not set so be careful :P

  2. Log in as customer to frontend and go to http://localhost:3001/orders , and open orders history (you have to have at least one completed order)

  3. From actions menu of the order choose support and write some text in modal and click send.

  4. Receive email to recipient address with the same text (it should arrive in normal folder not spam)

  5. Check details of that order from same actions menue, and confirm that under comments tab, you see the same text (that confirms that order note has been saved)

Smoke test 1) Add WIAAS_SUPPORT_EMAIL variable to your local `development.env` file and put recipient email as value for that variable (this variable defaults to `support@co-ideation.com` if it is not set so be careful :P 2) Log in as customer to frontend and go to `http://localhost:3001/orders` , and open orders history (you have to have at least one completed order) 3) From actions menu of the order choose support and write some text in modal and click send. 4) Receive email to recipient address with the same text (it should arrive in normal folder not spam) 5) Check details of that order from same actions menue, and confirm that under comments tab, you see the same text (that confirms that order note has been saved)
nedimu commented 2018-11-16 17:16:37 +01:00 (Migrated from gitlab.com)
Copy Link

added 17 commits

  • 93c8fbdd...c630452d - 16 commits from branch development
  • a07c0e45 - Added support for sending customer emails

Compare with previous version

added 17 commits <ul><li>93c8fbdd...c630452d - 16 commits from branch <code>development</code></li><li>a07c0e45 - Added support for sending customer emails</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/69/diffs?diff_id=27449021&start_sha=93c8fbdd9db767984b8191932271d357e84df041)
nedimu commented 2018-11-16 17:26:38 +01:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nedimu commented 2018-11-16 17:26:38 +01:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2018-11-16 17:26:57 +01:00 (Migrated from gitlab.com)
Copy Link

assigned to @akrdzic

assigned to @akrdzic
akrdzic commented 2018-11-19 11:24:18 +01:00 (Migrated from gitlab.com)
Copy Link

Smoke test failed:

Text not added as order note. Instead number is added.
Selection_008

Smoke test failed: Text not added as order note. Instead number is added. ![Selection_008](/uploads/dee278090e546e0f7be5379853a42aa3/Selection_008.png)
akrdzic commented 2018-11-19 11:28:50 +01:00 (Migrated from gitlab.com)
Copy Link

sendSupportMail camel case should not be used here, it is not consistent with other endpoints.
'send-support-email' should be used instead

`sendSupportMail` camel case should not be used here, it is not consistent with other endpoints. 'send-support-email' should be used instead
akrdzic commented 2018-11-19 11:29:45 +01:00 (Migrated from gitlab.com)
Copy Link

Camel case should not be used. Should be consistent with other endpoints from woocommerce and wiaas.

Camel case should not be used. Should be consistent with other endpoints from woocommerce and wiaas.
nedimu commented 2018-11-19 11:32:00 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 752df56d - Fixed bug where order note text is saved as order ID

Compare with previous version

added 1 commit <ul><li>752df56d - Fixed bug where order note text is saved as order ID</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/69/diffs?diff_id=27553982&start_sha=a07c0e4584c3d69146eff7b5f0d6fbc12bba938d)
akrdzic commented 2018-11-19 11:50:59 +01:00 (Migrated from gitlab.com)
Copy Link

This email subject is not right. It should be something like 'Support needed for order: {order number} for {customer}. Also order number and not order id should be used.

This email subject is not right. It should be something like 'Support needed for order: {order number} for {customer}. Also order number and not order id should be used.
nedimu commented 2018-11-19 12:35:11 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/69/diffs?diff_id=27559004&start_sha=752df56d4a3dbc60072c858c76cc71c4472d31e9#6c4f2ae44948e89d5e954fb20895fb8097372515_17_17)
nedimu commented 2018-11-19 12:35:11 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/69/diffs?diff_id=27559004&start_sha=752df56d4a3dbc60072c858c76cc71c4472d31e9#6c4f2ae44948e89d5e954fb20895fb8097372515_29_29)
nedimu commented 2018-11-19 12:35:11 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/69/diffs?diff_id=27559004&start_sha=752df56d4a3dbc60072c858c76cc71c4472d31e9#6c4f2ae44948e89d5e954fb20895fb8097372515_53_57)
nedimu commented 2018-11-19 12:35:12 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • f56377f6 - Handled proper endpoint naming

Compare with previous version

added 1 commit <ul><li>f56377f6 - Handled proper endpoint naming</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/69/diffs?diff_id=27559004&start_sha=752df56d4a3dbc60072c858c76cc71c4472d31e9)
akrdzic commented 2018-11-19 13:13:44 +01:00 (Migrated from gitlab.com)
Copy Link

Remove WP_DEBUG declaration from main application configuration.

Remove WP_DEBUG declaration from main application configuration.
nedimu commented 2018-11-19 13:15:56 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/69/diffs?diff_id=27561806&start_sha=f56377f606b36bbe1decfa9cb9cb2ccb245f5e7f#318fa3cf718dd8aa6ad80b08d2e9bd673642b8b9_51_51)
nedimu commented 2018-11-19 13:15:56 +01:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>35e670fa - removved debug log</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/69/diffs?diff_id=27561806&start_sha=f56377f606b36bbe1decfa9cb9cb2ccb245f5e7f)
akrdzic commented 2018-11-19 13:24:11 +01:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit d0533b3d6e

mentioned in commit d0533b3d6e382fa04facca2c03914cd4bdb3232e
akrdzic commented 2018-11-19 13:24:13 +01:00 (Migrated from gitlab.com)
Copy Link

merged

merged
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#69
Delete Branch "support-email"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?