senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Added wiaas_units selection to bundle products #52

Merged
nedimu merged 1 commits from bundle-units into master 2018-11-05 12:41:54 +01:00
Conversation 7 Commits 1 Files Changed 2 +24 -2
nedimu commented 2018-11-02 13:59:43 +01:00 (Migrated from gitlab.com)
Copy Link

Smoke test

Execute composer update-db

Verify that you can select and save units when you create bundle products

Smoke test Execute `composer update-db` Verify that you can select and save units when you create bundle products
nedimu commented 2018-11-02 14:00:21 +01:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
bilal.catic commented 2018-11-03 07:38:27 +01:00 (Migrated from gitlab.com)
Copy Link

At the moment, unit is not shown in unit column on products page

should "save_terms" and "load_terms" also be set to 1 ?

At the moment, unit is not shown in unit column on products page should "save_terms" and "load_terms" also be set to 1 ?
nedimu commented 2018-11-05 12:12:09 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/52/diffs?diff_id=26571471&start_sha=b950e796003814f2031ed1ef7600d7ed70657340#3f227e8a08d8379e80d4be66417892f983781051_68_88)
nedimu commented 2018-11-05 12:12:10 +01:00 (Migrated from gitlab.com)
Copy Link

added 45 commits

  • b950e796...0600bbee - 44 commits from branch master
  • de52c335 - Added wiaas_units selection to bundle products

Compare with previous version

added 45 commits <ul><li>b950e796...0600bbee - 44 commits from branch <code>master</code></li><li>de52c335 - Added wiaas_units selection to bundle products</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/52/diffs?diff_id=26571471&start_sha=b950e796003814f2031ed1ef7600d7ed70657340)
nedimu commented 2018-11-05 12:27:50 +01:00 (Migrated from gitlab.com)
Copy Link

added 5 commits

  • de52c335...afa370f4 - 4 commits from branch master
  • e2952a24 - Added wiaas_units selection to bundle products

Compare with previous version

added 5 commits <ul><li>de52c335...afa370f4 - 4 commits from branch <code>master</code></li><li>e2952a24 - Added wiaas_units selection to bundle products</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/52/diffs?diff_id=26573662&start_sha=de52c335cd95ea3b4814aa1a4c2fcb4b1a2cee02)
bilal.catic commented 2018-11-05 12:41:54 +01:00 (Migrated from gitlab.com)
Copy Link

merged

merged
bilal.catic commented 2018-11-05 12:41:55 +01:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 75141b6bd1

mentioned in commit 75141b6bd1ef45018e3d8168a6badc3f6f686b45
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#52
Delete Branch "bundle-units"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?