senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Schedule installation #49

Merged
bilal.catic merged 21 commits from schedule-installation-new into master 2018-11-03 11:24:43 +01:00
Conversation 25 Commits 21 Files Changed 14 +846 -8
bilal.catic commented 2018-10-31 13:23:08 +01:00 (Migrated from gitlab.com)
Copy Link

SMOKE TEST :

Prep :
Create 3 or 4 suppliers

  1. Create simple hardware product, simple software product, simple installation product and one simple product for option package (set different suppliers to different simple products)
  2. Create option package (on general tab, for additional days set number to 3)
  3. Create bundle containing all three simple products and one option (on general tab, for additional days, set number to 6)
  4. Set price, also as commercial lead
  5. Login to front end and order created bundle
  6. Go to back end as admin, to orders page and open created order
  7. Validate that "estimated delivery date" exists right under order info
  8. Validate that Delivery dates box contains all suppliers related to order
  9. Try to add tracking info
  10. Try to edit and save tracking info
  11. Try to delete tracking info
  12. Try to change estimated date
  13. Try to change confirmed date
  14. Validate that estimated date is set on confirmed date set (if it was previously empty)
  15. Try to remove estimated date (small 'x' next to up/down buttons in input)
  16. Try to remove confirmed date
  17. Validate that final dates are correct
  18. Validate that earliest installation date is set only if all estimated dates are set or all confirmed dates are set.
  19. Validate that earliest installation date is max date between all dates increased by 6 (greater number between additional days in bundles)
SMOKE TEST : Prep : Create 3 or 4 suppliers 1. Create simple hardware product, simple software product, simple installation product and one simple product for option package (set different suppliers to different simple products) 2. Create option package (on general tab, for additional days set number to 3) 3. Create bundle containing all three simple products and one option (on general tab, for additional days, set number to 6) 4. Set price, also as commercial lead 5. Login to front end and order created bundle 6. Go to back end as admin, to orders page and open created order 7. Validate that "estimated delivery date" exists right under order info 8. Validate that Delivery dates box contains all suppliers related to order 9. Try to add tracking info 10. Try to edit and save tracking info 11. Try to delete tracking info 12. Try to change estimated date 13. Try to change confirmed date 14. Validate that estimated date is set on confirmed date set (if it was previously empty) 15. Try to remove estimated date (small 'x' next to up/down buttons in input) 16. Try to remove confirmed date 17. Validate that final dates are correct 18. Validate that earliest installation date is set only if all estimated dates are set or all confirmed dates are set. 19. Validate that earliest installation date is max date between all dates increased by 6 (greater number between additional days in bundles)
akrdzic commented 2018-10-31 18:12:08 +01:00 (Migrated from gitlab.com)
Copy Link

Supplier is not user it is an organization. Since we know it is a supplier you can directly use wiaas_get_organization_name to get its name.

Supplier is not user it is an organization. Since we know it is a supplier you can directly use `wiaas_get_organization_name` to get its name.
akrdzic commented 2018-10-31 18:23:25 +01:00 (Migrated from gitlab.com)
Copy Link

There is no need to have Order in file or class name, Delivery Process is enough

There is no need to have `Order` in file or class name, `Delivery Process` is enough
akrdzic commented 2018-10-31 18:30:04 +01:00 (Migrated from gitlab.com)
Copy Link

For product supplier is a taxonomy. We only use fields to assign product to supplier term. So use taxonomy methods to retrieve supplier for product.

For product supplier is a taxonomy. We only use fields to assign product to supplier term. So use taxonomy methods to retrieve supplier for product.
akrdzic commented 2018-10-31 18:34:47 +01:00 (Migrated from gitlab.com)
Copy Link

Use

 $order->update_meta_data('test', 1);
 $order->save_meta_data();
Use ``` $order->update_meta_data('test', 1); $order->save_meta_data(); ```
akrdzic commented 2018-10-31 18:52:50 +01:00 (Migrated from gitlab.com)
Copy Link

For every order supplier we need to have information which simple line items he is delivering.

For every order supplier we need to have information which simple line items he is delivering.
akrdzic commented 2018-10-31 18:56:48 +01:00 (Migrated from gitlab.com)
Copy Link

We could probably use ACF field to collect this info for package. We should update ACF field group for package/bundle Bundle Properties and add another input to save this property.

We could probably use ACF field to collect this info for package. We should update ACF field group for package/bundle `Bundle Properties` and add another input to save this property.
akrdzic commented 2018-10-31 19:04:59 +01:00 (Migrated from gitlab.com)
Copy Link

We will probably not be displaying this flow on order page, instead only have link to delivery process page. use get_entry_url method on current step

We will probably not be displaying this flow on order page, instead only have link to delivery process page. use `get_entry_url` method on current step
akrdzic commented 2018-10-31 19:36:02 +01:00 (Migrated from gitlab.com)
Copy Link

Since these dates are related strictly to delivery process we should probably be adding them to delivery process instance (which is actually single form entry).
After moving this box to delivery process page we will be strictly working with delivery process for that order and not order metadata.

(Form entry can be extended with custom metadata for storing custom values for that entry irrelevant to actual form fields)

Since these dates are related strictly to delivery process we should probably be adding them to delivery process instance (which is actually single form entry). After moving this box to delivery process page we will be strictly working with delivery process for that order and not order metadata. (Form entry can be extended with custom metadata for storing custom values for that entry irrelevant to actual form fields)
akrdzic commented 2018-10-31 20:08:24 +01:00 (Migrated from gitlab.com)
Copy Link

This is display formatting action that should be done in view like $final_estimated_date = $final_estimated_date ? '-' : date('Y-m-d', $final_estimated_date) instead of here where only data should be collected and prepared for display in view.

This is display formatting action that should be done in view like `$final_estimated_date = $final_estimated_date ? '-' : date('Y-m-d', $final_estimated_date)` instead of here where only data should be collected and prepared for display in view.
akrdzic commented 2018-10-31 20:14:19 +01:00 (Migrated from gitlab.com)
Copy Link

Global delivery date and global estimated date is confusing and it is not clear at all that they are for single order. Instead we should be just using delivery date and estimated delivery date notation. It is implicit then that this means for whole order.

Delivery and estimated dates for specific supplier should then called order_supplier_delivery_date and order_supplier_estimated_delivery_date. So:

order_delivery_date, order_estimated_delivery_date
order_supplier_delivery_date, order_supplier_estimated_delivery_date

Global delivery date and global estimated date is confusing and it is not clear at all that they are for single order. Instead we should be just using delivery date and estimated delivery date notation. It is implicit then that this means for whole order. Delivery and estimated dates for specific supplier should then called order_supplier_delivery_date and order_supplier_estimated_delivery_date. So: order_delivery_date, order_estimated_delivery_date order_supplier_delivery_date, order_supplier_estimated_delivery_date
akrdzic commented 2018-10-31 20:16:44 +01:00 (Migrated from gitlab.com)
Copy Link

As said before use ACF for saving this property from product page.

As said before use ACF for saving this property from product page.
akrdzic commented 2018-10-31 20:22:32 +01:00 (Migrated from gitlab.com)
Copy Link

Move this code to wiaas-delivery-processs.js and then you can render this very small code snipped directly in hook method.

Move this code to `wiaas-delivery-processs.js` and then you can render this very small code snipped directly in hook method.
bilal.catic commented 2018-11-02 04:16:16 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26426177&start_sha=72d27bcce8ccc025a5a6e09d89a8a2efc80888dc#ad5503e66c7ae616469fefff8c69f2e2ccd08ddd_1_0)
bilal.catic commented 2018-11-02 04:16:16 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26426177&start_sha=72d27bcce8ccc025a5a6e09d89a8a2efc80888dc#e492c169192f6c62e06a6f8cfe383e56d0e095a3_1_0)
bilal.catic commented 2018-11-02 04:16:16 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26426177&start_sha=72d27bcce8ccc025a5a6e09d89a8a2efc80888dc#587904b417e3b873ff376d53498f8def7970ac14_451_455)
bilal.catic commented 2018-11-02 04:16:16 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26426177&start_sha=72d27bcce8ccc025a5a6e09d89a8a2efc80888dc#a6e8911f24d2b4574727f23d096dc09fbf43d660_1_0)
bilal.catic commented 2018-11-02 04:16:17 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26426177&start_sha=72d27bcce8ccc025a5a6e09d89a8a2efc80888dc#cb0002bfbd9ef01584d268e3998923aae3d6c877_13_0)
bilal.catic commented 2018-11-02 04:16:17 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26426177&start_sha=72d27bcce8ccc025a5a6e09d89a8a2efc80888dc#cb0002bfbd9ef01584d268e3998923aae3d6c877_67_0)
bilal.catic commented 2018-11-02 04:16:17 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26426177&start_sha=72d27bcce8ccc025a5a6e09d89a8a2efc80888dc#9c35fc5ca6b96a5816e0e6703094b02691915507_12_0)
bilal.catic commented 2018-11-02 04:16:17 +01:00 (Migrated from gitlab.com)
Copy Link

added 7 commits

  • ddbee5ad - use existing function to get supplier name
  • 11c0b504 - rename files and classes
  • b6f5ea05 - use order update meta
  • c242b134 - use acf field for additional days prior installation
  • dbfe06ea - move formatting to view
  • 2804ce14 - use taxonomy for supplier id
  • 94a0a0b7 - save items related to supplier in supplier list

Compare with previous version

added 7 commits <ul><li>ddbee5ad - use existing function to get supplier name</li><li>11c0b504 - rename files and classes</li><li>b6f5ea05 - use order update meta</li><li>c242b134 - use acf field for additional days prior installation</li><li>dbfe06ea - move formatting to view</li><li>2804ce14 - use taxonomy for supplier id</li><li>94a0a0b7 - save items related to supplier in supplier list</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26426177&start_sha=72d27bcce8ccc025a5a6e09d89a8a2efc80888dc)
bilal.catic commented 2018-11-03 07:36:15 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26494929&start_sha=94a0a0b7352456678d5284b6456fb78356971150#a7d712d708377ff6a697b64774eb4980b014e639_1_0)
bilal.catic commented 2018-11-03 07:36:15 +01:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26494929&start_sha=94a0a0b7352456678d5284b6456fb78356971150#6a40406376668796d5849a32597d235c24b0a39f_40_0)
bilal.catic commented 2018-11-03 07:36:16 +01:00 (Migrated from gitlab.com)
Copy Link

added 30 commits

  • 94a0a0b7...1ae60eb6 - 9 commits from branch master
  • 69c74d93 - order delivery process
  • b91341c5 - add missing file
  • dbddcd47 - add delivery process
  • 9aa3b3d0 - temporarily remove additional delivery process
  • 1f03563d - replace buttons with dropdown
  • f8dd5f1d - add additional days prior installation field to bundle
  • 9956a94c - remove debugging output
  • e6b6f6c1 - add additional fields to order
  • d6c5a36e - handle delivery schedule dates
  • 9e4ee644 - change style
  • b3ba1889 - use existing function to get supplier name
  • 3e432454 - rename files and classes
  • 8eeb3b99 - use order update meta
  • 3af91a71 - use acf field for additional days prior installation
  • f8e3cc58 - move formatting to view
  • c08c393b - use taxonomy for supplier id
  • a059f4b8 - save items related to supplier in supplier list
  • 2a3f2f82 - fix formatting
  • 93e17817 - move date selection to workflow
  • 01b35dba - rename
  • 24e8515b - show link to delivery process page

Compare with previous version

added 30 commits <ul><li>94a0a0b7...1ae60eb6 - 9 commits from branch <code>master</code></li><li>69c74d93 - order delivery process</li><li>b91341c5 - add missing file</li><li>dbddcd47 - add delivery process</li><li>9aa3b3d0 - temporarily remove additional delivery process</li><li>1f03563d - replace buttons with dropdown</li><li>f8dd5f1d - add additional days prior installation field to bundle</li><li>9956a94c - remove debugging output</li><li>e6b6f6c1 - add additional fields to order</li><li>d6c5a36e - handle delivery schedule dates</li><li>9e4ee644 - change style</li><li>b3ba1889 - use existing function to get supplier name</li><li>3e432454 - rename files and classes</li><li>8eeb3b99 - use order update meta</li><li>3af91a71 - use acf field for additional days prior installation</li><li>f8e3cc58 - move formatting to view</li><li>c08c393b - use taxonomy for supplier id</li><li>a059f4b8 - save items related to supplier in supplier list</li><li>2a3f2f82 - fix formatting</li><li>93e17817 - move date selection to workflow</li><li>01b35dba - rename</li><li>24e8515b - show link to delivery process page</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/49/diffs?diff_id=26494929&start_sha=94a0a0b7352456678d5284b6456fb78356971150)
akrdzic commented 2018-11-03 11:24:43 +01:00 (Migrated from gitlab.com)
Copy Link

merged

merged
akrdzic commented 2018-11-03 11:24:43 +01:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 388f7df8a8

mentioned in commit 388f7df8a892df076448c368d3c04a8664241a83
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#49
Delete Branch "schedule-installation-new"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?