senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Bundle cost summary #35

Merged
akrdzic merged 6 commits from bundle-cost-summary into master 2018-10-19 12:28:25 +02:00
Conversation 9 Commits 6 Files Changed 18 +703 -336
akrdzic commented 2018-10-18 10:02:40 +02:00 (Migrated from gitlab.com)
Copy Link

Bundle cost summary

https://app.asana.com/0/697944902557002/838943199344914

Smoke test:

  1. Login as admin on backend and create a bundle package
  2. Notice that edit price link is present in General tab
  3. Setup bundle items and click on edit link
  4. Validate that all items prices are present in table overview and total cost is calculated
  5. Set commission and pricing types
  6. Save changes
  7. Notice that changes are loaded
  8. Go to packages table list view
  9. Notice Edit price link is present in price column
  10. Click on edit price link
  11. Notice it will take you to prices editor for that package
  12. Set max cost margin so it is lower that total cost
  13. Notice error message is written
  14. Save changes
  15. Go to packages table list i view that package changed status not margin exceeded
  16. Go back to pricing editor and fix max margin so it is lower than total cost
  17. Notice error message is gone
  18. Save changes
  19. Go to table list packages and see package status is now available
**Bundle cost summary** https://app.asana.com/0/697944902557002/838943199344914 Smoke test: 1) Login as admin on backend and create a bundle package 2) Notice that edit price link is present in General tab 3) Setup bundle items and click on edit link 4) Validate that all items prices are present in table overview and total cost is calculated 5) Set commission and pricing types 6) Save changes 7) Notice that changes are loaded 8) Go to packages table list view 9) Notice Edit price link is present in price column 10) Click on edit price link 11) Notice it will take you to prices editor for that package 12) Set max cost margin so it is lower that total cost 13) Notice error message is written 14) Save changes 15) Go to packages table list i view that package changed status not margin exceeded 16) Go back to pricing editor and fix max margin so it is lower than total cost 17) Notice error message is gone 18) Save changes 19) Go to table list packages and see package status is now available
akrdzic commented 2018-10-18 10:04:56 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @nedimu

assigned to @nedimu
akrdzic commented 2018-10-18 10:05:27 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
akrdzic commented 2018-10-18 13:30:48 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !36

mentioned in merge request !36
nedimu commented 2018-10-18 15:36:50 +02:00 (Migrated from gitlab.com)
Copy Link

Step 4 of smoke test failed , there is no calculation of total cost

correct

Step 4 of smoke test failed , there is no calculation of total cost ![correct](/uploads/3f4d365e9ccfad9c871a01f0213625f1/correct.png)
akrdzic commented 2018-10-18 19:01:54 +02:00 (Migrated from gitlab.com)
Copy Link

We figured this out as corrupted package data

We figured this out as corrupted package data
akrdzic commented 2018-10-18 19:02:52 +02:00 (Migrated from gitlab.com)
Copy Link

added 8 commits

  • 6b0dd0b5...315ac704 - 6 commits from branch master
  • 76e9b102 - Merge branch 'master' into bundle-cost-summary
  • 3ccea180 - Merge branch 'master' into bundle-cost-summary

Compare with previous version

added 8 commits <ul><li>6b0dd0b5...315ac704 - 6 commits from branch <code>master</code></li><li>76e9b102 - Merge branch &#39;master&#39; into bundle-cost-summary</li><li>3ccea180 - Merge branch &#39;master&#39; into bundle-cost-summary</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/35/diffs?diff_id=25443315&start_sha=6b0dd0b5a91865aa0629c4f0ed4f001cf00c51c2)
akrdzic commented 2018-10-18 20:02:22 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 67dc8d7d - Hide unused tabs and render only edit link for package prices

Compare with previous version

added 1 commit <ul><li>67dc8d7d - Hide unused tabs and render only edit link for package prices</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/35/diffs?diff_id=25446165&start_sha=3ccea1804e7f0fad2a080dec91a00dda71cc5311)
nedimu commented 2018-10-19 12:28:25 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
nedimu commented 2018-10-19 12:28:25 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 9b5cc3a978

mentioned in commit 9b5cc3a9785a2d2ff78eb98cbba6fb93eb8d89b2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#35
Delete Branch "bundle-cost-summary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?