senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Added manufacturer and supplyer product numbers #30

Merged
nedimu merged 3 commits from simple-product-details into master 2018-10-18 19:00:28 +02:00
Conversation 28 Commits 3 Files Changed 13 +557 -2
nedimu commented 2018-10-10 14:10:16 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

Execude coposer update-db

  • New 'Add New Product' workflow

  1. Go to add new product page

  2. Select product type and country dropdowns should be displayed.

  3. All other product fields should be hidden

  4. Select A product type (choose simple) and a country and click choose

  5. You will need at least 2 simple product with DIFFERENT selected countries to complete this smoke test (old simple products without selected countries will not be searchable until they are edited and counties are added to them)

  • Search by country

  1. Go to add new product page

  2. Select product type and country dropdowns should be displayed.

  3. Select A product type (choose bundle since simple is default) and a country and click choose

  4. The product should be saved and selected country and product type as well and all default product fields shown except new choose country and type dropdown

  5. Go to product bundle search and search for simple products added before

  6. Notice that you can only search the product from the same country the package is from

  • Additional fields

  1. Go to add new simple product page

  2. Under general tab notice that new fields like manufacturer product no, supplier product No are added

  3. Notice that measurement unit taxonomy is added and can be searched under taxonomies

  4. All fields should be saved

Smoke test Execude coposer update-db - New 'Add New Product' workflow 1. Go to add new product page 2. Select product type and country dropdowns should be displayed. 3. All other product fields should be hidden 4. Select A product type (choose simple) and a country and click choose 5. You will need at least 2 simple product with DIFFERENT selected countries to complete this smoke test (old simple products without selected countries will not be searchable until they are edited and counties are added to them) - Search by country 1. Go to add new product page 2. Select product type and country dropdowns should be displayed. 3. Select A product type (choose bundle since simple is default) and a country and click choose 4. The product should be saved and selected country and product type as well and all default product fields shown except new choose country and type dropdown 5. Go to product bundle search and search for simple products added before 6. Notice that you can only search the product from the same country the package is from - Additional fields 1. Go to add new simple product page 2. Under general tab notice that new fields like manufacturer product no, supplier product No are added 3. Notice that measurement unit taxonomy is added and can be searched under taxonomies 4. All fields should be saved
nedimu commented 2018-10-11 12:32:15 +02:00 (Migrated from gitlab.com)
Copy Link

added 4 commits

  • 21709837...089bea5c - 3 commits from branch master
  • 7f166fb6 - Added manufacturer and supplyer product numbers

Compare with previous version

added 4 commits <ul><li>21709837...089bea5c - 3 commits from branch <code>master</code></li><li>7f166fb6 - Added manufacturer and supplyer product numbers</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=24904115&start_sha=2170983771ee595347460e3e369d8457b52f2653)
nedimu commented 2018-10-17 17:31:53 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 4a53d315 - Impleneted search by country, and added mesurment unit

Compare with previous version

added 1 commit <ul><li>4a53d315 - Impleneted search by country, and added mesurment unit</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25331711&start_sha=7f166fb62d44e904154568519e1ea94f0ef8fbf6)
nedimu commented 2018-10-17 17:34:23 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • b9464f03 - Impleneted search by country, and added mesurment unit

Compare with previous version

added 1 commit <ul><li>b9464f03 - Impleneted search by country, and added mesurment unit</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25331860&start_sha=4a53d3155baa0db0a7a3695a730357544e8f4ce4)
nedimu commented 2018-10-18 10:21:07 +02:00 (Migrated from gitlab.com)
Copy Link

added 41 commits

  • b9464f03...ecde654a - 40 commits from branch master
  • fc8692a0 - Impleneted search by country, and added mesurment unit

Compare with previous version

added 41 commits <ul><li>b9464f03...ecde654a - 40 commits from branch <code>master</code></li><li>fc8692a0 - Impleneted search by country, and added mesurment unit</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25392842&start_sha=b9464f0316d3e9b4ea25a1064cff08d3468a0c6d)
nedimu commented 2018-10-18 10:27:54 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 05b79d19 - Impleneted search by country, and added mesurment unit

Compare with previous version

added 1 commit <ul><li>05b79d19 - Impleneted search by country, and added mesurment unit</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25393955&start_sha=fc8692a09169040746329486217e26af4f3be96a)
nedimu commented 2018-10-18 10:47:21 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2018-10-18 10:47:37 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @akrdzic

assigned to @akrdzic
nedimu commented 2018-10-18 10:59:35 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 0325a6ea - Deleted error logs

Compare with previous version

added 1 commit <ul><li>0325a6ea - Deleted error logs</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25397176&start_sha=05b79d19d73673fde0a2d8e2b493adba243168ee)
akrdzic commented 2018-10-18 11:16:09 +02:00 (Migrated from gitlab.com)
Copy Link

Move this product creating logic to separate file

Move this product creating logic to separate file
nedimu commented 2018-10-18 11:20:53 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
akrdzic commented 2018-10-18 11:22:42 +02:00 (Migrated from gitlab.com)
Copy Link

I can see other fields on create product page:

Selection_038

I can see other fields on create product page: ![Selection_038](/uploads/7f5162dda980d34cfdcf5d899319993a/Selection_038.png)
akrdzic commented 2018-10-18 11:39:14 +02:00 (Migrated from gitlab.com)
Copy Link

Manufacturear Product No and Supplier Product No are restricted to number entry ony.
They should probably be text fields.

Manufacturear Product No and Supplier Product No are restricted to number entry ony. They should probably be text fields.
akrdzic commented 2018-10-18 11:44:15 +02:00 (Migrated from gitlab.com)
Copy Link

Since right side of the screen looks scary we could have all simple product taxonomies in one field group that is only visible if product type is simple to clean up this right side.

Selection_039

Since right side of the screen looks scary we could have all simple product taxonomies in one field group that is only visible if product type is simple to clean up this right side. ![Selection_039](/uploads/45f5a04232455f72b0b5055392ab1299/Selection_039.png)
akrdzic commented 2018-10-18 11:54:45 +02:00 (Migrated from gitlab.com)
Copy Link

Manufacturer product No and Supplier product No visible for bundle
Selection_041

Manufacturer product No and Supplier product No visible for bundle ![Selection_041](/uploads/b37ef300815a49cf4d704c9f33eca343/Selection_041.png)
akrdzic commented 2018-10-18 12:09:15 +02:00 (Migrated from gitlab.com)
Copy Link

Issue while creating new product. If I change title and then choose country I get notification that
changes my not be saved.

use

 <div id="submitpost" style="padding: 20px;">
                <input style="float:right;" name="save" id="save-post" class="button" type="submit" value="Choose"/>
            </div>

format for choose button to avoid this (this is format from Save Draft button)

Issue while creating new product. If I change title and then choose country I get notification that changes my not be saved. use ``` <div id="submitpost" style="padding: 20px;"> <input style="float:right;" name="save" id="save-post" class="button" type="submit" value="Choose"/> </div> ``` format for choose button to avoid this (this is format from `Save Draft` button)
akrdzic commented 2018-10-18 12:12:27 +02:00 (Migrated from gitlab.com)
Copy Link

check if term exits with has_term and then insert it if not

check if term exits with `has_term` and then insert it if not
akrdzic commented 2018-10-18 13:30:48 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !36

mentioned in merge request !36
nedimu commented 2018-10-18 14:09:29 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25414550&start_sha=0325a6eaeeabeb682649d31b0a15f72023032cae#1aa1c2eb8c8492993a63c4ad11f2f2784634edbf_11_9)
nedimu commented 2018-10-18 14:09:30 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • f6a459e8 - Added product taxonomies with ACF plugin

Compare with previous version

added 1 commit <ul><li>f6a459e8 - Added product taxonomies with ACF plugin</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25414550&start_sha=0325a6eaeeabeb682649d31b0a15f72023032cae)
nedimu commented 2018-10-18 14:35:08 +02:00 (Migrated from gitlab.com)
Copy Link

term_exists is the correct method to use here

`term_exists` is the correct method to use here
nedimu commented 2018-10-18 14:36:50 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25416518&start_sha=f6a459e81788a9caf0e68676f8e06681b2a1a6f7#53849779dfcdfe4b1fbbd088fa9b1754f46bd940_76_76)
nedimu commented 2018-10-18 14:36:50 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 01951af9 - Fixed additional simple product properties appiering in other product types

Compare with previous version

added 1 commit <ul><li>01951af9 - Fixed additional simple product properties appiering in other product types</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25416518&start_sha=f6a459e81788a9caf0e68676f8e06681b2a1a6f7)
nedimu commented 2018-10-18 16:17:38 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 942c4c80 - Impleneted search by country, and added mesurment unit

Compare with previous version

added 1 commit <ul><li>942c4c80 - Impleneted search by country, and added mesurment unit</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25429987&start_sha=01951af99f1f85fa01055605a5bed9849d5f3804)
nedimu commented 2018-10-18 16:45:39 +02:00 (Migrated from gitlab.com)
Copy Link

added 9 commits

  • 942c4c80...c8ed5f7f - 8 commits from branch master
  • 071c5497 - Impleneted search by country, and added mesurment unit

Compare with previous version

added 9 commits <ul><li>942c4c80...c8ed5f7f - 8 commits from branch <code>master</code></li><li>071c5497 - Impleneted search by country, and added mesurment unit</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25434377&start_sha=942c4c808bad33d56afd541427d76115813a3522)
nedimu commented 2018-10-18 17:28:38 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>00e853ae - Fixed product status issue</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25437890&start_sha=071c54972658927198a13e64a54bb3b8e15577f2)
nedimu commented 2018-10-18 17:30:49 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • c4cddf8a - Added comment to save post method

Compare with previous version

added 1 commit <ul><li>c4cddf8a - Added comment to save post method</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/30/diffs?diff_id=25438060&start_sha=00e853ae6bb6e804f7dc99d6bd5aebc8fc0601c7)
akrdzic commented 2018-10-18 19:00:28 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 315ac70484

mentioned in commit 315ac7048415936f1eed8e4e8a8ab72d66bb0efc
akrdzic commented 2018-10-18 19:00:28 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#30
Delete Branch "simple-product-details"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?