senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Templates refactoring #26

Merged
nedimu merged 10 commits from package-template-refactoring into master 2018-10-04 13:21:17 +02:00
Conversation 22 Commits 10 Files Changed 8 +338 -249
nedimu commented 2018-09-26 13:57:55 +02:00 (Migrated from gitlab.com)
Copy Link
No description provided.
nedimu commented 2018-09-26 14:29:31 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 80817ce3 - Removed uneccesary code from wiaas admin panels.js

Compare with previous version

added 1 commit <ul><li>80817ce3 - Removed uneccesary code from wiaas admin panels.js</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=23949248&start_sha=e399dc7c3c94b6fe93a04c4ba16065b2e90b8030)
nedimu commented 2018-09-27 15:08:42 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • bd95b641 - Refactored template product feature

Compare with previous version

added 1 commit <ul><li>bd95b641 - Refactored template product feature</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24038801&start_sha=80817ce37d71f5dc62b33f13a743ec281e3c2e78)
nedimu commented 2018-09-27 15:10:46 +02:00 (Migrated from gitlab.com)
Copy Link

added 16 commits

  • bd95b641...6afffc7e - 14 commits from branch master
  • 21d96a0e - Removed uneccesary code from wiaas admin panels.js
  • 93d03a96 - Refactored template product feature

Compare with previous version

added 16 commits <ul><li>bd95b641...6afffc7e - 14 commits from branch <code>master</code></li><li>21d96a0e - Removed uneccesary code from wiaas admin panels.js</li><li>93d03a96 - Refactored template product feature</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24038961&start_sha=bd95b6413ec726869dd3f13ac6e528dc559922c0)
nedimu commented 2018-09-28 14:24:57 +02:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

Compare with previous version

added 2 commits <ul><li>6f6fb111 - renamed variables to</li><li>f1c99c28 - Added documentation to methods</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24116660&start_sha=93d03a96eea9c6529f04227b0baf7f91fac29fd8)
nedimu commented 2018-10-01 17:03:36 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 4c760b12 - Added unit tests for templates

Compare with previous version

added 1 commit <ul><li>4c760b12 - Added unit tests for templates</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24252581&start_sha=f1c99c28ae975309c1a2748d5ab13a9e88ac96c5)
nedimu commented 2018-10-01 17:06:34 +02:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
nedimu commented 2018-10-01 17:08:54 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @akrdzic

assigned to @akrdzic
akrdzic commented 2018-10-03 16:56:39 +02:00 (Migrated from gitlab.com)
Copy Link

Remove error logs

Remove error logs
nedimu commented 2018-10-03 16:59:15 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24414631&start_sha=4c760b12c3ba89a29eb5001c5a38fac88127335d#1f8bc9064b8c011e89270223302203b7fa68c73d_84_83)
nedimu commented 2018-10-03 16:59:20 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b028fb3f - Removed error log</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24414631&start_sha=4c760b12c3ba89a29eb5001c5a38fac88127335d)
akrdzic commented 2018-10-03 17:29:48 +02:00 (Migrated from gitlab.com)
Copy Link

Because of this typo template categories for template are not correctly saved!

Because of it template validation always returns false.

Because of this typo template categories for template are not correctly saved! Because of it template validation always returns false.
akrdzic commented 2018-10-03 17:32:32 +02:00 (Migrated from gitlab.com)
Copy Link

Here you are using static call for method that is not declared as static. It should probably be declared static.

Here you are using static call for method that is not declared as static. It should probably be declared static.
nedimu commented 2018-10-04 10:51:27 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24454690&start_sha=b028fb3f04376af4048100aefd23ab008d17ecd9#1f8bc9064b8c011e89270223302203b7fa68c73d_60_60)
nedimu commented 2018-10-04 10:51:28 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 7ceac97f - Fixed template validation bug

Compare with previous version

added 1 commit <ul><li>7ceac97f - Fixed template validation bug</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24454690&start_sha=b028fb3f04376af4048100aefd23ab008d17ecd9)
akrdzic commented 2018-10-04 11:50:52 +02:00 (Migrated from gitlab.com)
Copy Link

After i saved templates with 'A' category under Installation and 'B' category under Service they got
saved under wrong type ('A' under Service and 'B' under Installation.

After i saved templates with 'A' category under Installation and 'B' category under Service they got saved under wrong type ('A' under Service and 'B' under Installation.
akrdzic commented 2018-10-04 11:51:11 +02:00 (Migrated from gitlab.com)
Copy Link

If I save multiple categories under Service only one gets saved.

If I save multiple categories under Service only one gets saved.
nedimu commented 2018-10-04 12:41:26 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • c5c07cbf - Fixed bug where template categoryes are not save properly in template

Compare with previous version

added 1 commit <ul><li>c5c07cbf - Fixed bug where template categoryes are not save properly in template</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24468215&start_sha=7ceac97fed838a7e90480002e1852116ed172658)
akrdzic commented 2018-10-04 12:50:59 +02:00 (Migrated from gitlab.com)
Copy Link

Services not listed when template is selected.

Services not listed when template is selected.
nedimu commented 2018-10-04 12:54:39 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f41252ea - Services not listed bug fix</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24469066&start_sha=c5c07cbfaef8e5e2180474b3f7ea63624801dbb4)
nedimu commented 2018-10-04 13:15:17 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c102b6a5 - Fixed template selection bug</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/26/diffs?diff_id=24476938&start_sha=f41252ea23a5f4ad1fad5bc0449824f33739c22b)
akrdzic commented 2018-10-04 13:21:17 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
akrdzic commented 2018-10-04 13:21:17 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit c537557daf

mentioned in commit c537557daf3193477f05b65894b6629007682d28
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#26
Delete Branch "package-template-refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?