senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Replaced login screen with loader, wile validating access token #24

Merged
nedimu merged 2 commits from login-bug into master 2018-09-26 16:02:32 +02:00
Conversation 8 Commits 2 Files Changed 4 +45 -18
nedimu commented 2018-09-24 15:56:05 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

When not logged in, everything stays the same as before (login page shown)
When logged in , a loader will show instead of login screen, after token validation request is complete contentComponent is shown

Smoke test When not logged in, everything stays the same as before (login page shown) When logged in , a loader will show instead of login screen, after token validation request is complete contentComponent is shown
nedimu commented 2018-09-24 15:56:36 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @akrdzic

assigned to @akrdzic
nedimu commented 2018-09-24 16:01:04 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2018-09-24 16:11:18 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 9c4539ac - Replaced login screen with loader, wile validating access token

Compare with previous version

added 1 commit <ul><li>9c4539ac - Replaced login screen with loader, wile validating access token</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/24/diffs?diff_id=23792343&start_sha=1e1405aa50e4257ba8e85e35d0244346c05de2ba)
akrdzic commented 2018-09-24 23:59:58 +02:00 (Migrated from gitlab.com)
Copy Link

Can this loader be smaller. It is too large and it could be smaller by a half size.

Can this loader be smaller. It is too large and it could be smaller by a half size.
nedimu commented 2018-09-25 11:38:52 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>eab040b1 - Reduced loader size</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/24/diffs?diff_id=23845661&start_sha=9c4539acfecd1ad484184ff95b63577c3683efa3)
nedimu commented 2018-09-25 11:39:19 +02:00 (Migrated from gitlab.com)
Copy Link

Loader size fixed

Loader size fixed
akrdzic commented 2018-09-26 16:02:32 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
akrdzic commented 2018-09-26 16:02:33 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit aa8aa42164

mentioned in commit aa8aa4216486f49799627ab8d7e7f4cfe86d62fe
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#24
Delete Branch "login-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?