senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Frontend orders/number #13

Merged
bilal.catic merged 53 commits from frontend-orders/number into master 2018-08-29 13:06:02 +02:00
Conversation 23 Commits 53 Files Changed 35 +1632 -588
bilal.catic commented 2018-08-23 08:53:44 +02:00 (Migrated from gitlab.com)
Copy Link

SMOKE TEST:

  1. Create order as customer
  2. Login to frontend using same customer
  3. Open details of newly created order
  4. Make sure details are shown correctly
  5. Scroll down to process info, only one step should be visible
  6. Open WP admin panel, go to workflow inbox
  7. Approve steps until customer input is next
  8. Open frontend again, check process on order details page
  9. Try to accept installation, it should not be allowed
  10. Upload file
  11. try to decline installation, comment should be shown and status should be changed
  12. Accept installation
  13. Open WP admin panel, go to workflow inbox, check user input and accept
  14. On frontend, process should show next step
  15. Switch to packages tab, check if they are shown correctly
  16. Switch to comments, leave comment as customer
  17. Login as wpUser, leave comment as wpUser, comment's should have different styles and show user names

Run unit tests.

Note 1 : Documents tab on order details page is empty as I thought to wait until package documents are available and then to show them.

Note 2 : I had to bypass test of customer acceptance upload (actually part of it), since there is security check in built-in method to verify if user uploaded file.

Note 3 : Uploaded files for customer acceptance are shown, but at the moment they cannot be downloaded by clicking on frontend, their URL is world accessible

SMOKE TEST: 1. Create order as customer 2. Login to frontend using same customer 3. Open details of newly created order 4. Make sure details are shown correctly 5. Scroll down to process info, only one step should be visible 6. Open WP admin panel, go to workflow inbox 7. Approve steps until customer input is next 8. Open frontend again, check process on order details page 9. Try to accept installation, it should not be allowed 10. Upload file 11. try to decline installation, comment should be shown and status should be changed 12. Accept installation 13. Open WP admin panel, go to workflow inbox, check user input and accept 14. On frontend, process should show next step 15. Switch to packages tab, check if they are shown correctly 16. Switch to comments, leave comment as customer 17. Login as wpUser, leave comment as wpUser, comment's should have different styles and show user names Run unit tests. Note 1 : Documents tab on order details page is empty as I thought to wait until package documents are available and then to show them. Note 2 : I had to bypass test of customer acceptance upload (actually part of it), since there is security check in built-in method to verify if user uploaded file. Note 3 : Uploaded files for customer acceptance are shown, but at the moment they cannot be downloaded by clicking on frontend, their URL is world accessible
bilal.catic commented 2018-08-23 15:39:57 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
akrdzic commented 2018-08-24 16:09:13 +02:00 (Migrated from gitlab.com)
Copy Link

Seems that ids used for editing delivery process entries fields are other than ones currently deployed. This should probably be solved with new migration of delivery process steps forms because currently document upload does not work correctly because of this.

Seems that ids used for editing delivery process entries fields are other than ones currently deployed. This should probably be solved with new migration of delivery process steps forms because currently document upload does not work correctly because of this.
akrdzic commented 2018-08-26 17:23:44 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • c7bdab0a - Use order notes for comments

Compare with previous version

added 1 commit <ul><li>c7bdab0a - Use order notes for comments</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=21862771&start_sha=8a4a40ba1499b60e8a05bb84653ecae503df9a2d)
akrdzic commented 2018-08-26 19:08:43 +02:00 (Migrated from gitlab.com)
Copy Link

For what are these gravity-form-entry endpoints used?
If they must be present let us instead of gravity-form-entry used delivery-process-step/[step_id]

For what are these `gravity-form-entry` endpoints used? If they must be present let us instead of `gravity-form-entry` used `delivery-process-step/[step_id]`
akrdzic commented 2018-08-26 19:11:04 +02:00 (Migrated from gitlab.com)
Copy Link

use permission_callback for api endpoint

use `permission_callback` for api endpoint
akrdzic commented 2018-08-26 19:11:34 +02:00 (Migrated from gitlab.com)
Copy Link

Also use permission_callback for api

Also use `permission_callback` for api
akrdzic commented 2018-08-26 19:12:49 +02:00 (Migrated from gitlab.com)
Copy Link

Use gravity flow Orchestration API instead of manually changing these properties

Use gravity flow [Orchestration API](https://docs.gravityflow.io/article/90-workflow-orchestration-api) instead of manually changing these properties
akrdzic commented 2018-08-26 19:13:44 +02:00 (Migrated from gitlab.com)
Copy Link

Refactor this code a little bit. There is no need for this much if else cases when return statement is used.

Refactor this code a little bit. There is no need for this much if else cases when return statement is used.
akrdzic commented 2018-08-26 19:14:21 +02:00 (Migrated from gitlab.com)
Copy Link

Also use permission_callback for api

Also use `permission_callback` for api
bilal.catic commented 2018-08-27 17:53:05 +02:00 (Migrated from gitlab.com)
Copy Link

resolved all discussions

resolved all discussions
bilal.catic commented 2018-08-27 23:32:49 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=21930633&start_sha=c7bdab0aaec5ef203ae95959a8a78d9b6f4df687#34d9d4c8aaa5934a9d232ff0bcce0c22fd5a15ee_40_42)
bilal.catic commented 2018-08-27 23:32:49 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=21930633&start_sha=c7bdab0aaec5ef203ae95959a8a78d9b6f4df687#34d9d4c8aaa5934a9d232ff0bcce0c22fd5a15ee_110_102)
bilal.catic commented 2018-08-27 23:32:50 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=21930633&start_sha=c7bdab0aaec5ef203ae95959a8a78d9b6f4df687#34d9d4c8aaa5934a9d232ff0bcce0c22fd5a15ee_148_144)
bilal.catic commented 2018-08-27 23:32:50 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=21930633&start_sha=c7bdab0aaec5ef203ae95959a8a78d9b6f4df687#34d9d4c8aaa5934a9d232ff0bcce0c22fd5a15ee_174_171)
bilal.catic commented 2018-08-27 23:32:51 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=21930633&start_sha=c7bdab0aaec5ef203ae95959a8a78d9b6f4df687#34d9d4c8aaa5934a9d232ff0bcce0c22fd5a15ee_180_171)
bilal.catic commented 2018-08-27 23:32:51 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=21930633&start_sha=c7bdab0aaec5ef203ae95959a8a78d9b6f4df687#34d9d4c8aaa5934a9d232ff0bcce0c22fd5a15ee_191_175)
bilal.catic commented 2018-08-27 23:32:51 +02:00 (Migrated from gitlab.com)
Copy Link

added 48 commits

  • c7bdab0a...ff166988 - 2 commits from branch master
  • f25901d9 - display billing info in details
  • d3c43164 - add new fields to customer acceptance form
  • fb79ee9d - add custom endpoints for customer acceptance
  • cbd1ed92 - use custom endpoints for customer acceptance
  • bf42c772 - change endpoints for order details, comments and documents
  • ae7927f5 - use new object properties for orders and process
  • 3d097a85 - add new css class for new status
  • ea44ec4f - change file upload data
  • d1aad537 - add helper functions for order and process object transformations
  • 240a3af5 - add commercial lead ID
  • e61f784f - comment function used for testing
  • 9d70fd2d - change comments handling
  • 7824cbcc - remove hardcoded values and change comment handling
  • 7783a598 - use new object property names
  • f336c7aa - use defined value from WP_HOME instead of hardcoded value
  • 717fd783 - check comment owner by username
  • 8980c8b2 - remove customer acceptance expiration
  • 3d6ccfd3 - allow api access only to logged in users
  • 60a69d9a - use constants; send message objects instead of strings
  • af4c667c - display returned message
  • 16dbff15 - add new constants
  • cde14e5e - remove unused constant
  • e83d950e - comment unused code for now
  • b1d372f1 - rename function
  • bb9cbf38 - fix bug with non existing entry
  • f7aaf8e8 - install guzzle
  • e522dfdb - remove unused function
  • b9f8db92 - add tests for getting cust acceptance, submit cust acceptance
  • 3f7aa8cf - added dummy files used for upload testing
  • bfcb27e5 - added unit tests for customer acceptance endpoints
  • c333be91 - refactoring and minor bug fixes
  • 18430bb8 - define test in progress indicator
  • 7cd6a5df - Use order notes for comments
  • 145bf47a - comment function used for testing
  • 03c27a13 - change comments handling
  • 8777377a - remove hardcoded values and change comment handling
  • 5fd4bd56 - check comment owner by username
  • ffb21e6e - allow api access only to logged in users
  • f4117682 - install guzzle
  • 8b189eb1 - fix merge
  • 5ed6f807 - use Orchestration API to complete GF step
  • 1aa22327 - improve code quality
  • 623b088e - change tests accoring to changes in delivery process api
  • 41de0521 - Create link to customer acceptance documents
  • ac93a06b - improve code quality
  • 0d9ba5d8 - do not submit custommer acceptance if already submitted

Compare with previous version

added 48 commits <ul><li>c7bdab0a...ff166988 - 2 commits from branch <code>master</code></li><li>f25901d9 - display billing info in details</li><li>d3c43164 - add new fields to customer acceptance form</li><li>fb79ee9d - add custom endpoints for customer acceptance</li><li>cbd1ed92 - use custom endpoints for customer acceptance</li><li>bf42c772 - change endpoints for order details, comments and documents</li><li>ae7927f5 - use new object properties for orders and process</li><li>3d097a85 - add new css class for new status</li><li>ea44ec4f - change file upload data</li><li>d1aad537 - add helper functions for order and process object transformations</li><li>240a3af5 - add commercial lead ID</li><li>e61f784f - comment function used for testing</li><li>9d70fd2d - change comments handling</li><li>7824cbcc - remove hardcoded values and change comment handling</li><li>7783a598 - use new object property names</li><li>f336c7aa - use defined value from WP_HOME instead of hardcoded value</li><li>717fd783 - check comment owner by username</li><li>8980c8b2 - remove customer acceptance expiration</li><li>3d6ccfd3 - allow api access only to logged in users</li><li>60a69d9a - use constants; send message objects instead of strings</li><li>af4c667c - display returned message</li><li>16dbff15 - add new constants</li><li>cde14e5e - remove unused constant</li><li>e83d950e - comment unused code for now</li><li>b1d372f1 - rename function</li><li>bb9cbf38 - fix bug with non existing entry</li><li>f7aaf8e8 - install guzzle</li><li>e522dfdb - remove unused function</li><li>b9f8db92 - add tests for getting cust acceptance, submit cust acceptance</li><li>3f7aa8cf - added dummy files used for upload testing</li><li>bfcb27e5 - added unit tests for customer acceptance endpoints</li><li>c333be91 - refactoring and minor bug fixes</li><li>18430bb8 - define test in progress indicator</li><li>7cd6a5df - Use order notes for comments</li><li>145bf47a - comment function used for testing</li><li>03c27a13 - change comments handling</li><li>8777377a - remove hardcoded values and change comment handling</li><li>5fd4bd56 - check comment owner by username</li><li>ffb21e6e - allow api access only to logged in users</li><li>f4117682 - install guzzle</li><li>8b189eb1 - fix merge</li><li>5ed6f807 - use Orchestration API to complete GF step</li><li>1aa22327 - improve code quality</li><li>623b088e - change tests accoring to changes in delivery process api</li><li>41de0521 - Create link to customer acceptance documents</li><li>ac93a06b - improve code quality</li><li>0d9ba5d8 - do not submit custommer acceptance if already submitted</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=21930633&start_sha=c7bdab0aaec5ef203ae95959a8a78d9b6f4df687)
bilal.catic commented 2018-08-29 10:03:03 +02:00 (Migrated from gitlab.com)
Copy Link

added 52 commits

  • 0d9ba5d8...beccc711 - 4 commits from branch master
  • 0c15e719 - display billing info in details
  • a03832df - add new fields to customer acceptance form
  • aa4a3daa - add custom endpoints for customer acceptance
  • 04c7a753 - use custom endpoints for customer acceptance
  • 8b5374ee - change endpoints for order details, comments and documents
  • 672fb627 - use new object properties for orders and process
  • beea3c95 - add new css class for new status
  • b923b353 - change file upload data
  • aef9bc5b - add helper functions for order and process object transformations
  • a9bcd987 - add commercial lead ID
  • 152804d6 - comment function used for testing
  • 768e3b91 - change comments handling
  • 5399e390 - remove hardcoded values and change comment handling
  • 74a6905a - use new object property names
  • 30faf9a9 - use defined value from WP_HOME instead of hardcoded value
  • 9134a44a - check comment owner by username
  • 5c91a57d - remove customer acceptance expiration
  • 46e51111 - allow api access only to logged in users
  • 0a5d69f6 - use constants; send message objects instead of strings
  • 936193ba - display returned message
  • c459382d - add new constants
  • 62c14fe1 - remove unused constant
  • b54512b1 - comment unused code for now
  • 75416137 - rename function
  • af482104 - fix bug with non existing entry
  • 902df876 - install guzzle
  • b49c1cb8 - remove unused function
  • 864134e6 - add tests for getting cust acceptance, submit cust acceptance
  • 5b3af2f9 - added dummy files used for upload testing
  • 8e490ac6 - added unit tests for customer acceptance endpoints
  • 1db017a2 - refactoring and minor bug fixes
  • bd1d8f21 - define test in progress indicator
  • 54e64957 - Use order notes for comments
  • 906725f5 - comment function used for testing
  • 1e237309 - change comments handling
  • fed5ecaf - remove hardcoded values and change comment handling
  • b18a8779 - check comment owner by username
  • ba99d85c - allow api access only to logged in users
  • ed23a872 - install guzzle
  • f33da62d - fix merge
  • 3419f2bd - use Orchestration API to complete GF step
  • 1368f1b6 - improve code quality
  • 769c8c01 - change tests accoring to changes in delivery process api
  • 9958d411 - Create link to customer acceptance documents
  • 9f653bb9 - improve code quality
  • 2d24f826 - do not submit custommer acceptance if already submitted
  • 684c06df - remove guzzle, it's not used
  • b99a0cb8 - fix comment style

Compare with previous version

added 52 commits <ul><li>0d9ba5d8...beccc711 - 4 commits from branch <code>master</code></li><li>0c15e719 - display billing info in details</li><li>a03832df - add new fields to customer acceptance form</li><li>aa4a3daa - add custom endpoints for customer acceptance</li><li>04c7a753 - use custom endpoints for customer acceptance</li><li>8b5374ee - change endpoints for order details, comments and documents</li><li>672fb627 - use new object properties for orders and process</li><li>beea3c95 - add new css class for new status</li><li>b923b353 - change file upload data</li><li>aef9bc5b - add helper functions for order and process object transformations</li><li>a9bcd987 - add commercial lead ID</li><li>152804d6 - comment function used for testing</li><li>768e3b91 - change comments handling</li><li>5399e390 - remove hardcoded values and change comment handling</li><li>74a6905a - use new object property names</li><li>30faf9a9 - use defined value from WP_HOME instead of hardcoded value</li><li>9134a44a - check comment owner by username</li><li>5c91a57d - remove customer acceptance expiration</li><li>46e51111 - allow api access only to logged in users</li><li>0a5d69f6 - use constants; send message objects instead of strings</li><li>936193ba - display returned message</li><li>c459382d - add new constants</li><li>62c14fe1 - remove unused constant</li><li>b54512b1 - comment unused code for now</li><li>75416137 - rename function</li><li>af482104 - fix bug with non existing entry</li><li>902df876 - install guzzle</li><li>b49c1cb8 - remove unused function</li><li>864134e6 - add tests for getting cust acceptance, submit cust acceptance</li><li>5b3af2f9 - added dummy files used for upload testing</li><li>8e490ac6 - added unit tests for customer acceptance endpoints</li><li>1db017a2 - refactoring and minor bug fixes</li><li>bd1d8f21 - define test in progress indicator</li><li>54e64957 - Use order notes for comments</li><li>906725f5 - comment function used for testing</li><li>1e237309 - change comments handling</li><li>fed5ecaf - remove hardcoded values and change comment handling</li><li>b18a8779 - check comment owner by username</li><li>ba99d85c - allow api access only to logged in users</li><li>ed23a872 - install guzzle</li><li>f33da62d - fix merge</li><li>3419f2bd - use Orchestration API to complete GF step</li><li>1368f1b6 - improve code quality</li><li>769c8c01 - change tests accoring to changes in delivery process api</li><li>9958d411 - Create link to customer acceptance documents</li><li>9f653bb9 - improve code quality</li><li>2d24f826 - do not submit custommer acceptance if already submitted</li><li>684c06df - remove guzzle, it&#39;s not used</li><li>b99a0cb8 - fix comment style</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=22023619&start_sha=0d9ba5d8cbefa2b190d92ec87d13215a9a881c6e)
bilal.catic commented 2018-08-29 10:52:29 +02:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • a8e3522e - open document in new tab
  • 2cb32dca - temporarily disable fetching documents and validation comments

Compare with previous version

added 2 commits <ul><li>a8e3522e - open document in new tab</li><li>2cb32dca - temporarily disable fetching documents and validation comments</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=22030933&start_sha=b99a0cb8564cafc61addb10ee29018df538b675f)
akrdzic commented 2018-08-29 11:37:53 +02:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 057a99b8 - Show additional info on workflow inbox page
  • fc987354 - Merge branch 'frontend-orders/number' of gitlab.com:saburly/wiaas/new-wiaas into…

Compare with previous version

added 2 commits <ul><li>057a99b8 - Show additional info on workflow inbox page</li><li>fc987354 - Merge branch &#39;frontend-orders/number&#39; of gitlab.com:saburly/wiaas/new-wiaas into…</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=22034586&start_sha=2cb32dca31c1159cff9655ea3eefdf6b8226a2b0)
akrdzic commented 2018-08-29 13:02:31 +02:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 23794a8f - Handle display for workflow inbox page

Compare with previous version

added 1 commit <ul><li>23794a8f - Handle display for workflow inbox page</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/13/diffs?diff_id=22040700&start_sha=fc98735434990a8e3ec9b0b2dff1919d3e665905)
akrdzic commented 2018-08-29 13:06:02 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
akrdzic commented 2018-08-29 13:06:10 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit ff4430e503

mentioned in commit ff4430e503d839a7a7599e3a7a4edc7d82e9d35e
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#13
Delete Branch "frontend-orders/number"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?