senaduka/old-new-wiaas
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Connected and enabled co-maket #10

Merged
nedimu merged 2 commits from co-market into master 2018-08-09 14:37:35 +02:00
Conversation 10 Commits 2 Files Changed 6 +184 -195
nedimu commented 2018-08-08 14:40:56 +02:00 (Migrated from gitlab.com)
Copy Link

Smoke test

Add some product on https://localhost/wp/wp-admin/edit.php?post_type=product
Make sure that you add different tiles for products so they can be searchable

Login to frontend and go to http://localhost:3001/co-market

The commercial lead is currently hardcoded since there is not support for that on backend.

Expected:

  1. Products from API need to be shown
  2. Product from API can be searched
  3. Default woocomerce image is shown for product background
  4. Link to product details is /co-market{commercialLeatId}/{productId} (showing product details in that link is part of another ticket)
  5. Link to orders should work (showing orders in that link is part of another ticket)
Smoke test Add some product on https://localhost/wp/wp-admin/edit.php?post_type=product Make sure that you add different tiles for products so they can be searchable Login to frontend and go to http://localhost:3001/co-market The commercial lead is currently hardcoded since there is not support for that on backend. Expected: 1) Products from API need to be shown 2) Product from API can be searched 3) Default woocomerce image is shown for product background 4) Link to product details is /co-market{commercialLeatId}/{productId} (showing product details in that link is part of another ticket) 5) Link to orders should work (showing orders in that link is part of another ticket)
nedimu commented 2018-08-08 14:43:05 +02:00 (Migrated from gitlab.com)
Copy Link

added 6 commits

  • 024d77de...c1834f67 - 5 commits from branch master
  • 6e0c26df - Connected and enabled co-maket

Compare with previous version

added 6 commits <ul><li>024d77de...c1834f67 - 5 commits from branch <code>master</code></li><li>6e0c26df - Connected and enabled co-maket</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/10/diffs?diff_id=20979334&start_sha=024d77de6092a40003eeb112db704dd5bd020d9a)
nedimu commented 2018-08-08 15:05:21 +02:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
nedimu commented 2018-08-08 15:05:21 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @akrdzic

assigned to @akrdzic
akrdzic commented 2018-08-08 15:49:29 +02:00 (Migrated from gitlab.com)
Copy Link

What about this a letter here?

What about this `a` letter here?
akrdzic commented 2018-08-08 18:27:14 +02:00 (Migrated from gitlab.com)
Copy Link

Please resolve merge conflicts to master branch.

Please resolve merge conflicts to master branch.
nedimu commented 2018-08-09 11:58:03 +02:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/10/diffs?diff_id=21025269&start_sha=6e0c26df5f03d9d47579eb73ae1d6a93d4ccf441#7c51f6308634e5e88ab83be2a31b821c0820abd8_49_49)
nedimu commented 2018-08-09 11:58:06 +02:00 (Migrated from gitlab.com)
Copy Link

added 22 commits

  • 6e0c26df...5d84f53e - 20 commits from branch master
  • 0b899c09 - Connected and enabled co-maket
  • 7c5a97b7 - Resolved conflict

Compare with previous version

added 22 commits <ul><li>6e0c26df...5d84f53e - 20 commits from branch <code>master</code></li><li>0b899c09 - Connected and enabled co-maket</li><li>7c5a97b7 - Resolved conflict</li></ul> [Compare with previous version](https://gitlab.com/saburly/wiaas/new-wiaas/merge_requests/10/diffs?diff_id=21025269&start_sha=6e0c26df5f03d9d47579eb73ae1d6a93d4ccf441)
akrdzic commented 2018-08-09 12:40:59 +02:00 (Migrated from gitlab.com)
Copy Link

Issues:

  1. Smoke test for customer is failing since has no capabilities to read products

  2. I made three products where two were restricted only for administrators but I could see all of them in co-market when logged in as customer.

Issues: 1) Smoke test for customer is failing since has no capabilities to read products 2) I made three products where two were restricted only for administrators but I could see all of them in co-market when logged in as customer.
nedimu commented 2018-08-09 14:37:35 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
nedimu commented 2018-08-09 14:37:37 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 0993e474c9

mentioned in commit 0993e474c9615790b9d7f777c8341aeba73fcddc
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-new-wiaas#10
Delete Branch "co-market"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?