senaduka/old-krovovi-kalkulator
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Mounting parts removal #5

Closed
senaduka wants to merge 4 commits from mounting-parts-removal into master
pull from: mounting-parts-removal
merge into: senaduka:master
Conversation 2 Commits 4 Files Changed 4 +66 -12
senaduka commented 2017-11-15 20:51:57 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: GotPPay

*Created by: GotPPay*
senaduka commented 2017-11-16 07:41:36 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: senaduka

never catch all exceptions without logging - disaster can happen that leads to days of debugging

*Created by: senaduka* never catch all exceptions without logging - disaster can happen that leads to days of debugging
senaduka commented 2017-11-16 07:42:33 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: senaduka

this could be just
is_delta = (self.values.inverter_brands()[0]['inverter_brand_id']==InverterBrand.DELTA.value)
no need for if else

*Created by: senaduka* this could be just is_delta = (self.values.inverter_brands()[0]['inverter_brand_id']==InverterBrand.DELTA.value) no need for if else

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-krovovi-kalkulator#5
Delete Branch "mounting-parts-removal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?