senaduka/old-kivi
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Rental crawler #2

Merged
senaduka merged 6 commits from rental-crawler into master 2017-11-02 21:37:02 +01:00
Conversation 7 Commits 6 Files Changed 25 +8629 -6334
senaduka commented 2017-10-16 11:38:21 +02:00 (Migrated from gitlab.com)
Copy Link

Created by: GotPPay

*Created by: GotPPay*
senaduka commented 2017-10-31 14:23:16 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: edazdarevic

In Javascript we should use camelCase instead of snake_case. It should be hasMap

*Created by: edazdarevic* In Javascript we should use camelCase instead of snake_case. It should be `hasMap`
senaduka commented 2017-10-31 14:24:38 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: edazdarevic

Same comment as for has_map.

*Created by: edazdarevic* Same comment as for `has_map`.
senaduka commented 2017-10-31 15:04:34 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: edazdarevic

Could we have reused the enum in crawler/enums.js? Just add STATUS_NORMAL etc there.

*Created by: edazdarevic* Could we have reused the enum in `crawler/enums.js`? Just add STATUS_NORMAL etc there.
senaduka commented 2017-10-31 15:05:32 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: edazdarevic

We could have referenced these from crawler/enums.js as in:

import {
   STATUS_NORMAL,
   STATUS_RESERVED,
   STATUS_SOLD
 } from "../crawler/enums";
*Created by: edazdarevic* We could have referenced these from `crawler/enums.js` as in: ``` import { STATUS_NORMAL, STATUS_RESERVED, STATUS_SOLD } from "../crawler/enums"; ```
senaduka commented 2017-10-31 15:12:31 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: edazdarevic

👍

*Created by: edazdarevic* 👍
senaduka commented 2017-10-31 15:13:20 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: edazdarevic

Do we need this file in the repo?

*Created by: edazdarevic* Do we need this file in the repo?
senaduka commented 2017-10-31 15:15:02 +01:00 (Migrated from gitlab.com)
Copy Link

Created by: edazdarevic

We don't need those break statements?

*Created by: edazdarevic* We don't need those `break` statements?
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-kivi#2
Delete Branch "rental-crawler"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?