senaduka/old-holivud2
1
0
Fork 0
Code Issues Pull Requests 6 Actions Packages Projects Releases Wiki Activity

fix MR comments

Browse Source
This commit is contained in:
Bilal
2020-07-01 11:27:18 +02:00
parent 6fc05f0b7f
commit 469839cee7
3 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/assets/stylesheets/application.scss
View File

@@ -427,12 +427,3 @@ a[data-behavior=seekable-timecode] {
width: 308px; width: 308px;
height:308px; height:308px;
} }
// Add checkmark before list item
#checkmark-list > li {
list-style: none;
margin-left: -1em;
}
#checkmark-list > li:before {
content: '\2713\0020';
}

14
app/views/videos/splash.html.erb
View File

@@ -5,7 +5,9 @@
</div> </div>
<%= link_to t(".actions.book_demo"), 'https://meetings.hubspot.com/bray2', class: "btn btn-primary border align-self-center h-50 ml-auto mr-2 pb-2", target: '_blank' %> <%= link_to t(".actions.book_demo"), 'https://meetings.hubspot.com/bray2', class: "btn btn-primary border align-self-center h-50 ml-auto mr-2 pb-2", target: '_blank' %>
<%= link_to t(".actions.upload_video"), [:new, @project, :video], class: "btn btn-success border align-self-center h-50 pb-2" %> <% if policy(Video).new? %>
<%= link_to t(".actions.upload_video"), [:new, @project, :video], class: "btn btn-success border align-self-center h-50 pb-2" %>
<% end %>
</div> </div>
<hr> <hr>
@@ -44,11 +46,11 @@
<div class="row"> <div class="row">
<div class="col"> <div class="col">
<h3><%= t '.headings.benefits' %></h3> <h3><%= t '.headings.benefits' %></h3>
<ul id="checkmark-list"> <ul class="fa-ul ml-5">
<li><%= t '.list_items.reduces_labor_cost' %></li> <%= content_tag(:li, fa_icon("check li", text: t('.list_items.reduces_labor_cost'))) %>
<li><%= t '.list_items.more_accurate' %></li> <%= content_tag(:li, fa_icon("check li", text: t('.list_items.more_accurate'))) %>
<li><%= t '.list_items.simplifies_cue_sheets' %></li> <%= content_tag(:li, fa_icon("check li", text: t('.list_items.simplifies_cue_sheets'))) %>
<li><%= t '.list_items.production_elements_logs' %></li> <%= content_tag(:li, fa_icon("check li", text: t('.list_items.production_elements_logs'))) %>
</ul> </ul>
</div> </div>
</div> </div>

12
spec/features/user_managing_videos_spec.rb
View File

@@ -104,6 +104,18 @@ feature "User managing videos" do
expect(page).to have_content("Second Video") expect(page).to have_content("Second Video")
end end
context 'When the user is associate' do
let(:current_user) { create(:user, :associate) }
it 'does show button to upload new video' do
Video.delete_all
visit project_videos_path(project)
expect(page).to have_content schedule_demo
expect(page).to have_content upload_new_video
end
end
private private
def fill_in_video_fields(data) def fill_in_video_fields(data)