From 469839cee7d72702a4a947ba9d95f16111843ec1 Mon Sep 17 00:00:00 2001
From: Bilal <bilal@saburly.com>
Date: Wed, 1 Jul 2020 11:27:18 +0200
Subject: [PATCH] fix MR comments

---
 app/assets/stylesheets/application.scss    |  9 ---------
 app/views/videos/splash.html.erb           | 14 ++++++++------
 spec/features/user_managing_videos_spec.rb | 12 ++++++++++++
 3 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss
index 581f952..b14620f 100644
--- a/app/assets/stylesheets/application.scss
+++ b/app/assets/stylesheets/application.scss
@@ -427,12 +427,3 @@ a[data-behavior=seekable-timecode] {
   width: 308px;
   height:308px;
 }
-
-// Add checkmark before list item
-#checkmark-list > li {
-  list-style: none;
-  margin-left: -1em;
-}
-#checkmark-list > li:before {
-  content: '\2713\0020';
-}
\ No newline at end of file
diff --git a/app/views/videos/splash.html.erb b/app/views/videos/splash.html.erb
index 18c503f..e620631 100644
--- a/app/views/videos/splash.html.erb
+++ b/app/views/videos/splash.html.erb
@@ -5,7 +5,9 @@
   </div>
 
   <%= link_to t(".actions.book_demo"), 'https://meetings.hubspot.com/bray2', class: "btn btn-primary border align-self-center h-50 ml-auto mr-2 pb-2", target: '_blank' %>
-  <%= link_to t(".actions.upload_video"), [:new, @project, :video], class: "btn btn-success border align-self-center h-50 pb-2" %>
+  <% if policy(Video).new? %>
+    <%= link_to t(".actions.upload_video"), [:new, @project, :video], class: "btn btn-success border align-self-center h-50 pb-2" %>
+  <% end %>
 </div>
 
 <hr>
@@ -44,11 +46,11 @@
       <div class="row">
         <div class="col">
           <h3><%= t '.headings.benefits' %></h3>
-          <ul id="checkmark-list">
-            <li><%= t '.list_items.reduces_labor_cost' %></li>
-            <li><%= t '.list_items.more_accurate' %></li>
-            <li><%= t '.list_items.simplifies_cue_sheets' %></li>
-            <li><%= t '.list_items.production_elements_logs' %></li>
+          <ul class="fa-ul ml-5">
+            <%= content_tag(:li, fa_icon("check li", text: t('.list_items.reduces_labor_cost'))) %>
+            <%= content_tag(:li, fa_icon("check li", text: t('.list_items.more_accurate'))) %>
+            <%= content_tag(:li, fa_icon("check li", text: t('.list_items.simplifies_cue_sheets'))) %>
+            <%= content_tag(:li, fa_icon("check li", text: t('.list_items.production_elements_logs'))) %>
           </ul>
         </div>
       </div>
diff --git a/spec/features/user_managing_videos_spec.rb b/spec/features/user_managing_videos_spec.rb
index 883bf48..af283d4 100644
--- a/spec/features/user_managing_videos_spec.rb
+++ b/spec/features/user_managing_videos_spec.rb
@@ -104,6 +104,18 @@ feature "User managing videos" do
     expect(page).to have_content("Second Video")
   end
 
+  context 'When the user is associate' do
+    let(:current_user) { create(:user, :associate) }
+
+    it 'does show button to upload new video' do
+      Video.delete_all
+      visit project_videos_path(project)
+
+      expect(page).to have_content schedule_demo
+      expect(page).to have_content upload_new_video
+    end
+  end
+
   private
 
   def fill_in_video_fields(data)