senaduka/old-experiments
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Product templates validation #6

Merged
nedimu merged 1 commits from product-templates into master 2018-07-18 12:20:28 +02:00
Conversation 4 Commits 1 Files Changed 5808 +4085 -1533451
nedimu commented 2018-07-17 12:26:43 +02:00 (Migrated from gitlab.com)
Copy Link

Documentation including the smoke test are on google docs

https://docs.google.com/document/d/1Bel9h-hRimc6I7LApPCKRKHE33zgrOJeCHQNVitP8R8/edit

There are no changes on frontend. You can just copy the wordpres and db dump, and you are redy to go ...

Documentation including the smoke test are on google docs https://docs.google.com/document/d/1Bel9h-hRimc6I7LApPCKRKHE33zgrOJeCHQNVitP8R8/edit There are no changes on frontend. You can just copy the wordpres and db dump, and you are redy to go ...
akrdzic commented 2018-07-18 12:06:49 +02:00 (Migrated from gitlab.com)
Copy Link

Observations regarding product templates:

I think we should definitely go with custom product taxonomy for templates. This way product template will not be mixed with product. I would also not mix product type with templates, since only grouped product type can use templates so not to interfere with that.

We could add custom taxonomy for product used for templates, where only grouped product can choose which template they belong to. Also since taxonomy term can have metadata set for them, we could use that do have custom field on term edit page to associate needed product categories with that template term.

Also this way product template is created separate from product and we do not have to worry about logic for hiding this 'special product'. Also this way product template would execute only the single functionality it is needed for.

Observations regarding product templates: I think we should definitely go with custom product taxonomy for templates. This way product template will not be mixed with product. I would also not mix product type with templates, since only grouped product type can use templates so not to interfere with that. We could add custom taxonomy for product used for templates, where only grouped product can choose which template they belong to. Also since taxonomy term can have metadata set for them, we could use that do have custom field on term edit page to associate needed product categories with that template term. Also this way product template is created separate from product and we do not have to worry about logic for hiding this 'special product'. Also this way product template would execute only the single functionality it is needed for.
akrdzic commented 2018-07-18 12:12:36 +02:00 (Migrated from gitlab.com)
Copy Link

assigned to @akrdzic

assigned to @akrdzic
akrdzic commented 2018-07-18 12:20:28 +02:00 (Migrated from gitlab.com)
Copy Link

merged

merged
akrdzic commented 2018-07-18 12:20:29 +02:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 79eabd9cb5

mentioned in commit 79eabd9cb54a35532c09211cb8399b760e0c1364
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-experiments#6
Delete Branch "product-templates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?