Full filter #1

2017-12-08T13:44:49+01:00

senaduka commented

2017-12-08 13:44:49 +01:00

(Migrated from gitlab.com)

Created by: GotPPay

*Created by: GotPPay*

senaduka commented

2017-12-08 15:12:09 +01:00

(Migrated from gitlab.com)

Created by: MirnaM

No need for index or tmpWords variable, this is same as config.words = config.words.map(word => word.toLowerCase())

*Created by: MirnaM* No need for index or tmpWords variable, this is same as config.words = config.words.map(word => word.toLowerCase())

senaduka commented

2017-12-08 15:21:46 +01:00

(Migrated from gitlab.com)

Created by: MirnaM

Maybe there is no need to pass this callback? It looks to me that line 27 can be moved to applyFilters method. It's a bit confusing like this and hard to follow :)

*Created by: MirnaM* Maybe there is no need to pass this callback? It looks to me that line 27 can be moved to applyFilters method. It's a bit confusing like this and hard to follow :)

senaduka commented

2017-12-08 15:36:00 +01:00

(Migrated from gitlab.com)

Created by: MirnaM

also no need to pass this as a callback? getRawDomainList can return only data, i.e. const raw = getRawDomainList(url); and this callback can be part of getDomainList function.

*Created by: MirnaM* also no need to pass this as a callback? getRawDomainList can return only data, i.e. const raw = getRawDomainList(url); and this callback can be part of getDomainList function.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: senaduka/old-domene-svedska#1