Changed default to switched on.

.prettierignore

@@ -0,0 +1 @@
+*.ejs

app/common/enums.js

@@ -216,8 +216,7 @@ const AD_STATUS = {
   STATUS_DELETED: 4,
   STATUS_URGENT: 5,
   STATUS_DISCOUNTED: 6,
-  STATUS_RENTED: 7,
+  STATUS_RENTED: 7
-  STATUS_VIP: 8
 };
 
 const AD_AGENCY = {

app/config/appConfig.js

@@ -32,11 +32,6 @@ const PRINT_CRAWLER_DEBUG = process.env.PRINT_CRAWLER_DEBUG_INFO || 0;
 
 const API_MAP_KEY = process.env.API_MAP_KEY || "";
 
-const PROSTOR_LOGIN = {
-  EMAIL: process.env.PROSTOR_LOGIN_EMAIL,
-  PASSWORD: process.env.PROSTOR_LOGIN_PASS
-};
-
 module.exports = {
   APP_PORT,
   APP_URL,
@@ -47,6 +42,5 @@ module.exports = {
   MAX_REAL_ESTATES_IN_EMAIL,
   MAX_REAL_ESTATES_IN_FIRST_EMAIL,
   PRINT_CRAWLER_DEBUG,
-  API_MAP_KEY,
+  API_MAP_KEY
-  PROSTOR_LOGIN
 };

app/controllers/realEstateFilters.js

@@ -35,7 +35,8 @@ const getFilters = async (req, res) => {
     balcony,
     elevator,
     newBuilding,
-    accessRoadType
+    accessRoadType,
+    includeWithoutPrice
   } = searchRequest;
   const category = AD_CATEGORY[realEstateType] || AD_CATEGORY.FLAT;
 
@@ -115,7 +116,8 @@ const getFilters = async (req, res) => {
     advancedSegmentSelectFilterValues,
     advancedRangeFilterObjects,
     advancedRangeFilterValues,
-    includeIncompleteAds
+    includeIncompleteAds,
+    includeWithoutPrice
   });
 };
 
@@ -191,6 +193,7 @@ const postFilters = async (req, res) => {
   });
 
   const includeIncompleteAds = req.body.includeIncompleteAds === "on";
+  const includeWithoutPrice = req.body.includeWithoutPrice === "on";
 
   const balcony = req.body.balcony === "on";
   const elevator = req.body.elevator === "on";
@@ -217,6 +220,7 @@ const postFilters = async (req, res) => {
   searchRequest.newBuilding = newBuilding;
 
   searchRequest.includeIncompleteAds = includeIncompleteAds;
+  searchRequest.includeWithoutPrice = includeWithoutPrice;
 
   searchRequest.accessRoadType = accessRoadType;
 

app/controllers/realEstates.js

@@ -2,14 +2,13 @@
 const {
   findRealEstatesForSearchRequest
 } = require("../helpers/db/searchRequestMatch");
-const { AD_STATUS } = require("../common/enums");
 
 const getRealEstates = async (req, res) => {
   const searchRequestId = req.params["searchRequestId"] || "";
   const realEstates = await findRealEstatesForSearchRequest(searchRequestId);
 
   const title = "Nekretnine koje odgovaraju Vašim uslovima pretrage";
-  res.render("realEstates", { realEstates, title, AD_STATUS });
+  res.render("realEstates", { realEstates, title });
 };
 
 module.exports = {

app/controllers/redirect.js

@@ -1,11 +1,9 @@
 const { getRealEstateById } = require("../helpers/db/realEstate");
-const { AD_STATUS } = require("../common/enums");
 
 const getRedirect = async (req, res) => {
   const id = req.params.id || null;
   let error = false;
   let redirectUrl = undefined;
-  let vipAd = undefined;
   if (!id) {
     error = true;
   } else {
@@ -15,7 +13,6 @@ const getRedirect = async (req, res) => {
         error = true;
       } else {
         redirectUrl = realEstate.url;
-        vipAd = realEstate.adStatus === AD_STATUS.STATUS_VIP;
       }
     } catch (e) {
       error = true;
@@ -27,7 +24,7 @@ const getRedirect = async (req, res) => {
     res.render("notFound", { title });
   } else {
     const title = "Preusmjeravanje";
-    res.render("redirect", { title, redirectUrl, vipAd });
+    res.render("redirect", { title, redirectUrl });
   }
 };
 

app/crawler/specificCrawlers/prostor.js

@@ -3,7 +3,6 @@
 const fetch = require("node-fetch");
 const cheerio = require("cheerio");
 const moment = require("moment-timezone");
-const FormData = require("form-data");
 
 const {
   AD_TYPE,
@@ -17,8 +16,7 @@ const {
 
 const {
   PRINT_CRAWLER_DEBUG,
-  DEFAULT_TIMEZONE,
+  DEFAULT_TIMEZONE
-  PROSTOR_LOGIN
 } = require("../../config/appConfig");
 const { PROSTOR_FORCE_CRAWL } = require("../specificConfigs/prostor");
 
@@ -62,16 +60,13 @@ class ProstorCrawler {
 
   async crawl() {
     const crawlAdCategories = this.crawlerAdCategories;
-    //We need session cookie to use login privileges
+
-    const prostorCookie = await this.getCookies();
-    //New tag to check if crawler loged in
-    const login = await this.loginForScraping(PROSTOR_LOGIN, prostorCookie);
     const newRealEstates = [];
-    //Crawl only if login was successful
+
-    if (crawlAdCategories && login) {
+    if (crawlAdCategories) {
       const indexGenerators = [];
       for (const adCategory of crawlAdCategories) {
-        indexGenerators.push(this.categoryIndexer(adCategory, prostorCookie));
+        indexGenerators.push(this.categoryIndexer(adCategory));
       }
 
       let done = false;
@@ -124,14 +119,13 @@ class ProstorCrawler {
     return newRealEstates;
   }
 
-  async *categoryIndexer(adCategory, prostorCookie) {
+  async *categoryIndexer(adCategory) {
     const urlAdTypePart = PROSTOR_ENUMS.PROSTOR_AD_TYPE[this.crawlerAdTypes];
     const urlCategoryPart = PROSTOR_ENUMS.PROSTOR_AD_CATEGORY[adCategory];
     if (urlAdTypePart !== undefined && urlCategoryPart !== undefined) {
       const urlPageToCrawl = `${this.baseUrl}?remove_sold=0${urlAdTypePart}${urlCategoryPart}`;
       const listOfAllRealEstates = await this.extractRealEstates(
-        urlPageToCrawl,
+        urlPageToCrawl
-        prostorCookie
       );
 
       let elementToStartIndexFrom = 0;
@@ -145,8 +139,7 @@ class ProstorCrawler {
           elementToStartIndexFrom += realEstatesForSinglePage.length;
 
           const singlePageResults = await this.indexSinglePage(
-            realEstatesForSinglePage,
+            realEstatesForSinglePage
-            prostorCookie
           );
 
           const filteredSinglePageResults = singlePageResults.filter(
@@ -170,10 +163,10 @@ class ProstorCrawler {
     }
   }
 
-  async indexSinglePage(realEstatesList, prostorCookie) {
+  async indexSinglePage(realEstatesList) {
     const asyncActions = [];
     for (const realEstate of realEstatesList) {
-      asyncActions.push(this.scrapeAd(realEstate, prostorCookie));
+      asyncActions.push(this.scrapeAd(realEstate));
     }
 
     try {
@@ -187,25 +180,12 @@ class ProstorCrawler {
     }
   }
 
-  async scrapeAd(realEstate, prostorCookie) {
+  async scrapeAd(realEstate) {
     const { lat, lng, property_name, price, size, link, status } = realEstate;
-
-    //Status information is given already in realestate list
-    //For VIP Ads status ='' canot be used, but no VIP ads are crawled
-    //We will make "fake" vip ad for RE that have size=55
-    //It is weird because yesterday it said 'VIP ponuda' ???
-    const adStatus =
-      size === "55"
-        ? ProstorCrawler.getStatusId("VIP ponuda")
-        : ProstorCrawler.getStatusId(status);
-
     const url = `https://prostor.ba${link}`;
-
     // console.log("[PROSTOR] Scraping : ", url);
     try {
-      const adPageSource = await fetch(url, {
+      const adPageSource = await fetch(url);
-        headers: { Cookie: prostorCookie }
-      });
       const body = await adPageSource.text();
       const $ = cheerio.load(body);
 
@@ -350,6 +330,7 @@ class ProstorCrawler {
         furnishingType = FURNISHING_TYPE.NOT_FURNISHED.id;
       }
 
+      const adStatus = ProstorCrawler.getStatusId(status);
       const title = property_name;
       const parsedPrice = parseFloat(price.replace(/\./g, "")) || null;
       const parsedArea = parseFloat(size);
@@ -427,15 +408,13 @@ class ProstorCrawler {
     }
   }
 
-  async extractRealEstates(url, prostorCookie) {
+  async extractRealEstates(url) {
     if (PRINT_CRAWLER_DEBUG) {
       console.log("[PROSTOR] Index page : ", url);
     }
 
     try {
-      const res = await fetch(url, {
+      const res = await fetch(url);
-        headers: { Cookie: prostorCookie }
-      });
       const body = await res.text();
       const $ = cheerio.load(body);
 
@@ -569,8 +548,6 @@ class ProstorCrawler {
         return AD_STATUS.STATUS_SOLD;
       case "Iznajmljeno":
         return AD_STATUS.STATUS_RENTED;
-      case "VIP ponuda":
-        return AD_STATUS.STATUS_VIP;
       default:
         console.log("[PROSTOR] Unknown AD_STATUS : [", statusText, "]");
         return AD_STATUS.STATUS_NORMAL;
@@ -592,51 +569,6 @@ class ProstorCrawler {
     return savers[0].save(results);
     //so that we can use some sequelize options and information when data is inserted
   }
-  async loginForScraping(PROSTOR_LOGIN, prostorCookie) {
-    let formData = new FormData();
-    formData.append("email", PROSTOR_LOGIN.EMAIL);
-    formData.append("password", PROSTOR_LOGIN.PASSWORD);
-
-    return fetch("https://prostor.ba/moj-prostor/prijava", {
-      method: "POST",
-      body: formData,
-      headers: { Cookie: prostorCookie }
-    })
-      .then(page => {
-        return page.text();
-      })
-      .then(resp => {
-        const $ = cheerio.load(resp);
-        if (
-          $("h1")
-            .text()
-            .indexOf("Dobrodošli") !== -1
-        ) {
-          console.log("[PROSTOR]: Crawler loged in!");
-          return true;
-        } else {
-          console.log("[PROSTOR]: Crawler login failed - wrong credentials!");
-          return false;
-        }
-      })
-      .catch(err => {
-        console.log("[PROSTOR]: Crawler login error ", err);
-      });
-  }
-  async getCookies() {
-    const getResponse = await fetch("https://prostor.ba/moj-prostor/prijava", {
-      headers: { Cookie: "" }
-    });
-    const raw = getResponse.headers.raw()["set-cookie"];
-    const cookie = raw
-      .map(datastring => {
-        const data = datastring.split(";");
-        const cookieData = data[0];
-        return cookieData;
-      })
-      .join(";");
-    return cookie;
-  }
 }
 
 module.exports = ProstorCrawler;

app/helpers/db/realEstate.js

@@ -2,6 +2,8 @@
 const db = require("../../models/index");
 const sequelize = require("sequelize");
 const Op = sequelize.Op;
+const { AD_CATEGORY } = require("../../common/enums");
+
 const bulkUpsertRealEstates = async realEstateData => {
   try {
     const fieldsToUpdateIfDuplicate = [
@@ -96,12 +98,16 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
     floorMin,
     floorMax,
     includeIncompleteAds,
+    includeWithoutPrice,
     balcony,
     elevator,
     newBuilding,
     accessRoadType
   } = searchRequest;
 
+  //Needed for defining which attribute should exist or not
+  const realEstateTypeObject = AD_CATEGORY[realEstateType];
+
   const longitudeColumn = sequelize.col("locationLong");
   const latitudeColumn = sequelize.col("locationLat");
 
@@ -134,15 +140,6 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
   const query = {
     adType,
     realEstateType,
-    price: {
-      [Op.or]: {
-        [Op.and]: {
-          [Op.lte]: priceMax,
-          [Op.gte]: priceMin
-        },
-        [Op.is]: null
-      }
-    },
     area: {
       [Op.lte]: sizeMax,
       [Op.gte]: sizeMin
@@ -154,15 +151,6 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
   const queryIncludeIncomplete = {
     adType,
     realEstateType,
-    price: {
-      [Op.or]: {
-        [Op.and]: {
-          [Op.lte]: priceMax,
-          [Op.gte]: priceMin
-        },
-        [Op.is]: null
-      }
-    },
     area: {
       [Op.or]: {
         [Op.and]: {
@@ -175,8 +163,49 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
     [Op.and]: geoSearchQueryPart
   };
 
-  //Every other attribute is checked separately and included in query only if it is defined
+  //Is user unchecked includeWithoutPrice FALSE then it shouldn't return null values of price
-  if (gardenSizeMax && gardenSizeMin) {
+  //If not then null values are accepted (this is DEFAULT)
+  //includeIncpompleteAds does not have effect on price query
+  if (includeWithoutPrice) {
+    query.price = {
+      [Op.or]: {
+        [Op.and]: {
+          [Op.lte]: priceMax,
+          [Op.gte]: priceMin
+        },
+        [Op.is]: null
+      }
+    };
+    queryIncludeIncomplete.price = {
+      [Op.or]: {
+        [Op.and]: {
+          [Op.lte]: priceMax,
+          [Op.gte]: priceMin
+        },
+        [Op.is]: null
+      }
+    };
+  } else {
+    query.price = {
+      [Op.and]: {
+        [Op.lte]: priceMax,
+        [Op.gte]: priceMin
+      }
+    };
+    queryIncludeIncomplete.price = {
+      [Op.and]: {
+        [Op.lte]: priceMax,
+        [Op.gte]: priceMin
+      }
+    };
+  }
+  //Every other attribute is checked separately and included in query only if it is defined for real estate type
+
+  if (
+    realEstateTypeObject.hasGardenSize &&
+    gardenSizeMax != null &&
+    gardenSizeMin != null
+  ) {
     query.gardenSize = {
       [Op.lte]: gardenSizeMax,
       [Op.gte]: gardenSizeMin
@@ -192,7 +221,11 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
     };
   }
 
-  if (numberOfRoomsMin && numberOfRoomsMax) {
+  if (
+    realEstateTypeObject.hasNumberOfRoom &&
+    numberOfRoomsMin != null &&
+    numberOfRoomsMax != null
+  ) {
     query.numberOfRooms = {
       [Op.lte]: numberOfRoomsMax,
       [Op.gte]: numberOfRoomsMin
@@ -208,7 +241,11 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
     };
   }
 
-  if (numberOfFloorsMin && numberOfFloorsMax) {
+  if (
+    realEstateTypeObject.hasNumberOfFloors &&
+    numberOfFloorsMin != null &&
+    numberOfFloorsMax != null
+  ) {
     query.numberOfFloors = {
       [Op.lte]: numberOfFloorsMax,
       [Op.gte]: numberOfFloorsMin
@@ -224,7 +261,11 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
     };
   }
 
-  if (floorMin && floorMax) {
+  if (
+    realEstateTypeObject.hasFloorProp &&
+    floorMin != null &&
+    floorMax != null
+  ) {
     query.floor = {
       [Op.lte]: floorMax,
       [Op.gte]: floorMin
@@ -239,8 +280,10 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
       }
     };
   }
-
+  //Logic for balcony, newBuilding and elevator from users side
-  if (balcony) {
+  //If true is checked, then I want characteristic to be true but,
+  //if it is not checked, then I dont care - it can be null or false or true
+  if (realEstateTypeObject.hasBalconyProp && balcony === true) {
     query.balcony = {
       [Op.eq]: balcony
     };
@@ -252,7 +295,7 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
     };
   }
 
-  if (newBuilding) {
+  if (realEstateTypeObject.hasNewBuildingProp && newBuilding === true) {
     query.newBuilding = {
       [Op.eq]: newBuilding
     };
@@ -264,7 +307,7 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
     };
   }
 
-  if (elevator) {
+  if (realEstateTypeObject.hasElevatorProp && elevator === true) {
     query.elevator = {
       [Op.eq]: elevator
     };
@@ -275,7 +318,8 @@ const findRealEstatesForSearchRequest = async (searchRequest, maxResults) => {
       }
     };
   }
-
+  //If user wants 'ANY' road type acces then it is not included in query -
+  //returns every road type and null values
   if (accessRoadType !== "ANY") {
     query.accessRoadType = {
       [Op.eq]: accessRoadType

app/helpers/db/searchRequest.js

@@ -49,128 +49,390 @@ const findSearchRequestsForRealEstate = async realEstate => {
 
   const geoSearchQueryPart = sequelize.where(contains, true);
 
-  //General query contains only attributes that are defined for every RealEstate - not null
-  const query = {
-    adType,
-    realEstateType,
-    subscribed: true,
-    [Op.and]: geoSearchQueryPart
-  };
   //Needed for defining which attribute should exist or not
   const realEstateTypeObject = AD_CATEGORY[realEstateType];
-  //Needed to decide on including incomplete RealEstates data
+
+  // ?? Needed to decide on including incomplete RealEstates data
   let checkForIncompleteWanted = false;
 
-  //Attributes are checked separately and included in query only if defined
+  //Attributes are checked separately to make different query parts
-  //Price and area should be defined for every property
 
-  if (price) {
+  //If real estate price is number then it searches for req that have priceMin and priceMax
-    query.priceMin = {
+  //If real estate price is null it searches for req that accept ads without price
-      [Op.lte]: price
+  //User always defines price and area (sliders) - not null in search req
+  let priceQuery = {};
+  if (price != null) {
+    priceQuery = {
+      [Op.and]: [
+        {
+          priceMin: {
+            [Op.lte]: price
+          }
+        },
+        {
+          priceMax: {
+            [Op.gte]: price
+          }
+        }
+      ]
     };
-    query.priceMax = {
+  } else {
-      [Op.gte]: price
+    priceQuery = {
+      includeWithoutPrice: {
+        [Op.eq]: true
+      }
     };
   }
 
-  if (area) {
+  let areaQuery = {};
-    query.sizeMin = {
+  if (area != null) {
-      [Op.lte]: area
+    areaQuery = {
-    };
+      [Op.and]: [
-    query.sizeMax = {
+        {
-      [Op.gte]: area
+          sizeMin: {
+            [Op.lte]: area
+          }
+        },
+        {
+          sizeMax: {
+            [Op.gte]: area
+          }
+        }
+      ]
     };
   } else {
     checkForIncompleteWanted = true;
   }
+
   //Other attributes can be defined or not depending on RealEstate type
-  if (gardenSize) {
+  //we check what to include in query based on real estate type object
-    query.gardenSizeMin = {
+  let gardenSizeQuery = {};
-      [Op.lte]: gardenSize
+  if (realEstateTypeObject.hasGardenSize) {
-    };
+    if (gardenSize != null) {
-    query.gardenSizeMax = {
+      gardenSizeQuery = {
-      [Op.gte]: gardenSize
+        [Op.and]: [
-    };
+          {
-  } else if (realEstateTypeObject.hasGardenSize) {
+            gardenSizeMin: {
-    checkForIncompleteWanted = true;
+              [Op.lte]: gardenSize
+            }
+          },
+          {
+            gardenSizeMax: {
+              [Op.gte]: gardenSize
+            }
+          }
+        ]
+      };
+    } else {
+      checkForIncompleteWanted = true;
+    }
   }
 
-  if (numberOfRooms) {
+  let numberOfRoomsQuery = {};
-    query.numberOfRoomsMin = {
+  if (realEstateTypeObject.hasNumberOfRoom) {
-      [Op.lte]: numberOfRooms
+    if (numberOfRooms != null) {
-    };
+      //If real estate has defined number of rooms ex. 3 it returns req
-    query.numberOfRoomsMax = {
+      // that accepts 3 rooms or ones that don't have defined number - null
-      [Op.gte]: numberOfRooms
+      //Ex. they didnt choose advanced filters at all
-    };
+      numberOfRoomsQuery = {
-  } else if (realEstateTypeObject.hasNumberOfRoom) {
+        [Op.and]: [
-    checkForIncompleteWanted = true;
+          {
+            numberOfRoomsMin: {
+              [Op.or]: {
+                [Op.lte]: numberOfRooms,
+                [Op.is]: null
+              }
+            }
+          },
+          {
+            numberOfRoomsMax: {
+              [Op.or]: {
+                [Op.gte]: numberOfRooms,
+                [Op.is]: null
+              }
+            }
+          }
+        ]
+      };
+    } else {
+      // If real estate dont have defined number of rooms ex. null
+      //It returns requests that didn't choose number of rooms - also null
+      //Or ones that picked some values but also picked to includeIncomplete ads
+      numberOfRoomsQuery = {
+        [Op.or]: [
+          {
+            [Op.and]: [
+              {
+                numberOfRoomsMin: {
+                  [Op.is]: null
+                }
+              },
+              {
+                numberOfRoomsMax: {
+                  [Op.is]: null
+                }
+              }
+            ]
+          },
+          {
+            includeIncompleteAds: {
+              [Op.eq]: true
+            }
+          }
+        ]
+      };
+    }
+  }
+  //Same logic for number of Floors and floors
+  let numberOfFloorsQuery = {};
+  if (realEstateTypeObject.hasNumberOfFloors) {
+    if (numberOfFloors != null) {
+      numberOfFloorsQuery = {
+        [Op.and]: [
+          {
+            numberOfFloorsMin: {
+              [Op.or]: {
+                [Op.lte]: numberOfFloors,
+                [Op.is]: null
+              }
+            }
+          },
+          {
+            numberOfFloorsMax: {
+              [Op.or]: {
+                [Op.gte]: numberOfFloors,
+                [Op.is]: null
+              }
+            }
+          }
+        ]
+      };
+    } else {
+      numberOfFloorsQuery = {
+        [Op.or]: [
+          {
+            [Op.and]: [
+              {
+                numberOfFloorsMin: {
+                  [Op.is]: null
+                }
+              },
+              {
+                numberOfFloorsMax: {
+                  [Op.is]: null
+                }
+              }
+            ]
+          },
+          {
+            includeIncompleteAds: {
+              [Op.eq]: true
+            }
+          }
+        ]
+      };
+    }
+  }
+  let floorQuery = {};
+  if (realEstateTypeObject.hasFloorProp) {
+    if (floor != null) {
+      floorQuery = {
+        [Op.and]: [
+          {
+            floorMin: {
+              [Op.or]: {
+                [Op.lte]: floor,
+                [Op.is]: null
+              }
+            }
+          },
+          {
+            floorMax: {
+              [Op.or]: {
+                [Op.gte]: floor,
+                [Op.is]: null
+              }
+            }
+          }
+        ]
+      };
+    } else {
+      floorQuery = {
+        [Op.or]: [
+          {
+            [Op.and]: [
+              {
+                floorMin: {
+                  [Op.is]: null
+                }
+              },
+              {
+                floorMax: {
+                  [Op.is]: null
+                }
+              }
+            ]
+          },
+          {
+            includeIncompleteAds: {
+              [Op.eq]: true
+            }
+          }
+        ]
+      };
+    }
   }
 
-  if (numberOfFloors) {
+  //Logic for balcony, newBuilding and elevator
-    query.numberOfFloorsMin = {
+  //If user dont check checkbox for ex. elevator  it does not mean he only wants no elevator
-      [Op.lte]: numberOfFloors
+  //If real estate characteristic =true find all req, one that wants charachertistic or dont care - dont need query
-    };
+  //If real estate characteristic = false, find all req exept for ones that wants characteristic to be true
-    query.numberOfFloorsMax = {
+  //If real estate characteristic = null, dont know if true or false, find req that dont care or want char and want incomplete ads
-      [Op.gte]: numberOfFloors
+  let balconyQuery = {};
-    };
+  if (realEstateTypeObject.hasBalconyProp && balcony !== true) {
-  } else if (realEstateTypeObject.hasNumberOfFloors) {
+    if (balcony === false) {
-    checkForIncompleteWanted = true;
+      balconyQuery = {
+        balcony: {
+          [Op.ne]: true
+        }
+      };
+    } else if (balcony === null) {
+      balconyQuery = {
+        [Op.or]: [
+          {
+            balcony: {
+              [Op.ne]: true
+            }
+          },
+          {
+            [Op.and]: [
+              {
+                balcony: {
+                  [Op.eq]: true
+                }
+              },
+              {
+                includeIncompleteAds: {
+                  [Op.eq]: true
+                }
+              }
+            ]
+          }
+        ]
+      };
+    }
   }
-
+  let newBuildingQuery = {};
-  if (floor) {
+  if (realEstateTypeObject.hasNewBuildingProp && newBuilding !== true) {
-    query.floorMin = {
+    if (newBuilding === false) {
-      [Op.lte]: floor
+      newBuildingQuery = {
-    };
+        newBuilding: {
-    query.floorMax = {
+          [Op.ne]: true
-      [Op.gte]: floor
+        }
-    };
+      };
-  } else if (realEstateTypeObject.hasFloorProp) {
+    } else if (newBuilding === null) {
-    checkForIncompleteWanted = true;
+      newBuildingQuery = {
+        [Op.or]: [
+          {
+            newBuilding: {
+              [Op.ne]: true
+            }
+          },
+          {
+            [Op.and]: [
+              {
+                newBuilding: {
+                  [Op.eq]: true
+                }
+              },
+              {
+                includeIncompleteAds: {
+                  [Op.eq]: true
+                }
+              }
+            ]
+          }
+        ]
+      };
+    }
   }
+  let elevatorQuery = {};
+  if (realEstateTypeObject.hasElevatorProp && elevator !== true) {
+    if (elevator === false) {
+      elevatorQuery = {
+        elevator: {
+          [Op.ne]: true
+        }
+      };
+    } else if (elevator === null) {
+      elevatorQuery = {
+        [Op.or]: [
+          {
+            elevator: {
+              [Op.ne]: true
+            }
+          },
+          {
+            [Op.and]: [
+              {
+                elevator: {
+                  [Op.eq]: true
+                }
+              },
+              {
+                includeIncompleteAds: {
+                  [Op.eq]: true
+                }
+              }
+            ]
+          }
+        ]
+      };
+    }
+  }
+  //General query consists of each individual query
+  const query = {
+    adType,
+    realEstateType,
+    subscribed: true,
+    [Op.and]: [
+      geoSearchQueryPart,
+      priceQuery,
+      areaQuery,
+      gardenSizeQuery,
+      numberOfRoomsQuery,
+      numberOfFloorsQuery,
+      floorQuery,
+      balconyQuery,
+      newBuildingQuery,
+      elevatorQuery
+    ]
+  };
 
-  if (accessRoadType) {
+  //AccessRoadType is defined - should exists for each ad and estate type
+  if (accessRoadType != null) {
     query.accessRoadType = {
       [Op.or]: {
-        [Op.eq]: "ANY",
+        [Op.like]: "ANY",
         [Op.eq]: accessRoadType
       }
     };
-  } else if (realEstateTypeObject.hasAccesRoadType) {
+  } else {
-    checkForIncompleteWanted = true;
+    //Null values are returned for user request that wanted ANY acces road type
-  }
+    query.accessRoadType = {
-
+      [Op.eq]: "ANY"
-  if (balcony) {
-    query.balcony = {
-      [Op.eq]: balcony
     };
-  } else if (realEstateTypeObject.hasBalconyProp) {
-    checkForIncompleteWanted = true;
   }
-
+  //Tag to check if incomplete ads are accepted in query
-  if (newBuilding) {
-    query.newBuilding = {
-      [Op.eq]: newBuilding
-    };
-  } else if (realEstateTypeObject.hasNewBuildingProp) {
-    checkForIncompleteWanted = true;
-  }
-
-  if (elevator) {
-    query.elevator = {
-      [Op.eq]: elevator
-    };
-  } else if (realEstateTypeObject.hasElevatorProp) {
-    checkForIncompleteWanted = true;
-  }
-
-  //If one of the attributes that exists for property type is null
-  //we include in query to check if incomplete real estates are accepted
   if (checkForIncompleteWanted) {
     query.includeIncompleteAds = {
       [Op.eq]: true
     };
   }
-  return await db.SearchRequest.findAll({ where: query });
+
+  return await db.SearchRequest.findAll({
+    where: query
+  });
 };
 
 module.exports = {

app/helpers/emailContentGenerator.js

@@ -23,19 +23,16 @@ const generateRealEstateLinks = realEstates => {
 const generateNotificationEmail = (
   realEstates,
   searchRequestId,
-  noAllRealEstates,
   dailyNotification = false
 ) => {
   const truncateList = realEstates.length > MAX_REAL_ESTATES_IN_EMAIL;
-
   const realEstatesToShow = truncateList
     ? realEstates.slice(0, MAX_REAL_ESTATES_IN_EMAIL)
     : realEstates;
 
   const allRealEstatesLink = `${APP_URL}/nekretnine/${searchRequestId}`;
-
   const realEstateLinks = generateRealEstateLinks(realEstatesToShow);
-  const moreRealEstates = `<div>Kompletan spisak nekretnina (${noAllRealEstates}) možete pogledati na <a href="${allRealEstatesLink}">listi nekretnina</a><div>`;
+  const moreRealEstates = `<div>Kompletan spisak nekretnina možete pogledati na <a href="${allRealEstatesLink}">listi nekretnina</a><div>`;
   const emailFooter = generateEmailFooter(searchRequestId);
   const asapMessageBody =
     realEstates.length > 1
@@ -73,7 +70,6 @@ const generateNewSearchRequestEmail = (searchRequest, matchingRealEstates) => {
   } = searchRequest;
 
   const realEstateLinks = generateRealEstateLinks(matchingRealEstates);
-
   const instantRealEstatesText = `<br/>
        <div>
         U međuvremenu pogledajte neke od nedavno objavljenih nekretnina koje odgovaraju Vašim uslovima pretrage :<br/>

app/migrations/20200123085754-add-column-includeWithoutPrice-to-searchRequests-table.js

@@ -0,0 +1,14 @@
+"use strict";
+
+module.exports = {
+  up: (queryInterface, Sequelize) => {
+    return queryInterface.addColumn("SearchRequests", "includeWithoutPrice", {
+      type: Sequelize.BOOLEAN,
+      defaultValue: true
+    });
+  },
+
+  down: (queryInterface, Sequelize) => {
+    return queryInterface.removeColumn("SearchRequests", "includeWithoutPrice");
+  }
+};

app/models/searchRequest.js

@@ -15,7 +15,15 @@ module.exports = (sequelize, DataTypes) => {
       allowNull: false,
       defaultValue: {
         type: "Polygon",
-        coordinates: [[[0, 0], [0, 0], [0, 0], [0, 0], [0, 0]]],
+        coordinates: [
+          [
+            [0, 0],
+            [0, 0],
+            [0, 0],
+            [0, 0],
+            [0, 0]
+          ]
+        ],
         crs: { type: "name", properties: { name: "EPSG:4326" } }
       }
     },
@@ -71,6 +79,7 @@ module.exports = (sequelize, DataTypes) => {
       type: DataTypes.TEXT
     },
     includeIncompleteAds: DataTypes.BOOLEAN,
+    includeWithoutPrice: DataTypes.BOOLEAN,
     balcony: DataTypes.BOOLEAN,
     elevator: DataTypes.BOOLEAN,
     newBuilding: DataTypes.BOOLEAN,

app/public/main.css

@@ -154,7 +154,3 @@ h3 {
   margin-top: 2rem;
   margin-bottom: 1rem;
 }
-
-.estates-link {
-  color: rgba(0, 0, 0, 0.87);
-}

app/services/notificationService.js

@@ -8,10 +8,7 @@ const {
   generateNewSearchRequestEmail,
   generateEmailSubject
 } = require("../helpers/emailContentGenerator");
-const {
+const { findNotNotifiedMatches } = require("../helpers/db/searchRequestMatch");
-  findNotNotifiedMatches,
-  findRealEstatesForSearchRequest
-} = require("../helpers/db/searchRequestMatch");
 const { sendEmail } = require("../services/emailService");
 
 const notifyForNewRealEstates = async newRealEstates => {
@@ -42,18 +39,10 @@ const notifyMatches = async (matches, dailyNotification = false) => {
     const { email, subscribed } = searchRequest;
     if (notifyNow && subscribed) {
       const allMatchingRealEstates = matches[id].realEstates || [];
-
-      //Variable allMatchingRealEstates are real estates that are "new" on the market
-      //the ones that we notify user in this moment, not all that already exists in db
-      //New variable allRealEstates are all real estates that exists in db for search req
-      const allRealEstates = await findRealEstatesForSearchRequest(id);
-      const noAllRealEstates = allRealEstates.length;
-
       if (allMatchingRealEstates.length > 0) {
         const emailContent = generateNotificationEmail(
           allMatchingRealEstates,
           id,
-          noAllRealEstates,
           dailyNotification
         );
         const emailSubject = generateEmailSubject(

app/views/realEstates.ejs

@@ -1,29 +1,13 @@
 <div class="row center-align">
-  <ul class="collection with-header">
+    <ul class="collection with-header">
-    <% for(const realEstate of realEstates) { %>
+      <% for(const realEstate of realEstates) { %>
-    <li class="collection-item">
+      <li class="collection-item">
-      <% if(realEstate.adStatus === AD_STATUS.STATUS_VIP) {%>
+        <div><%= realEstate.title %>
-      <div>
+          <a href="<%= realEstate.url %>" class="kivi-color secondary-content">
-        <% //This needs to do redirecting instead of direct link to realestate
-        %>
-        <a href="/redirect/<%= realEstate.id %>" class="estates-link">
-          <%= realEstate.title %>
-          <div class="kivi-color secondary-content">
             <i class="material-icons">send</i>
-          </div>
+          </a>
-        </a>
+        </div>
-      </div>
+      </li>
-      <%} else { %>
+      <% } %>
-      <div>
+    </ul>
-        <a href="<%= realEstate.url %>" class="estates-link">
+  </div>
-          <%= realEstate.title %>
-          <div class="kivi-color secondary-content">
-            <i class="material-icons">send</i>
-          </div>
-        </a>
-      </div>
-      <% }%>
-    </li>
-    <% } %>
-  </ul>
-</div>

app/views/redirect.ejs

@@ -1,49 +1,26 @@
-<br /><br />
+<br><br>
 <div class="center">
-  <div class="preloader-wrapper big active center">
+    <div class="preloader-wrapper big active center">
-    <div class="kivi-spinner-color spinner-layer spinner-green-only">
+        <div class="kivi-spinner-color spinner-layer spinner-green-only">
-      <div class="circle-clipper left">
+            <div class="circle-clipper left">
-        <div class="circle"></div>
+                <div class="circle"></div>
-      </div>
+            </div><div class="gap-patch">
-      <div class="gap-patch">
+                <div class="circle"></div>
-        <div class="circle"></div>
+            </div><div class="circle-clipper right">
-      </div>
+                <div class="circle"></div>
-      <div class="circle-clipper right">
+            </div>
-        <div class="circle"></div>
+        </div>
-      </div>
     </div>
-  </div>
 </div>
 
-<br />
+<br>
-<% if(vipAd) { %>
 <div class="center">
-  <h6>
+    <h6>
-    Ovaj oglas zahtijeva da budete član
+        <a href="<%= redirectUrl %>" rel="noreferrer" id="realEstateUrl">Kliknite ovdje ako Vas web preglednik ne preusmjeri automatski</a>
-    <a href="https://prostor.ba/" rel="noreferrer">Prostor.ba</a>.
+    </h6>
-    <br />
-    <br />
-    <a href="https://prostor.ba/moj-prostor/prijava" rel="noreferrer"
-      >Ulogujte se</a
-    >
-    ili napravite
-    <a href="https://prostor.ba/moj-prostor/registracija" rel="noreferrer"
-      >novi račun</a
-    >, a potom otvorite <a href="<%= redirectUrl %>" rel="noreferrer">oglas</a>.
-  </h6>
 </div>
-<% } else { %>
-<div class="center">
-  <h6>
-    <a href="<%= redirectUrl %>" rel="noreferrer" id="realEstateUrl"
-      >Kliknite ovdje ako Vas web preglednik ne preusmjeri automatski</a
-    >
-  </h6>
-</div>
-<% }%>
-
 <script>
-  window.onload = function() {
+    window.onload = function() {
-    document.getElementById("realEstateUrl").click();
+        document.getElementById('realEstateUrl').click();
-  };
+    }
 </script>

app/views/standardFilters.ejs

@@ -18,6 +18,15 @@
   </div>
 </div>
 
+<br />
+<p class="distinguished">
+  <label class="checkbox-label">
+    <input type="checkbox" class="filled-in" name="includeWithoutPrice"
+      checked
+      >
+    <span>Uključi i oglase bez cijene</span>
+  </label>
+</p>
 <br />
 
 <div class="row center-align">

development.env

@@ -51,8 +51,6 @@ PROSTOR_CRAWLER_AD_CATEGORIES=comma separated list of enum names of categories t
 PROSTOR_IGNORED_USERNAMES=!!! This is not used for prostor crawler !!!
 PROSTOR_DELAY_BETWEEN_PAGES=!!! This is not used for prostor crawler !!!
 PROSTOR_FORCE_CRAWL=Non-zero value will force crawler to crawl all pages without stopping when known real estate is found
-PROSTOR_LOGIN_EMAIL=Email of valid Prostor.ba account for crawling purposes
-PROSTOR_LOGIN_PASS=Password of valid Prostor.ba account for crawling purposes
 #==AKTIDO==
 AKTIDO_MAX_PAGES=Restrict crawler to this number of pages
 AKTIDO_MAX_RESULTS_PER_PAGE=Only this number or less results from one page will be scraped and saved

package-lock.json

@@ -1346,23 +1346,13 @@
       "integrity": "sha1-+8cfDEGt6zf5bFd60e1C2P2sypE="
     },
     "form-data": {
-      "version": "3.0.0",
+      "version": "2.3.3",
-      "resolved": "https://registry.npmjs.org/form-data/-/form-data-3.0.0.tgz",
+      "resolved": "https://registry.npmjs.org/form-data/-/form-data-2.3.3.tgz",
-      "integrity": "sha512-CKMFDglpbMi6PyN+brwB9Q/GOw0eAnsrEZDgcsH5Krhz5Od/haKHAX0NmQfha2zPPz0JpWzA7GJHGSnvCRLWsg==",
+      "integrity": "sha512-1lLKB2Mu3aGP1Q/2eCOx0fNbRMe7XdwktwOruhfqqd0rIJWwN4Dh+E3hrPSlDCXnSR7UtZ1N38rVXm+6+MEhJQ==",
       "requires": {
         "asynckit": "^0.4.0",
-        "combined-stream": "^1.0.8",
+        "combined-stream": "^1.0.6",
         "mime-types": "^2.1.12"
-      },
-      "dependencies": {
-        "combined-stream": {
-          "version": "1.0.8",
-          "resolved": "https://registry.npmjs.org/combined-stream/-/combined-stream-1.0.8.tgz",
-          "integrity": "sha512-FQN4MRfuJeHf7cBbBMJFXhKSDq+2kAArBlmRBvcvFE5BB1HZKXtSFASDhdlz9zOYwxh8lDdnvmMOe/+5cdoEdg==",
-          "requires": {
-            "delayed-stream": "~1.0.0"
-          }
-        }
       }
     },
     "forwarded": {
@@ -3440,18 +3430,6 @@
         "tough-cookie": "~2.4.3",
         "tunnel-agent": "^0.6.0",
         "uuid": "^3.3.2"
-      },
-      "dependencies": {
-        "form-data": {
-          "version": "2.3.3",
-          "resolved": "https://registry.npmjs.org/form-data/-/form-data-2.3.3.tgz",
-          "integrity": "sha512-1lLKB2Mu3aGP1Q/2eCOx0fNbRMe7XdwktwOruhfqqd0rIJWwN4Dh+E3hrPSlDCXnSR7UtZ1N38rVXm+6+MEhJQ==",
-          "requires": {
-            "asynckit": "^0.4.0",
-            "combined-stream": "^1.0.6",
-            "mime-types": "^2.1.12"
-          }
-        }
       }
     },
     "require-directory": {

package.json

@@ -39,7 +39,6 @@
     "express": "^4.16.4",
     "express-ejs-layouts": "^2.5.0",
     "express-layout": "^0.1.0",
-    "form-data": "^3.0.0",
     "html-to-text": "^5.1.1",
     "moment": "^2.24.0",
     "moment-timezone": "^0.5.26",