senaduka/old-tellall
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix launch review comments #19

Merged
senaduka merged 10 commits from fix-launch-review-comments into master 2018-04-18 08:19:12 +02:00
Conversation 0 Commits 10 Files Changed 6 +262 -1843
senaduka commented 2018-04-18 02:19:41 +02:00 (Migrated from gitlab.com)
Copy Link

Created by: GotPPay

This PR contains :

  • alexa skill request verification as requested from amazon
  • closing session after intent is finished. Intent is finished if user action is not required (for example, if user asks for headlines or news, after reciting headlines or news, skill should close as recommended from amazon)

There was bug when user does not say anything, session closes abruptly with "skill took too long to respond", meaning that alexa expected some kind of response, but none was given.
This bug is solved now, so if user doesn't say anything, session is closed normally.This should resolve issue from second review failure

*Created by: GotPPay* This PR contains : - alexa skill request verification as requested from amazon - closing session after intent is finished. Intent is finished if user action is not required (for example, if user asks for headlines or news, after reciting headlines or news, skill should close as recommended from amazon) There was bug when user does not say anything, session closes abruptly with "skill took too long to respond", meaning that alexa expected some kind of response, but none was given. This bug is solved now, so if user doesn't say anything, session is closed normally.This should resolve issue from second review failure
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
senaduka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: senaduka/old-tellall#19
Delete Branch "fix-launch-review-comments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?