From e1f315cb812236d94a3eeea676df45971341ba86 Mon Sep 17 00:00:00 2001
From: GotPPay <bilal@saburly.com>
Date: Mon, 15 Jan 2018 16:06:37 +0100
Subject: [PATCH] backend api refactoring

---
 backend/controllers/index.js | 3 +--
 backend/controllers/skill.js | 6 ++++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/backend/controllers/index.js b/backend/controllers/index.js
index 9cf449c..93f7810 100644
--- a/backend/controllers/index.js
+++ b/backend/controllers/index.js
@@ -1,6 +1,5 @@
 var express = require ('express'), router = express.Router ();
 
-router.use ('/getSkill', require ('./skill'));
-router.use ('/updateSkill', require ('./skill')); // this will be fixed in next code refactoring
+router.use ('/skill', require ('./skill'));
 
 module.exports = router;
diff --git a/backend/controllers/skill.js b/backend/controllers/skill.js
index 4a5fc62..94cfecc 100644
--- a/backend/controllers/skill.js
+++ b/backend/controllers/skill.js
@@ -22,7 +22,7 @@ router.get ('/:id', async (req, res, next) => {
   }
 });
 
-router.post ('/:id', bodyParser.json (), async (req, res, next) => {
+router.put ('/:id', bodyParser.json (), async (req, res, next) => {
   let id = req.params.id;
   let dataFromWeb = JSON.stringify (req.body);
   let skill = JSON.parse (dataFromWeb);
@@ -33,7 +33,9 @@ router.post ('/:id', bodyParser.json (), async (req, res, next) => {
 
   console.log ('id = ' + id);
 
-  if (id !== '-1') {
+  //TODO : Fix inconsistency ! If skill is sent to amazon and accepted, but 
+  //fails in database (ID doesn't exist)
+  if (id.length === constants.skillIDLength) {
     if (updateOnAmazon) {
       amazonHelper
         .updateSkill (skill)