senaduka/old-roraccounting
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

handle money move without To homie

Browse Source
This commit is contained in:
Bilal
2020-10-05 17:03:37 +03:00
parent a11d517d19
commit 4a636c048a
2 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/controllers/money_moves_controller.rb
View File

@@ -17,6 +17,9 @@ class MoneyMovesController < ApplicationController
else else
error_response(:bad_request) error_response(:bad_request)
end end
rescue StandardError
error_response(:bad_request)
end end
def money_move_params def money_move_params

27
app/models/money_move.rb
View File

@@ -4,13 +4,15 @@ class MoneyMove < ApplicationRecord
def self.create_move(params) def self.create_move(params)
return false unless valid_money_move?(params) return false unless valid_money_move?(params)
move_from = create_move_from(params) if double_money_move?(params) move_from = create_move_from(params) if params[:from_homie_id].present?
move_to = create_move_to(params) move_to = create_move_to(params) if params[:to_homie_id].present?
MoneyMove.transaction do MoneyMove.transaction do
move_from.save! if move_from.present? move_from.save! if move_from.present?
move_to.save! move_to.save! if move_to.present?
end end
true
end end
def self.create_settle_record(homie_id, amount) def self.create_settle_record(homie_id, amount)
@@ -27,24 +29,27 @@ class MoneyMove < ApplicationRecord
private private
def valid_money_move?(params) def valid_money_move?(params)
params[:amount].present? && params[:to_homie_id].present? params[:amount].present? && (params[:to_homie_id].present? || params[:from_homie_id].present?)
end
def double_money_move?(params)
params[:from_homie_id].present? && params[:to_homie_id].present?
end end
def from_source_name(params) def from_source_name(params)
if double_money_move?(params) if params[:from_homie_id].present?
Homie.find(params[:from_homie_id]).name Homie.find(params[:from_homie_id]).name
else else
'External' 'External'
end end
end end
def to_source_name(params)
if params[:to_homie_id].present?
Homie.find(params[:to_homie_id]).name
else
'External'
end
end
def create_move_from(params) def create_move_from(params)
to_homie_name = Homie.find(params[:to_homie_id]).name new_desc = "[#{to_source_name(params)}] #{params[:description]}".lstrip
new_desc = "[#{to_homie_name}] #{params[:description]}".lstrip
MoneyMove.new( MoneyMove.new(
homie_id: params[:from_homie_id], homie_id: params[:from_homie_id],
amount: -params[:amount].to_d, amount: -params[:amount].to_d,