From 9865cb5f0a8689ec5b1e4bbaf797316305b3c3cf Mon Sep 17 00:00:00 2001
From: Edin Dazdarevic <edin.dazdarevic@gmail.com>
Date: Mon, 13 Apr 2015 01:05:22 +0200
Subject: [PATCH] trimming whitespace on import, fixed issue with units_in_pack
 column being too small

---
 back-office/lib/tasks/ribica.rake                      | 10 ++++++++++
 ...50412225939_change_units_in_pack_column_on_items.rb |  6 ++++++
 2 files changed, 16 insertions(+)
 create mode 100644 front-api/db/migrate/20150412225939_change_units_in_pack_column_on_items.rb

diff --git a/back-office/lib/tasks/ribica.rake b/back-office/lib/tasks/ribica.rake
index 63ca6b7..3f525e0 100644
--- a/back-office/lib/tasks/ribica.rake
+++ b/back-office/lib/tasks/ribica.rake
@@ -220,6 +220,14 @@ def import_single_item(row, index, logger)
     success
 end
 
+def trim_whitespace(row)
+    row.map! do |value|
+      trimmed = value.strip if not value.nil? # value.to_s.strip
+      # puts  "trimming '#{value}' to '#{trimmed}'"
+      trimmed
+    end
+end
+
 def do_import(validate_only)
   begin
     input_file = ENV['INPUT']
@@ -244,6 +252,7 @@ def do_import(validate_only)
     Item.transaction do
       CSV.foreach(path) do |row|
         if i != 1
+          trim_whitespace(row)
           if import_single_item(row, i, logger) == false
             should_rollback = true
           end
@@ -262,6 +271,7 @@ def do_import(validate_only)
       end
     end
   rescue Exception => e
+    puts "Import failed, please check the import log file for error details."
     logger.error "Error while importing: #{e}"
   end
   logger.info "Import done"
diff --git a/front-api/db/migrate/20150412225939_change_units_in_pack_column_on_items.rb b/front-api/db/migrate/20150412225939_change_units_in_pack_column_on_items.rb
new file mode 100644
index 0000000..c50eb06
--- /dev/null
+++ b/front-api/db/migrate/20150412225939_change_units_in_pack_column_on_items.rb
@@ -0,0 +1,6 @@
+class ChangeUnitsInPackColumnOnItems < ActiveRecord::Migration
+  def change
+    # t.decimal :units_in_pack, precision: 5, scale: 3
+    change_column :items, :units_in_pack, :decimal, precision: 6, scale: 2
+  end
+end