From f8fac239802b0efed2b217a325aeb909a36f873a Mon Sep 17 00:00:00 2001 From: Bilal Catic Date: Mon, 26 Aug 2019 13:40:17 +0200 Subject: [PATCH] implement bulk delete fees --- services/officeRnD/fees.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/services/officeRnD/fees.js b/services/officeRnD/fees.js index 83ede89..bf08c11 100644 --- a/services/officeRnD/fees.js +++ b/services/officeRnD/fees.js @@ -19,14 +19,7 @@ const deleteFeesFromORD = (dateRange, memberIds) => { memberIdsMap[memberId] = true; }); - const deleteRequests = []; - const sendDeleteRequestPromise = (feeId) => { - return new Promise((resolve, reject) => { - API.delete(`fees/${feeId}`) - .then(() => resolve(true)) - .catch(() => resolve(false)); - }); - }; + const feeIdsToRemove = []; fetchedFees.forEach((fee) => { const { member, date, invoice } = fee; @@ -35,15 +28,16 @@ const deleteFeesFromORD = (dateRange, memberIds) => { const isDateInDateRange = startDate.isSameOrBefore(date) && endDate.isSameOrAfter(date); if (memberIdsMap[member] && isDateInDateRange && (status === UNPAID_FEE_STATUS)) { - deleteRequests.push(sendDeleteRequestPromise(feeId)); + feeIdsToRemove.push(feeId); } }); - Promise.all(deleteRequests) + API.delete('fees', { data: feeIdsToRemove }) .then(() => { resolve(true); }) .catch((error) => { + console.log('error : ', error); reject(error); }); })