Fix hidden metadata

backend/app/plugins/wiaas/includes/delivery-process/class-wiaas-delivery-process-step.php

@@ -23,7 +23,7 @@ class Wiaas_Delivery_Process_Step extends Gravity_Flow_Step {
 
 		$settings_api = $this->get_common_settings_api();
 
-		$forms = $this->get_action_forms_choices();
+		$forms = Wiaas_Delivery_Process_Action::get_action_forms();
 		$form_choices[] = array( 'label' => esc_html__( 'Select a Form', 'wiaas' ), 'value' => '' );
 		foreach ( $forms  as $form ) {
 
@@ -86,8 +86,18 @@ class Wiaas_Delivery_Process_Step extends Gravity_Flow_Step {
         return $label;
     }
 
+	/**
+     * Update status
+     *
+	 * @param bool $status
+	 */
 	public function update_step_status($status = false) {
 
+		/**
+		 * If status is being updated after manual step completion ('Next Step' or 'Previous Step') change default
+         * behavior of settings status to cancelled if manual action is sending flow to next step.
+         * Instead of default cancelled status set complete status for this step.
+		 */
 	    if ($status === 'cancelled' && $admin_action = rgpost( 'wiaas_delivery_process_navigation_action' )) {
 
 		    list( $base_admin_action, $step_id ) = rgexplode( '|', $admin_action, 2 );
@@ -104,10 +114,10 @@ class Wiaas_Delivery_Process_Step extends Gravity_Flow_Step {
     }
 
 	/**
-	 * Process Wiass Delivery Process Step
+     *
+	 * Process Wiaas Delivery Process Step
 	 *
-	 *
-	 * @return bool
+	 * @return bool We will always return false because step will be completed only by manual user action
 	 */
 	function process() {
 
@@ -198,28 +208,22 @@ class Wiaas_Delivery_Process_Step extends Gravity_Flow_Step {
 		return $entry_meta;
 	}
 
+
+
 	/**
-	 * Retrieves forms that are valid options for delivery step action
      *
+	 * PRIVATE
+     *
+	 */
+
+
+	/**
+     * Create action entry to trigger subworkflow
+	 * @param $target_form
+	 * @param $order_id
+	 *
 	 * @return array
 	 */
-	public function get_action_forms_choices() {
-
-		return Wiaas_Delivery_Process_Action::get_action_forms();
-	}
-
-
-	/**
-	 * Retrieves target form entry id created when step was started
-	 * @return int
-	 */
-	public function get_target_form_entry_id() {
-		$value = gform_get_meta($this->get_entry_id(), 'wiaas_delivery_step_' . $this->get_id() .'_entry_id');
-
-		return absint($value);
-	}
-
-
 	private function _create_single_action_entry($target_form, $order_id) {
 
 		$action_entries_ids = array();
@@ -248,6 +252,14 @@ class Wiaas_Delivery_Process_Step extends Gravity_Flow_Step {
 	}
 
 
+	/**
+     * Create action form entries for every bundle in order to trigger subworkflows
+     *
+	 * @param $target_form
+	 * @param $order_id
+	 *
+	 * @return array
+	 */
 	private function _create_per_bundle_action_entries($target_form, $order_id) {
 
 		$action_entries_ids = array();