From c6c10587c8513e7293195f396a9c7ff10ada85cd Mon Sep 17 00:00:00 2001
From: Bilal <bilal@saburly.com>
Date: Thu, 23 Jul 2020 15:33:07 +0200
Subject: [PATCH 1/2] fix bug with autoplay

---
 app/assets/javascripts/channels/broadcasts.coffee | 2 +-
 app/assets/javascripts/stream_player.js.erb       | 4 ++--
 app/views/broadcasts/_video.html.erb              | 4 ++--
 spec/features/user_managing_broadcasts_spec.rb    | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/assets/javascripts/channels/broadcasts.coffee b/app/assets/javascripts/channels/broadcasts.coffee
index 823da04..536431d 100644
--- a/app/assets/javascripts/channels/broadcasts.coffee
+++ b/app/assets/javascripts/channels/broadcasts.coffee
@@ -21,7 +21,7 @@ $(document).on "turbolinks:load", ->
 
     refreshBroadcastVideo: (data) ->
       $("#broadcast_updates").html data.status_content
-      stream_selected = $("#broadcast_video").attr('video-type') == 'stream';
+      stream_selected = $("#broadcast_video").data('videoType') == 'stream';
       if data.streamer_status == 'recording' && data.status == 'active' && stream_selected
         $("#broadcast_video").html data.video_content
         new (Clappr.Player)(
diff --git a/app/assets/javascripts/stream_player.js.erb b/app/assets/javascripts/stream_player.js.erb
index 4a9f00d..a59e859 100644
--- a/app/assets/javascripts/stream_player.js.erb
+++ b/app/assets/javascripts/stream_player.js.erb
@@ -3,7 +3,7 @@ $(document).on("click", "[data-behavior=play_recording]", function() {
         return false;
     }
 
-    $("#broadcast_video").attr('video-type', 'recording');
+    $("#broadcast_video").data('videoType', 'recording');
 
     var playback_url = $(this).attr("data-playback-url")
     $("#broadcast_video").empty();
@@ -25,4 +25,4 @@ $(document).on("click", "[data-behavior=play_recording]", function() {
     $(this).prepend('<i class="fa fa-check">&nbsp;</i>');
 });
 
-$(document).on("click", "[data-behavior=play_stream]", function() { $("#broadcast_video").attr('video-type', 'stream'); });
\ No newline at end of file
+$(document).on("click", "[data-behavior=play_stream]", function() { $("#broadcast_video").data('videoType', 'stream'); });
\ No newline at end of file
diff --git a/app/views/broadcasts/_video.html.erb b/app/views/broadcasts/_video.html.erb
index 45fccca..9c44e2a 100644
--- a/app/views/broadcasts/_video.html.erb
+++ b/app/views/broadcasts/_video.html.erb
@@ -1,7 +1,7 @@
 <% if broadcast.streamer_recording? && broadcast.active? %>
-  <div id="broadcast_video" class="embed-responsive-item"></div>
+  <div id="broadcast_video" class="embed-responsive-item" data-video-type="stream"></div>
 <% else %>
-  <div id="broadcast_video" class="embed-responsive-item">
+  <div id="broadcast_video" class="embed-responsive-item" data-video-type="stream">
     <table class="w-100 h-100 bg-secondary">
       <tbody>
         <tr>
diff --git a/spec/features/user_managing_broadcasts_spec.rb b/spec/features/user_managing_broadcasts_spec.rb
index b20cabc..320ef78 100644
--- a/spec/features/user_managing_broadcasts_spec.rb
+++ b/spec/features/user_managing_broadcasts_spec.rb
@@ -93,7 +93,7 @@ feature 'User managing broadcasts' do
       BroadcastsChannel.broadcast_stream_updates(broadcast)
 
       expect(page).to have_content stream_begun_message
-      expect(page).to have_selector('div#broadcast_video', count: 1)
+      expect(page).to have_selector('div#broadcast_video', count: 2)
 
       broadcast.streamer_status = :idle
       broadcast.status = :idle
-- 
2.47.3


From 7fe1dadaf2f60c8b546a656755880c390f25298c Mon Sep 17 00:00:00 2001
From: Bilal <bilal@saburly.com>
Date: Fri, 24 Jul 2020 03:21:43 +0200
Subject: [PATCH 2/2] fix failing spec related to clappr ttf asset

---
 .../channels/{broadcasts.coffee => broadcasts.coffee.erb}        | 1 +
 1 file changed, 1 insertion(+)
 rename app/assets/javascripts/channels/{broadcasts.coffee => broadcasts.coffee.erb} (96%)

diff --git a/app/assets/javascripts/channels/broadcasts.coffee b/app/assets/javascripts/channels/broadcasts.coffee.erb
similarity index 96%
rename from app/assets/javascripts/channels/broadcasts.coffee
rename to app/assets/javascripts/channels/broadcasts.coffee.erb
index 536431d..b2e1f4a 100644
--- a/app/assets/javascripts/channels/broadcasts.coffee
+++ b/app/assets/javascripts/channels/broadcasts.coffee.erb
@@ -25,6 +25,7 @@ $(document).on "turbolinks:load", ->
       if data.streamer_status == 'recording' && data.status == 'active' && stream_selected
         $("#broadcast_video").html data.video_content
         new (Clappr.Player)(
+          <%= "baseUrl: 'http://cdn.clappr.io/latest'," if Rails.env.test? %>
           parentId: '#broadcast_video'
           source: data.full_live_stream_playback_url
           width: '100%',
-- 
2.47.3