From 6930317a7aecc3939394a4e92250c6372272ab9e Mon Sep 17 00:00:00 2001 From: Bilal Date: Wed, 15 Jul 2020 18:17:36 +0200 Subject: [PATCH 1/3] display only few information on public audition page --- app/views/public/casting_calls/show.html.erb | 11 +---- db/structure.sql | 14 ------- .../user_managing_casting_calls_spec.rb | 41 +++++++++++++++++++ 3 files changed, 42 insertions(+), 24 deletions(-) diff --git a/app/views/public/casting_calls/show.html.erb b/app/views/public/casting_calls/show.html.erb index ae634f7..c9ec824 100644 --- a/app/views/public/casting_calls/show.html.erb +++ b/app/views/public/casting_calls/show.html.erb @@ -12,20 +12,11 @@ <%= card_header text: @casting_call.title %>
-
+
<%= description_list_pair_for @casting_call, :title, append: ":" %> <%= description_list_pair_for @casting_call, :description, append: ":" %> <%= description_list_pair_for @casting_call, :project_description, append: ":" %> - <%= description_list_pair_for @casting_call, :created_at, append: ":" %> -
-
-
-
- <%= description_list_pair_for @casting_call, :status, append: ":" %> - <%= description_list_pair_for @casting_call, :interview_instructions, append: ":" %> - <%= description_list_pair_for @casting_call, :interview_requirements, append: ":" %> - <%= description_list_pair_for @casting_call, :questions, append: ":" %>
diff --git a/db/structure.sql b/db/structure.sql index fcd9e16..c0259b4 100644 --- a/db/structure.sql +++ b/db/structure.sql @@ -9,20 +9,6 @@ SET xmloption = content; SET client_min_messages = warning; SET row_security = off; --- --- Name: plpgsql; Type: EXTENSION; Schema: -; Owner: - --- - -CREATE EXTENSION IF NOT EXISTS plpgsql WITH SCHEMA pg_catalog; - - --- --- Name: EXTENSION plpgsql; Type: COMMENT; Schema: -; Owner: - --- - -COMMENT ON EXTENSION plpgsql IS 'PL/pgSQL procedural language'; - - -- -- Name: fuzzystrmatch; Type: EXTENSION; Schema: -; Owner: - -- diff --git a/spec/features/user_managing_casting_calls_spec.rb b/spec/features/user_managing_casting_calls_spec.rb index f42f125..5487522 100644 --- a/spec/features/user_managing_casting_calls_spec.rb +++ b/spec/features/user_managing_casting_calls_spec.rb @@ -74,6 +74,43 @@ feature "User managing casting calls" do expect(page).to have_content("The casting call request has been cancelled") end + scenario "can open casting call details" do + cc = create(:casting_call, title: "Dummy title", project: project) + + visit project_casting_calls_path(project) + + click_on manage_button + click_on view_button + + expect(page).to have_content cc.title + expect(page).to have_content cc.description + expect(page).to have_content cc.project_description + expect(page).to have_content cc.created_at + expect(page).to have_content cc.status + expect(page).to have_content cc.interview_instructions + expect(page).to have_content cc.interview_requirements + expect(page).to have_content cc.questions + end + + context "when signed out" do + scenario "user opens public accessible casting call URL" do + cc = create(:casting_call, title: "Dummy title", project: project) + + sign_out + public_url = "/casting_calls/#{cc.token}" + visit public_url + + expect(page).to have_content cc.title + expect(page).to have_content cc.description + expect(page).to have_content cc.project_description + expect(page).not_to have_content cc.created_at + expect(page).not_to have_content cc.status + expect(page).not_to have_content cc.interview_instructions + expect(page).not_to have_content cc.interview_requirements + expect(page).not_to have_content cc.questions + end + end + private def no_casting_calls_label @@ -84,6 +121,10 @@ feature "User managing casting calls" do t "casting_calls.casting_call.actions.manage" end + def view_button + 'View' + end + def add_new_casting_call_label t "casting_calls.index.actions.new" end -- 2.47.3 From 25dfd3bc58cfe1bb2d5f71ccef0c7497d0561485 Mon Sep 17 00:00:00 2001 From: Bilal Date: Thu, 16 Jul 2020 18:24:15 +0200 Subject: [PATCH 2/3] fix spec --- spec/controllers/public/casting_calls_controller_spec.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/spec/controllers/public/casting_calls_controller_spec.rb b/spec/controllers/public/casting_calls_controller_spec.rb index e7ce2c5..65b69fd 100644 --- a/spec/controllers/public/casting_calls_controller_spec.rb +++ b/spec/controllers/public/casting_calls_controller_spec.rb @@ -19,9 +19,6 @@ RSpec.describe Public::CastingCallsController, type: :controller do expect(response.body).to have_content(casting_call.title) expect(response.body).to have_content(casting_call.description) expect(response.body).to have_content(casting_call.project_description) - expect(response.body).to have_content(casting_call.interview_instructions) - expect(response.body).to have_content(casting_call.interview_requirements) - expect(response.body).to have_content(casting_call.questions) expect(response.body).to have_link("Schedule an Audition") end end -- 2.47.3 From 627e5f810807d3d88a41d1c89fecb894cf76f9ba Mon Sep 17 00:00:00 2001 From: Bilal Date: Fri, 17 Jul 2020 07:09:59 +0200 Subject: [PATCH 3/3] rebase --- db/structure.sql | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/db/structure.sql b/db/structure.sql index c0259b4..d324cbe 100644 --- a/db/structure.sql +++ b/db/structure.sql @@ -317,8 +317,8 @@ CREATE TABLE public.appearance_releases ( person_last_name character varying, guardian_first_name character varying, guardian_last_name character varying, - guardian_email character varying, identifier character varying, + guardian_email character varying, person_address_street2 character varying, person_address_city character varying, person_address_state character varying, @@ -728,15 +728,6 @@ CREATE SEQUENCE public.contract_templates_id_seq ALTER SEQUENCE public.contract_templates_id_seq OWNED BY public.contract_templates.id; --- --- Name: data_migrations; Type: TABLE; Schema: public; Owner: - --- - -CREATE TABLE public.data_migrations ( - version character varying NOT NULL -); - - -- -- Name: directories; Type: TABLE; Schema: public; Owner: - -- @@ -1478,6 +1469,7 @@ CREATE TABLE public.settings ( -- CREATE SEQUENCE public.settings_id_seq + AS integer START WITH 1 INCREMENT BY 1 NO MINVALUE @@ -1513,6 +1505,7 @@ CREATE TABLE public.taggings ( -- CREATE SEQUENCE public.taggings_id_seq + AS integer START WITH 1 INCREMENT BY 1 NO MINVALUE @@ -1543,6 +1536,7 @@ CREATE TABLE public.tags ( -- CREATE SEQUENCE public.tags_id_seq + AS integer START WITH 1 INCREMENT BY 1 NO MINVALUE @@ -1903,9 +1897,9 @@ CREATE TABLE public.zoom_meetings ( api_meeting_id character varying, created_at timestamp(6) without time zone NOT NULL, updated_at timestamp(6) without time zone NOT NULL, - status integer DEFAULT 0, zoom_user_id bigint, - project_id bigint + project_id bigint, + status integer DEFAULT 0 ); @@ -2412,14 +2406,6 @@ ALTER TABLE ONLY public.contract_templates ADD CONSTRAINT contract_templates_pkey PRIMARY KEY (id); --- --- Name: data_migrations data_migrations_pkey; Type: CONSTRAINT; Schema: public; Owner: - --- - -ALTER TABLE ONLY public.data_migrations - ADD CONSTRAINT data_migrations_pkey PRIMARY KEY (version); - - -- -- Name: directories directories_pkey; Type: CONSTRAINT; Schema: public; Owner: - -- -- 2.47.3