From ea025a86b3762b091ca7beb83778d046fe7d905f Mon Sep 17 00:00:00 2001
From: Bilal <bilal@saburly.com>
Date: Wed, 1 Jul 2020 11:09:47 +0200
Subject: [PATCH] fix MR comments

---
 config/locales/en.yml                         |  4 ++--
 .../user_manages_contract_templates_spec.rb   | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/config/locales/en.yml b/config/locales/en.yml
index 120ba93..ea0c740 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -341,11 +341,11 @@ en:
       notice: The release has been updated
   helpers:
     help:
-      task_request:
-        time_allowed: Minimum of 2 hours, no partial hours allowed
       contract_template:
         fee: Leave at $0.00 for no-fee
         guardian_clause: Leave blank if not required for this contract
+      task_request:
+        time_allowed: Minimum of 2 hours, no partial hours allowed
       video:
         audio_only_edl_file: If you do not upload an Audio Only EDL, the software will not generate a BiG Music Cue Sheet.
         edl_file: Please follow our directions on exporting the All Tracks EDL. Failure to do so could result in inaccurate and incomplete reporting.
diff --git a/spec/features/user_manages_contract_templates_spec.rb b/spec/features/user_manages_contract_templates_spec.rb
index 9d29f28..6fe9915 100644
--- a/spec/features/user_manages_contract_templates_spec.rb
+++ b/spec/features/user_manages_contract_templates_spec.rb
@@ -15,6 +15,7 @@ RSpec.feature 'User manages contract templates', type: :feature do
     visit project_contract_templates_path(project)
 
     expect(page).to have_content schedule_demo
+    expect(page).to have_content create_release_template
   end
 
   scenario 'creating a new release template' do
@@ -236,6 +237,13 @@ RSpec.feature 'User manages contract templates', type: :feature do
       expect(page).not_to have_content(import_template_button)
       expect(page).not_to have_content('Delete')
     end
+
+    it 'does not show create release button on splash page' do
+      visit project_contract_templates_path(project)
+
+      expect(page).to have_content schedule_demo
+      expect(page).not_to have_content create_release_template
+    end
   end
 
   context 'When the user is account manager' do
@@ -249,6 +257,13 @@ RSpec.feature 'User manages contract templates', type: :feature do
       click_on 'Manage'
       expect(page).to have_content('Archive')
     end
+
+    it 'does not show create release button on splash page' do
+      visit project_contract_templates_path(project)
+
+      expect(page).to have_content schedule_demo
+      expect(page).to have_content create_release_template
+    end
   end
 
   private
@@ -284,4 +299,8 @@ RSpec.feature 'User manages contract templates', type: :feature do
   def schedule_demo
     t 'contract_templates.splash.actions.book_demo'
   end
+
+  def create_release_template
+    t 'contract_templates.splash.actions.create_template'
+  end
 end