Upstream sync

spec/features/admin_managing_task_requests_spec.rb

@@ -0,0 +1,108 @@
+require "rails_helper"
+
+feature "Admin managing task requests" do
+  let(:current_user) { create(:user, admin: true, email: "user@test.com") }
+  let(:project) { create(:project, account: current_user.primary_account, name: "Test Project") }
+
+  before do
+    sign_in current_user
+  end
+
+  scenario "admin should see View action for task request in Manage dropdown", js: true do
+    create(:task_request)
+    visit admin_task_requests_path
+
+    click_on 'Manage'
+    expect(page).to have_content 'View'
+  end
+
+  scenario "admin can open detail view of task request", js: true do
+    task_request = create(:task_request, :with_files)
+    visit admin_task_requests_path
+
+    click_on 'Manage'
+    click_link 'View'
+    switch_to_window(windows.last)
+
+    expect(page).to have_content 'Account Name'
+    expect(page).to have_content  task_request.project.account.name
+
+    expect(page).to have_content 'Project Name'
+    expect(page).to have_content task_request.project.name
+
+    expect(page).to have_content 'Description'
+    expect(page).to have_content  task_request.description
+
+    expect(page).to have_content 'Created At'
+    expect(page).to have_content task_request.created_at
+
+    expect(page).to have_content 'User Email'
+    expect(page).to have_content task_request.user_email
+
+    expect(page).to have_content 'Deadline'
+    expect(page).to have_content task_request.deadline
+
+    expect(page).to have_content 'Time Allowed'
+    expect(page).to have_content task_request.time_allowed
+
+    expect(page).to have_content 'Additional Notes'
+    expect(page).to have_content task_request.additional_notes
+
+    expect(page).to have_content 'Status'
+    expect(page).to have_content task_request.status
+
+    expect(page).to have_content 'Files'
+    task_request.files.each do |file|
+      expect(page).to have_content file.blob.filename
+    end
+  end
+
+  scenario "no files attached label is shown if there are no files attached to the task request", js:true do
+    create(:task_request)
+    visit admin_task_requests_path
+
+    click_on 'Manage'
+    click_link 'View'
+    switch_to_window(windows.last)
+
+    expect(page).to have_content 'Attached files will appear here.'
+  end
+
+  scenario "task requests table is visible" do
+    visit admin_task_requests_path
+
+    expect(page).to have_content "Task ID"
+    expect(page).to have_content "Account Name"
+    expect(page).to have_content "Project Name"
+    expect(page).to have_content "Created On"
+    expect(page).to have_content "Deadline"
+    expect(page).to have_content "Time Allowed"
+    expect(page).to have_content "Status"
+  end
+
+  scenario "sees list of task requests" do
+    visit admin_task_requests_path
+
+    expect(page).to have_content no_task_requests_label
+
+    task_request = create(:task_request)
+
+    visit admin_task_requests_path
+
+    expect(page).not_to have_content no_task_requests_label
+
+    expect(page).to have_content task_request.id
+    expect(page).to have_content task_request.project.account.name
+    expect(page).to have_content task_request.project.name
+    expect(page).to have_content task_request.created_at.try(:strftime, '%D')
+    expect(page).to have_content task_request.deadline.try(:strftime, '%D')
+    expect(page).to have_content task_request.time_allowed
+    expect(page).to have_content task_request.status.capitalize
+  end
+
+  private
+
+  def no_task_requests_label
+    "Task requests will appear here"
+  end
+end

spec/features/user_creates_task_request_spec.rb

@@ -0,0 +1,92 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.feature 'User creates task request', type: :feature do
+  let(:current_user) { create(:user, :manager) }
+  let(:project) { create(:project, members: current_user, account: current_user.primary_account) }
+
+  before do
+    sign_in(current_user)
+  end
+
+  scenario 'creating a new task request' do
+    visit new_project_task_request_path(project)
+
+    fill_in description_field, with: 'Description of the task'
+    fill_in deadline_field, with: '2020-06-24'
+    fill_in time_allowed_field, with: '30'
+    fill_in additional_notes_field, with: 'Additional note about the task'
+
+    click_on 'Create Task request'
+
+    expect(page).to have_content task_created_message
+  end
+
+  scenario 'user can view task request details' do
+    create(:task_request, project: project, description: 'Description of the task', deadline: '2020-07-23', time_allowed: '10', additional_notes: 'Additional note about the task')
+    
+    visit project_task_request_path(project, TaskRequest.first)
+
+    expect(page).to have_content('Description of the task')
+    expect(page).to have_content('2020-07-23')
+    expect(page).to have_content('10')
+    expect(page).to have_content('Additional note about the task')
+  end
+
+  scenario 'user can update existing task request' do
+    create(:task_request, project: project, description: 'Description of the task', deadline: '2020-08-23', time_allowed: '10', additional_notes: 'Additional note about the task')
+
+    visit edit_project_task_request_path(project, TaskRequest.first)
+
+    fill_in deadline_field, with: '2020-07-01'
+    fill_in time_allowed_field, with: '13'
+
+    click_on 'Update Task request'
+    expect(page).to have_content('13')
+    expect(page).to have_content('07/01/20')
+  end
+
+  scenario 'user can cancel a task request' do
+    create(:task_request, project: project, description: 'Description of the task', deadline: '2020-08-23', time_allowed: '10', additional_notes: 'Additional note about the task')
+
+    visit project_task_requests_path(project)
+
+    click_on 'Manage'
+    click_link 'Cancel'
+
+    expect(page).to have_content('Cancelled')
+  end
+
+  scenario 'user can view completed tasks' do
+    create_list(:task_request, 5, project: project, status: 'completed')
+    create_list(:task_request, 5, project: project, status: 'pending')
+
+    visit project_tasks_path(project)
+
+    expect(page).to have_content('Completed')
+    expect(page).not_to have_content('Pending')
+  end
+
+  private
+
+  def description_field
+    t "task_requests.form.labels.description"
+  end
+
+  def deadline_field
+    t "task_requests.form.labels.deadline"
+  end
+
+  def time_allowed_field
+    t "task_requests.form.labels.time_allowed"
+  end
+
+  def additional_notes_field
+    t "task_requests.form.labels.additional_notes"
+  end
+
+  def task_created_message
+    t 'task_requests.create.success_message'
+  end
+end

spec/features/user_managing_task_requests_spec.rb

@@ -0,0 +1,116 @@
+require "rails_helper"
+
+feature "User managing task requests" do
+  let(:current_user) { create(:user) }
+  let(:project) { create(:project, account: current_user.primary_account) }
+
+  before :each do
+    sign_in current_user
+  end
+
+  scenario "task requests table is visible" do
+    visit project_task_requests_path(project)
+
+    expect(page).to have_content "Created On"
+    expect(page).to have_content "Deadline"
+    expect(page).to have_content description_column
+    expect(page).to have_content "Time Allowed"
+    expect(page).to have_content "Status"
+  end
+
+  scenario "sees list of task requests" do
+    visit project_task_requests_path(project)
+
+    expect(page).to have_content no_task_requests_label
+
+    task_request = create(:task_request, project: project)
+
+    visit project_task_requests_path(project)
+
+    expect(page).not_to have_content no_task_requests_label
+
+    expect(page).to have_content task_request.created_at.try(:strftime, '%D')
+    expect(page).to have_content task_request.deadline.try(:strftime, '%D')
+    expect(page).to have_content task_request.time_allowed
+    expect(page).to have_content task_request.status.capitalize
+  end
+
+  scenario "full description is shown if description text is not truncated" do
+    visit project_task_requests_path(project)
+
+    task_request = create(:task_request, project: project, description: 'Short Desc')
+    visit project_task_requests_path(project)
+
+    expect(page).to have_content task_request.description
+  end
+
+  scenario "truncated description is shown if description text is too long" do
+    visit project_task_requests_path(project)
+
+    task_request = create(:task_request,
+                          project: project,
+                          description: long_description_text)
+    visit project_task_requests_path(project)
+
+    expect(page).not_to have_content task_request.description
+    truncated_text = "#{task_request.description[0..26]}...read more"
+    expect(page).to have_content truncated_text
+  end
+
+  scenario "full description is shown when user hovers over read more link in description colum", js: true do
+    visit project_task_requests_path(project)
+
+    task_request = create(:task_request,
+                          project: project,
+                          description: long_description_text)
+    visit project_task_requests_path(project)
+
+    page.execute_script '$("a[data-toggle=popover]").trigger("mouseover")'
+    expect(page).to have_content task_request.description
+  end
+
+  scenario "user does not see open deliverable action in manage dropdown if task status is not completed" do
+    task_request = create(:task_request, project: project)
+    visit project_task_requests_path(project)
+
+    click_on manage_button
+    expect(page).not_to have_content open_deliverable_action_label
+  end
+
+  scenario "user can click deliverable action in manage dropdown if task status is completed", js: true do
+    create(:task_request, project: project, status: "completed", deliverable_url: "/")
+    visit project_task_requests_path(project)
+
+    click_on manage_button
+    expect(page).to have_content open_deliverable_action_label
+    click_link open_deliverable_action_label
+    switch_to_window(windows.last)
+    expect(page).to have_content add_new_project_label
+  end
+
+  private
+
+  def no_task_requests_label
+    "Task requests will appear here"
+  end
+
+  def manage_button
+    t "task_requests.task_request.actions.manage"
+  end
+
+  def open_deliverable_action_label
+    t "task_requests.task_request.actions.open_deliverable"
+  end
+
+  def add_new_project_label
+    t "projects.index.actions.new"
+  end
+
+  def description_column
+    t 'task_requests.index.table_headers.task_request_description'
+  end
+
+  def long_description_text
+    'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+  end
+end