Upstream sync

spec/controllers/accounts_controller_spec.rb

@@ -57,6 +57,8 @@ RSpec.describe AccountsController, type: :controller do
         expect {
           post :create, params: params
         }.to have_enqueued_job(SubmitHubspotFormJob).with(
+          "John",
+          "Doe",
           "test_user+1@test.com", 
           "Test Dev account", 
           i_m_interested_in: "DirectME"

spec/controllers/admin/task_requests_controller_spec.rb

@@ -0,0 +1,68 @@
+require "rails_helper"
+
+RSpec.describe Admin::TaskRequestsController, type: :controller do
+  render_views
+
+  let!(:current_user) { create(:user, :admin) }
+
+  before do
+    sign_in(current_user)
+  end
+
+  describe "#index" do
+    it "returns a successful response" do
+      get :index
+
+      expect(response).to be_successful
+    end
+  end
+
+  describe "#edit" do
+    let(:task_request) { create(:task_request) }
+
+    it "returns a successful response" do
+      get :edit, params: { id: task_request }
+
+      expect(response).to be_successful
+    end
+
+    it "assigns task request" do
+      get :edit, params: { id: task_request }
+
+      expect(assigns(:task_request)).to eq task_request
+    end
+  end
+
+  describe "#update" do
+    let(:task_request) { create(:task_request) }
+
+    it "redirects to task requests page" do
+      patch :update, params: { id: task_request, task_request: update_params }
+
+      expect(response).to be_redirect
+      expect(response).to redirect_to admin_task_requests_path
+    end
+
+    it "sets a flash notice" do
+      patch :update, params: { id: task_request, task_request: update_params }
+
+      expect(flash.notice).to eq "The task request has been updated successfully"
+    end
+
+    it "updates task request" do
+      patch :update, params: { id: task_request, task_request: update_params }
+
+      expect(task_request.reload.status).to eq("completed")
+      expect(task_request.reload.deliverable_url).to eq("example.com/deliverables")
+    end
+  end
+
+  private
+
+  def update_params
+    {
+      status: "completed",
+      deliverable_url: "example.com/deliverables"
+    }
+  end
+end

spec/controllers/api/appearance_releases_controller_spec.rb

@@ -37,23 +37,26 @@ RSpec.describe Api::AppearanceReleasesController, type: :controller do
 
     it 'includes photos' do
       project = create(:project, account_id: current_user.primary_account.id)
-      appearance_release = create(:appearance_release, person_first_name: 'Release', person_last_name: 'Name', project: project)
+      appearance_release = create(:appearance_release,
+                                  :with_person_photo, :with_guardian_photo, :with_guardian_2_photo,
+                                  project: project)
 
       sign_in_to_api(current_user)
       get :show, params: { id: appearance_release.id }
 
-      photo = appearance_release.person_photo
-      data = {
-        'id' => photo.id.to_s,
-        'type' => 'active_storage_attachment',
-        'attributes' => {
-          'content_type' => photo.content_type,
-          'filename' => photo.filename.to_s,
-          'url' => photo_path_for(photo),
-          'thumbnail_url' => photo_variant_path_for(photo, '150x150')
+      [appearance_release.person_photo, appearance_release.guardian_photo, appearance_release.guardian_2_photo].each do |photo|
+        data = {
+          'id' => photo.id.to_s,
+          'type' => 'active_storage_attachment',
+          'attributes' => {
+            'content_type' => photo.content_type,
+            'filename' => photo.filename.to_s,
+            'url' => photo_path_for(photo),
+            'thumbnail_url' => photo_variant_path_for(photo, '150x150')
+          }
         }
-      }
-      expect(response_body_included_attributes).to include(data)
+        expect(response_body_included_attributes).to include(data)
+      end
     end
   end
 
@@ -184,7 +187,46 @@ RSpec.describe Api::AppearanceReleasesController, type: :controller do
       expect(appearance_release.guardian_photo).to be_attached
     end
 
+    it 'returns 201 for minor without second guardian photo' do
+      post :create, params: @parameters.deep_merge(appearance_release: {
+        minor: true,
+        guardian_2_name: 'Guardian 2 Name',
+        guardian_2_phone: '101010',
+      })
 
+      expect(response.status).to eq 201
+      expect(AppearanceRelease.last.signature).to be_attached
+      expect(AppearanceRelease.last.guardian_2_photo).not_to be_attached
+    end
+
+    it 'returns 201 for minor with second guardian photo' do
+      post :create, params: @parameters.deep_merge(appearance_release: {
+        minor: true,
+        guardian_2_name: 'Guardian 2 Name',
+        guardian_2_phone: '101010',
+        guardian_2_photo: {
+          io: guardian_photo_base64,
+          filename: 'guardian_2_photo.jpeg'
+        }
+      })
+      expect(response.status).to eq 201
+
+      appearance_release = AppearanceRelease.last
+      photo = appearance_release.guardian_2_photo
+      data = {
+        'id' => photo.id.to_s,
+        'type' => 'active_storage_attachment',
+        'attributes' => {
+          'content_type' => photo.content_type,
+          'filename' => photo.filename.to_s,
+          'url' => photo_path_for(photo),
+          'thumbnail_url' => photo_variant_path_for(photo, '150x150')
+        }
+      }
+      expect(response_body_included_attributes).to include(data)
+      expect(appearance_release.signature).to be_attached
+      expect(appearance_release.guardian_2_photo).to be_attached
+    end
   end
 
   private

spec/controllers/api/talent_releases_controller_spec.rb

@@ -32,26 +32,28 @@ RSpec.describe Api::TalentReleasesController, type: :controller do
     end
 
     it 'includes photos' do
-          tested_release = create("talent_release_with_photo", person_name: 'Release 1', project: project)
+      project = create(:project, account_id: current_user.primary_account.id)
+      talent_release = create(:talent_release,
+                              :with_guardian_photo, :with_guardian_2_photo,
+                              project: project)
 
-          sign_in_to_api(current_user)
-          get :show, params: { id: tested_release.id }
+      sign_in_to_api(current_user)
+      get :show, params: { id: talent_release.id }
 
-          tested_release.photos.each do |photo|
-            data = {
-              'id' => photo.id.to_s,
-              'type' => 'active_storage_attachment',
-              'attributes' => {
-                'content_type' => photo.content_type,
-                'filename' => photo.filename.to_s,
-                'url' => photo_path_for(photo),
-                'thumbnail_url' => photo_variant_path_for(photo, '150x150')
-              }
-            }
-
-            expect(response_body_included_attributes).to include(data)
-          end
-        end
+      [talent_release.photos, talent_release.guardian_photo, talent_release.guardian_2_photo].flatten.each do |photo|
+        data = {
+          'id' => photo.id.to_s,
+          'type' => 'active_storage_attachment',
+          'attributes' => {
+            'content_type' => photo.content_type,
+            'filename' => photo.filename.to_s,
+            'url' => photo_path_for(photo),
+            'thumbnail_url' => photo_variant_path_for(photo, '150x150')
+          }
+        }
+        expect(response_body_included_attributes).to include(data)
+      end
+    end
   end
 
   describe '#create' do
@@ -180,6 +182,47 @@ RSpec.describe Api::TalentReleasesController, type: :controller do
       expect(talent_release.signature).to be_attached
       expect(talent_release.guardian_photo).to be_attached
     end
+
+    it 'returns 201 for minor without second guardian photo' do
+      post :create, params: @parameters.deep_merge(talent_release: {
+        minor: true,
+        guardian_2_name: 'Guardian 2 Name',
+        guardian_2_phone: '101010',
+      })
+
+      expect(response.status).to eq 201
+      expect(TalentRelease.last.signature).to be_attached
+      expect(TalentRelease.last.guardian_2_photo).not_to be_attached
+    end
+
+    it 'returns 201 for minor with second guardian photo' do
+      post :create, params: @parameters.deep_merge(talent_release: {
+        minor: true,
+        guardian_2_name: 'Guardian 2 Name',
+        guardian_2_phone: '101010',
+        guardian_2_photo: {
+          io: guardian_photo_base64,
+          filename: 'guardian_2_photo.jpeg'
+        }
+      })
+      expect(response.status).to eq 201
+
+      talent_release = TalentRelease.last
+      photo = talent_release.guardian_2_photo
+      data = {
+        'id' => photo.id.to_s,
+        'type' => 'active_storage_attachment',
+        'attributes' => {
+          'content_type' => photo.content_type,
+          'filename' => photo.filename.to_s,
+          'url' => photo_path_for(photo),
+          'thumbnail_url' => photo_variant_path_for(photo, '150x150')
+        }
+      }
+      expect(response_body_included_attributes).to include(data)
+      expect(talent_release.signature).to be_attached
+      expect(talent_release.guardian_2_photo).to be_attached
+    end
   end
 
   private

spec/controllers/stream_notifications_controller_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe StreamNotificationsController, type: :controller do
   let(:active_status) { {type: "video.live_stream.active", object: { id: "mux_stream" }} }
   let(:disconnected_status) { {type: "video.live_stream.disconnected", object: { id: "mux_stream" }} }
   let(:idle_status) { {type: "video.live_stream.idle", object: { id: "mux_stream" }} }
+  let(:idle_status_for_unknown_broadcast) { {type: "video.live_stream.idle", object: { id: "unknown-id" }} }
   let(:asset_ready) { {
     type: "video.asset.static_renditions.ready",
     object: { id: "asset_uid" },
@@ -59,6 +60,12 @@ RSpec.describe StreamNotificationsController, type: :controller do
 
       expect(BroadcastsChannel).to have_received(:stream_recording_ready)
     end
+
+    it "returns OK response even for non-existing broadcast" do
+      post :create, params: idle_status_for_unknown_broadcast
+
+      expect(response).to be_successful
+    end
   end
 
   after do

spec/controllers/task_requests_controller_spec.rb

@@ -0,0 +1,129 @@
+require 'rails_helper'
+
+RSpec.describe TaskRequestsController, type: :controller do
+  render_views
+
+  let(:user) { create(:user) }
+  let(:account) { user.primary_account }
+  let(:project) { create(:project, account: user.primary_account) }
+
+  before do
+    sign_in user
+  end
+
+  describe "#index" do
+    it "responds successfully" do
+      get :index, params: { project_id: project }
+
+      expect(response).to be_successful
+    end
+
+    it "renders content" do
+      create(:task_request, project: project, description: "Another Request")
+
+      get :index, params: { project_id: project }
+
+      expect(response.body).to have_link "Create Task Request"
+      expect(response.body).to have_content "Pending"
+    end
+
+    context "when there are many records" do
+      it "paginates the table" do
+        create_list(:task_request, 20, project: project)
+
+        get :index, params: { project_id: project }
+
+        expect(response.body).to have_link("2", href: project_task_requests_path(project, page: 2))
+      end
+    end
+  end
+
+  describe "#new" do
+    it "responds successfully" do
+      get :new, params: { project_id: project }
+
+      expect(response).to be_successful
+      expect(assigns(:task_request)).to be_a_new(TaskRequest)
+      expect(response).to render_template(:new)
+    end
+  end
+
+  describe "#create" do
+    it "does create a new record" do
+      expect {
+        post :create, params: { project_id: project.id, task_request: task_request_params }
+      }.to change(TaskRequest, :count)
+    end
+
+    it "logs an event" do
+      expect {
+        post :create, params: { project_id: project.id, task_request: task_request_params }
+      }.to have_enqueued_job(TrackAnalyticsJob).with(user,  account, :track_create_task_request, user_agent: "Rails Testing", user_ip: "0.0.0.0")
+    end
+
+    it "submits data to hubspot form" do
+      expect {
+        post :create, params: { project_id: project.id, task_request: task_request_params }
+      }.to have_enqueued_job(SubmitHubspotTaskRequestFormJob)
+    end
+  end
+
+  describe "#update" do
+    let!(:task_request) { create(:task_request, project: project, description: "My description" ) }
+
+    it "updates task request" do
+      patch :update, params: { project_id: project.id, id: task_request.id, task_request: update_params }
+
+      expect(task_request.reload.description).to eq("This is updated description")
+    end
+  end
+
+  describe "#show" do
+    let!(:task_request) { create(:task_request, project: project, description: "Task Request") }
+
+    it "responds successfully" do
+      get :show, params: { project_id: project.id, id: task_request.id }
+
+      expect(response).to be_successful
+      expect(assigns(:task_request)).to eq(task_request)
+    end
+
+    it "renders content" do
+      get :show, params: { project_id: project.id, id: task_request.id }
+      
+      expect(response.body).to have_content "Task Request"
+      expect(response.body).to have_content "pending"
+    end
+  end
+
+  describe "#cancel" do
+    let!(:task_request) { create(:task_request, project: project, description: "Task to be cancelled") }
+
+    it "responds with redirect" do
+      post :cancel, params: { project_id: project.id, id: task_request.id }
+
+      expect(response).to be_redirect
+      expect(response).to redirect_to(project_task_requests_path(project))
+      expect(flash.notice).not_to be_nil
+    end
+
+    it "updates the status to 'cancelled'" do
+      expect {
+        post :cancel, params: { project_id: project.id, id: task_request.id }
+      }.to change { task_request.reload.status }.from("pending").to("cancelled")
+    end
+  end
+
+  private
+
+  def task_request_params
+    attributes = attributes_for(:task_request).except(:status, :user_email)
+    files = 2.times.map { Rack::Test::UploadedFile.new(file_fixture("location_photo.png"), "image/png") }
+
+    attributes.merge({ files: files })
+  end
+
+  def update_params
+    { description: "This is updated description" }
+  end
+end

spec/controllers/tasks_controller_spec.rb

@@ -0,0 +1,40 @@
+require 'rails_helper'
+
+RSpec.describe TasksController, type: :controller do
+  render_views
+
+  let(:user) { create(:user) }
+  let(:account) { user.primary_account }
+  let(:project) { create(:project, account: user.primary_account) }
+
+  before do
+    sign_in user
+  end
+
+  describe "#index" do
+    it "responds successfully" do
+      get :index, params: { project_id: project }
+
+      expect(response).to be_successful
+    end
+
+    it "renders content" do
+      create(:task_request, :completed, project: project, description: "Another Request")
+
+      get :index, params: { project_id: project }
+
+      expect(response.body).to have_content "Completed"
+      expect(response.body).to have_link "View Deliverable"
+    end
+
+    context "when there are many records" do
+      it "paginates the table" do
+        create_list(:task_request, 20, :completed, project: project)
+
+        get :index, params: { project_id: project }
+
+        expect(response.body).to have_link("2", href: project_tasks_path(project, page: 2))
+      end
+    end
+  end
+end