From c32e8f51090d1d7f1a4f37873ce54b9ff6ed35ed Mon Sep 17 00:00:00 2001 From: Bilal Date: Mon, 7 Sep 2020 13:03:01 +0300 Subject: [PATCH] improve Download button for Music releases --- app/views/music_releases/index.html.erb | 3 ++- app/views/music_releases/index.js.erb | 2 ++ spec/jobs/generate_contracts_zip_job_spec.rb | 5 ++++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/app/views/music_releases/index.html.erb b/app/views/music_releases/index.html.erb index 3bb28ef..0b4cfc2 100644 --- a/app/views/music_releases/index.html.erb +++ b/app/views/music_releases/index.html.erb @@ -1,5 +1,6 @@
+ />
<% if policy(MusicRelease).new? %> <%= link_to fa_icon("plus", text: t(".actions.new")), [:new, @project, :music_release], class: "btn btn-primary mr-2 mb-2" %> @@ -10,7 +11,7 @@ <% end %> <% if @music_releases.any? && policy(MusicRelease).download_multiple? %> - <%= link_to "Download All", [@project, :contract_downloads, release_type: @music_releases.name], method: :post, remote: true, class: "btn btn-light border ml-auto mr-2 mb-2" %> + <%= button_to "Download", [@project, :contract_downloads, release_type: @music_releases.name], id: "download_releases", method: :post, remote: true, class: "btn btn-light border ml-auto mr-2 mb-2" %> <% end %> <%= bootstrap_form_with url: [@project, :music_releases], method: :get, remote: true, layout: :inline, id: "search" do |form| %> diff --git a/app/views/music_releases/index.js.erb b/app/views/music_releases/index.js.erb index 6c1706d..f3fc928 100644 --- a/app/views/music_releases/index.js.erb +++ b/app/views/music_releases/index.js.erb @@ -1,3 +1,5 @@ $("#music_releases").html("<%= j render(@music_releases) %>"); $("form input[type='search']").val("<%= params[:query] %>"); $("#music_releases_pagination").html("<%= j will_paginate(@music_releases) %>"); +$("#selected_releases_form").attr('data-releasable-ids', JSON.stringify([])); +$("#total_entries").val(<%= @music_releases.total_entries %>); \ No newline at end of file diff --git a/spec/jobs/generate_contracts_zip_job_spec.rb b/spec/jobs/generate_contracts_zip_job_spec.rb index ab6cdc5..aefe5b2 100644 --- a/spec/jobs/generate_contracts_zip_job_spec.rb +++ b/spec/jobs/generate_contracts_zip_job_spec.rb @@ -226,10 +226,13 @@ describe GenerateContractsZipJob do end context "generates ZIP for music releases" do - let(:release) { create(:music_release_with_contract_template, project: project) } + let(:release) { create(:music_release_with_contract_template, project: project, name: "John") } + let(:release2) { create(:music_release_with_contract_template, project: project, name: "Jane") } + let(:release3) { create(:music_release_with_contract_template, project: project, name: "Brad") } subject { 'MusicRelease' } it_behaves_like "generates ZIP containig CSV file with all releases data" + it_behaves_like "generates ZIP containig CSV file with specific releases data" end context "generates ZIP for talent releases" do